public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guomin Jiang" <guomin.jiang@intel.com>
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>,
	Agyeman Prince <prince.agyeman@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>
Subject: [edk2-platforms][PATCH] 2/3] Platform/Intel/SimicsOpenBoardPkg: Fix build error.
Date: Fri,  8 May 2020 17:16:20 +0800	[thread overview]
Message-ID: <20200508091621.2213-3-guomin.jiang@intel.com> (raw)
In-Reply-To: <20200508091621.2213-1-guomin.jiang@intel.com>

From: GuoMinJ <newexplorerj@gmail.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368

It seem that the '=' expression is unallowed and the value should be
hex.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
---
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
index 8a6c3792ba66..43960e3dd524 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
+++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
@@ -17,7 +17,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "SIMICS  ", 4) {
   Name (GPIC, Zero)
   Method (_PIC, 1, NotSerialized)  // _PIC: Interrupt Model
   {
-      GPIC = Arg0
+      Store(Arg0, GPIC)
   }
   //
   //  System Bus
@@ -372,7 +372,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "SIMICS  ", 4) {
 
             Package () {0x000EFFFF, 0x00, 0, 16},
             Package () {0x000EFFFF, 0x01, 0, 17},
-            Package () {0x000EFFFF, 0x02, 0C, 18},
+            Package () {0x000EFFFF, 0x02, 0x0C, 18},
             Package () {0x000EFFFF, 0x03, 0, 19},
 
             Package () {0x000FFFFF, 0x00, 0, 16},
-- 
2.25.1.windows.1


  parent reply	other threads:[~2020-05-08  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  9:16 [edk2-platforms][PATCH] 0/3] Remove All UGA Support Guomin Jiang
2020-05-08  9:16 ` [edk2-platforms][PATCH] 1/3] Platform/Intel: " Guomin Jiang
2020-05-08  9:16 ` Guomin Jiang [this message]
2020-05-08  9:16 ` [edk2-platforms][PATCH] 3/3] " Guomin Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508091621.2213-3-guomin.jiang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox