public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Pete Batard <pete@akeo.ie>, Jared McNeill <jmcneill@invisible.ca>,
	Andrei Warkentin <awarkentin@vmware.com>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH edk2-platforms v4 0/9] BCM genet fixes
Date: Mon, 11 May 2020 16:55:18 +0200	[thread overview]
Message-ID: <20200511145527.23453-1-ard.biesheuvel@arm.com> (raw)

This fixes the multicast/broadcast/promisc handling, and switches to
ordinary page allocations for RX buffers. Patch #1 is cosmetic only.

Note that these apply on top of the series sent out by Samer, and is
intended to be squashed into that series before merging.

Changes since v3:
- more cosmetic tweaks in #1
- move DmaUnmap() for TX buffers to the correct place
- use MemoryFence() instead of DSB for MMIO write ordering
- add unload support to the driver
- remove the Ax88772b driver from the RPi4 build - it is no longer needed,
  and misbehaves when no cable is connected.

Changes since v2:
- fix MDF filter handling (fixes issue reported by Samer)
- add patch to deal with ExitBootServices() so we don't leave the RX DMA
  ring running when we enter the OS

https://github.com/pftf/edk2-platforms/tree/rpi4_genet_v4_ardb

Cc: Pete Batard <pete@akeo.ie>
Cc: Jared McNeill <jmcneill@invisible.ca>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>

Ard Biesheuvel (9):
  Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup
  Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering
  Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling
  Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA
  Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices()
  Silicon/Broadcom/BcmGenetDxe: keep TX buffer mapped during DMA
    transfer
  Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write
    ordering
  Silicon/Broadcom/BcmGenetDxe: add unload support
  Platform/RaspberryPi4: remove ASIX 88772b driver

 Platform/RaspberryPi/RPi4/RPi4.dsc            |   1 -
 Platform/RaspberryPi/RPi4/RPi4.fdf            |   1 -
 .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf   |  13 +-
 .../Drivers/Net/BcmGenetDxe/GenetUtil.h       |  51 +-
 .../Drivers/Net/BcmGenetDxe/DriverBinding.c   | 122 ++-
 .../Drivers/Net/BcmGenetDxe/GenericPhy.c      |  16 +-
 .../Drivers/Net/BcmGenetDxe/GenetUtil.c       | 787 +++++++++---------
 .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c   | 115 ++-
 8 files changed, 621 insertions(+), 485 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-05-11 14:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 14:55 Ard Biesheuvel [this message]
2020-05-11 14:55 ` [PATCH edk2-platforms v4 1/9] Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup Ard Biesheuvel
2020-05-11 16:36   ` Samer El-Haj-Mahmoud
2020-05-11 21:14   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-11 14:55 ` [PATCH edk2-platforms v4 2/9] Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering Ard Biesheuvel
2020-05-11 16:44   ` Andrei Warkentin
2020-05-11 20:34   ` Jeremy Linton
2020-05-11 21:21     ` Ard Biesheuvel
2020-05-11 14:55 ` [PATCH edk2-platforms v4 3/9] Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling Ard Biesheuvel
2020-05-11 14:55 ` [PATCH edk2-platforms v4 4/9] Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA Ard Biesheuvel
2020-05-11 16:42   ` Andrei Warkentin
2020-05-11 16:53     ` Ard Biesheuvel
2020-05-11 14:55 ` [PATCH edk2-platforms v4 5/9] Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices() Ard Biesheuvel
2020-05-11 16:32   ` Andrei Warkentin
2020-05-11 14:55 ` [PATCH edk2-platforms v4 6/9] Silicon/Broadcom/BcmGenetDxe: keep TX buffer mapped during DMA transfer Ard Biesheuvel
2020-05-11 16:19   ` Andrei Warkentin
2020-05-11 14:55 ` [PATCH edk2-platforms v4 7/9] Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write ordering Ard Biesheuvel
2020-05-11 16:55   ` [edk2-devel] " Andrei Warkentin
2020-05-11 21:11   ` Philippe Mathieu-Daudé
2020-05-11 14:55 ` [PATCH edk2-platforms v4 8/9] Silicon/Broadcom/BcmGenetDxe: add unload support Ard Biesheuvel
2020-05-11 16:17   ` Andrei Warkentin
2020-05-11 14:55 ` [PATCH edk2-platforms v4 9/9] Platform/RaspberryPi4: remove ASIX 88772b driver Ard Biesheuvel
2020-05-11 16:06   ` Andrei Warkentin
2020-05-11 16:24   ` Samer El-Haj-Mahmoud
2020-05-11 23:20 ` [PATCH edk2-platforms v4 0/9] BCM genet fixes Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511145527.23453-1-ard.biesheuvel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox