* [PATCH v2 1/5] MdePkg: New Status Codes
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
@ 2020-05-11 20:24 ` Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 2/5] MdePkg: Updates to PI 1.7 Revision numbers for Oleksiy Yakovlev
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Oleksiy Yakovlev @ 2020-05-11 20:24 UTC (permalink / raw)
To: devel; +Cc: liming.gao, michael.d.kinney, Felixp, oleksiyy, robert
From: Robert Phelps <robert@ami.com>
Updated PiStatusCodes to reflect changes to PI 1.7 Specification
(PI 1.7 Mantis 1889)
Signed-off-by: Robert Phelps <robert@ami.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdePkg/Include/Pi/PiStatusCode.h | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Pi/PiStatusCode.h b/MdePkg/Include/Pi/PiStatusCode.h
index 0ffd29a714..9f6c2abaa7 100644
--- a/MdePkg/Include/Pi/PiStatusCode.h
+++ b/MdePkg/Include/Pi/PiStatusCode.h
@@ -340,6 +340,7 @@ typedef struct {
#define EFI_CHIPSET_EC_BAD_BATTERY (EFI_SUBCLASS_SPECIFIC | 0x00000000)
#define EFI_CHIPSET_EC_DXE_NB_ERROR (EFI_SUBCLASS_SPECIFIC | 0x00000001)
#define EFI_CHIPSET_EC_DXE_SB_ERROR (EFI_SUBCLASS_SPECIFIC | 0x00000002)
+#define EFI_CHIPSET_EC_INTRUDER_DETECT (EFI_SUBCLASS_SPECIFIC | 0x00000003)
///@}
///
@@ -361,6 +362,7 @@ typedef struct {
#define EFI_PERIPHERAL_AUDIO_OUTPUT (EFI_PERIPHERAL | 0x000A0000)
#define EFI_PERIPHERAL_LCD_DEVICE (EFI_PERIPHERAL | 0x000B0000)
#define EFI_PERIPHERAL_NETWORK (EFI_PERIPHERAL | 0x000C0000)
+#define EFI_PERIPHERAL_DOCKING (EFI_PERIPHERAL | 0x000D0000)
///@}
///
@@ -375,6 +377,7 @@ typedef struct {
#define EFI_P_PC_ENABLE 0x00000004
#define EFI_P_PC_RECONFIG 0x00000005
#define EFI_P_PC_DETECTED 0x00000006
+#define EFI_P_PC_REMOVED 0x00000007
///@}
//
@@ -464,8 +467,9 @@ typedef struct {
/// Peripheral Class Keyboard Subclass Error Code definitions.
///
///@{
-#define EFI_P_KEYBOARD_EC_LOCKED (EFI_SUBCLASS_SPECIFIC | 0x00000000)
-#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_LOCKED (EFI_SUBCLASS_SPECIFIC | 0x00000000)
+#define EFI_P_KEYBOARD_EC_STUCK_KEY (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_P_KEYBOARD_EC_BUFFER_FULL (EFI_SUBCLASS_SPECIFIC | 0x00000002)
///@}
///
@@ -762,6 +766,7 @@ typedef struct {
#define EFI_SW_PEI_PC_RECOVERY_AUTO (EFI_SUBCLASS_SPECIFIC | 0x00000004)
#define EFI_SW_PEI_PC_S3_BOOT_SCRIPT (EFI_SUBCLASS_SPECIFIC | 0x00000005)
#define EFI_SW_PEI_PC_OS_WAKE (EFI_SUBCLASS_SPECIFIC | 0x00000006)
+#define EFI_SW_PEI_PC_S3_STARTED (EFI_SUBCLASS_SPECIFIC | 0x00000007)
///@}
///
@@ -784,7 +789,11 @@ typedef struct {
#define EFI_SW_DXE_BS_PC_LEGACY_BOOT_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000002)
#define EFI_SW_DXE_BS_PC_EXIT_BOOT_SERVICES_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000003)
#define EFI_SW_DXE_BS_PC_VIRTUAL_ADDRESS_CHANGE_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000004)
+#define EFI_SW_DXE_BS_PC_VARIABLE_SERVICES_INIT (EFI_SUBCLASS_SPECIFIC | 0x00000005)
+#define EFI_SW_DXE_BS_PC_VARIABLE_RECLAIM (EFI_SUBCLASS_SPECIFIC | 0x00000006)
#define EFI_SW_DXE_BS_PC_ATTEMPT_BOOT_ORDER_EVENT (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_DXE_BS_PC_CONFIG_RESET (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_DXE_BS_PC_CSM_INIT (EFI_SUBCLASS_SPECIFIC | 0x00000009)
///@}
//
@@ -974,6 +983,8 @@ typedef struct {
#define EFI_SW_EC_PWD_CLR_REQUEST 0x0000000F
#define EFI_SW_EC_PWD_CLEARED 0x00000010
#define EFI_SW_EC_EVENT_LOG_FULL 0x00000011
+#define EFI_SW_EC_WRITE_PROTECTED 0x00000012
+#define EFI_SW_EC_FV_CORRUPTED 0x00000013
///@}
//
@@ -1005,6 +1016,8 @@ typedef struct {
#define EFI_SW_PEI_EC_S3_RESUME_FAILED (EFI_SUBCLASS_SPECIFIC | 0x00000005)
#define EFI_SW_PEI_EC_RECOVERY_PPI_NOT_FOUND (EFI_SUBCLASS_SPECIFIC | 0x00000006)
#define EFI_SW_PEI_EC_RECOVERY_FAILED (EFI_SUBCLASS_SPECIFIC | 0x00000007)
+#define EFI_SW_PEI_EC_S3_RESUME_ERROR (EFI_SUBCLASS_SPECIFIC | 0x00000008)
+#define EFI_SW_PEI_EC_INVALID_CAPSULE (EFI_SUBCLASS_SPECIFIC | 0x00000009)
///@}
///
--
2.24.1.windows.2
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 2/5] MdePkg: Updates to PI 1.7 Revision numbers for
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 1/5] MdePkg: New Status Codes Oleksiy Yakovlev
@ 2020-05-11 20:24 ` Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL Oleksiy Yakovlev
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Oleksiy Yakovlev @ 2020-05-11 20:24 UTC (permalink / raw)
To: devel; +Cc: liming.gao, michael.d.kinney, Felixp, oleksiyy, robert
From: Robert Phelps <robert@ami.com>
Revision number defines and MACROs were incorrect for the current
version of the Specification (PI 1.7 Mantis 1892)
Signed-off-by: Robert Phelps <robert@ami.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdePkg/Include/Pi/PiDxeCis.h | 4 ++--
MdePkg/Include/Pi/PiPeiCis.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
index e44744654f..1682211d92 100644
--- a/MdePkg/Include/Pi/PiDxeCis.h
+++ b/MdePkg/Include/Pi/PiDxeCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
- PI Version 1.6
+ PI Version 1.7
**/
@@ -690,7 +690,7 @@ EFI_STATUS
//
#define DXE_SERVICES_SIGNATURE 0x565245535f455844ULL
#define DXE_SPECIFICATION_MAJOR_REVISION 1
-#define DXE_SPECIFICATION_MINOR_REVISION 60
+#define DXE_SPECIFICATION_MINOR_REVISION 70
#define DXE_SERVICES_REVISION ((DXE_SPECIFICATION_MAJOR_REVISION<<16) | (DXE_SPECIFICATION_MINOR_REVISION))
typedef struct {
diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
index d9d4ed7d41..ebfe598172 100644
--- a/MdePkg/Include/Pi/PiPeiCis.h
+++ b/MdePkg/Include/Pi/PiPeiCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
- PI Version 1.6.
+ PI Version 1.7.
**/
@@ -850,7 +850,7 @@ EFI_STATUS
// PEI Specification Revision information
//
#define PEI_SPECIFICATION_MAJOR_REVISION 1
-#define PEI_SPECIFICATION_MINOR_REVISION 60
+#define PEI_SPECIFICATION_MINOR_REVISION 70
///
/// Specification inconsistency here:
/// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as 0x5652455320494550. But
--
2.24.1.windows.2
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 1/5] MdePkg: New Status Codes Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 2/5] MdePkg: Updates to PI 1.7 Revision numbers for Oleksiy Yakovlev
@ 2020-05-11 20:24 ` Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 4/5] MdePkg: Added header file for Delayed Dispatch PPI Oleksiy Yakovlev
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Oleksiy Yakovlev @ 2020-05-11 20:24 UTC (permalink / raw)
To: devel; +Cc: liming.gao, michael.d.kinney, Felixp, oleksiyy, robert
From: Robert Phelps <robert@ami.com>
Created a new header to support the new EFI_MM_COMMUNICATION2_PROTOCOL
Protocol as defined in the PI 1.7a Specification
(PI 1.7a Mantis 1993)
Signed-off-by: Robert Phelps <robert@ami.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdePkg/Include/Protocol/MmCommunication2.h | 72 ++++++++++++++++++++++
MdePkg/MdePkg.dec | 7 +++
2 files changed, 79 insertions(+)
create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
diff --git a/MdePkg/Include/Protocol/MmCommunication2.h b/MdePkg/Include/Protocol/MmCommunication2.h
new file mode 100644
index 0000000000..2d1f44f309
--- /dev/null
+++ b/MdePkg/Include/Protocol/MmCommunication2.h
@@ -0,0 +1,72 @@
+/** @file
+ EFI MM Communication Protocol 2 as defined in the PI 1.7 errata A specification.
+
+ Provides a runtime service for communicating between DXE drivers and a registered MMI handler
+
+Copyright (c) 2020, American Megatrends International LLC. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+#ifndef _MM_COMMUNICATION2_H_
+#define _MM_COMMUNICATION2_H_
+
+///
+/// Global ID for EFI_MM_COMUNICATION@_PROTOCOL_GUID
+///
+#define EFI_MM_COMMUNICATION2_PROTOCOL_GUID \
+ { 0x378daedc, 0xf06b, 0x4446, { 0x83, 0x14, 0x40, 0xab, 0x93, 0x3c, 0x87, 0xa3 }}
+
+
+///
+/// The forward declaration for EFI_MM_COMMUNICATION2_PROTOCOL_GUID
+///
+typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL EFI_MM_COMMUNICATION2_PROTOCOL;
+
+
+/**
+ Communicates with a registered handler.
+
+ Usage is identical to EFI_MM_COMMUNICATION_PROTOCOL.Communicate() except for the notes below:
+ - Instead of passing just the physical address via the CommBuffer parameter, the caller must pass both the physical and the virtual addresses of the communication buffer.
+ - If no virtual remapping has taken place, the physical address will be equal to the virtual address, and so the caller is required to pass the same value for both parameters.
+
+ @param This The EFI_MM_COMMUNICATION2_PROTOCOL instance.
+ @param CommBufferPhysical Physical address of the buffer to convey into MMRAM.
+ @param CommBufferVirtual Virtual address of the buffer to convey into MMRAM.
+ @param CommSize The size of the data buffer being passed in. On exit, the
+ size of data being returned. Zero if the handler does not
+ wish to reply with any data. This parameter is optional and may be NULL.
+
+
+ @retval EFI_SUCCESS The message was successfully posted.
+ @retval EFI_INVALID_PARAMETER The CommBuffer** parameters do not refer to the same location in memory.
+ @retval EFI_BAD_BUFFER_SIZE The buffer is too large for the MM implementation.
+ If this error is returned, the MessageLength field
+ in the CommBuffer header or the integer pointed by
+ CommSize, are updated to reflect the maximum payload
+ size the implementation can accommodate.
+ @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter or CommSize parameter,
+ if not omitted, are in address range that cannot be
+ accessed by the MM environment.
+**/
+
+typedef
+EFI_STATUS
+(EFIAPI *EFI_MM_COMMUNICATE2)(
+IN CONST EFI_MM_COMMUNICATION2_PROTOCOL *This,
+IN OUT VOID *CommBufferPhysical,
+IN OUT VOID *CommBufferVirtual,
+IN OUT UINTN *CommSize OPTIONAL
+);
+
+
+/// This protocol provides a means of communicating between drivers outside
+/// of MM and MMI handlers inside of MM, in a way that hides the implementation
+/// details regarding whether traditional or standalone MM is being used.
+
+typedef struct _EFI_MM_COMMUNICATION2_PROTOCOL {
+EFI_MM_COMMUNICATE2 Communicate;
+} EFI_MM_COMMUNICATION2_PROTOCOL;
+
+
+#endif
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 0b9c4bc40a..2591b8e135 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -1280,6 +1280,13 @@
## Include/Protocol/SpiSmmNorFlash.h
gEfiSpiSmmNorFlashProtocolGuid = { 0xaab18f19, 0xfe14, 0x4666, { 0x86, 0x04, 0x87, 0xff, 0x6d, 0x66, 0x2c, 0x9a }}
+ #
+ # Protocols defined in PI 1.7
+ #
+
+ ## Include/Protocol/MmComunication2.h
+ gEfiMmCommunication2ProtocolGuid = { 0x378daedc, 0xf06b, 0x4446, { 0x83, 0x14, 0x40, 0xab, 0x93, 0x3c, 0x87, 0xa3 }}
+
#
# Protocols defined in UEFI2.1/UEFI2.0/EFI1.1
#
--
2.24.1.windows.2
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 4/5] MdePkg: Added header file for Delayed Dispatch PPI
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
` (2 preceding siblings ...)
2020-05-11 20:24 ` [PATCH v2 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL Oleksiy Yakovlev
@ 2020-05-11 20:24 ` Oleksiy Yakovlev
2020-05-11 20:24 ` [PATCH v2 5/5] MdePkg: Update structures for MpServices Protocol Oleksiy Yakovlev
2020-05-13 16:35 ` [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Liming Gao
5 siblings, 0 replies; 10+ messages in thread
From: Oleksiy Yakovlev @ 2020-05-11 20:24 UTC (permalink / raw)
To: devel; +Cc: liming.gao, michael.d.kinney, Felixp, oleksiyy, robert
From: Robert Phelps <robert@ami.com>
Created new header file for the new EFI_DELAYED_DISPATCH_PPI PPI
(PI 1.7 Mantis 1891)
Signed-off-by: Robert Phelps <robert@ami.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdePkg/Include/Ppi/DelayedDispatch.h | 85 ++++++++++++++++++++++++++++
MdePkg/MdePkg.dec | 3 +
2 files changed, 88 insertions(+)
create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h
diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h b/MdePkg/Include/Ppi/DelayedDispatch.h
new file mode 100644
index 0000000000..195c5a36a4
--- /dev/null
+++ b/MdePkg/Include/Ppi/DelayedDispatch.h
@@ -0,0 +1,85 @@
+/** @file
+ EFI Delayed Dispatch PPI as defined in the PI 1.7 Specification
+
+ Provide timed event service in PEI
+
+ Copyright (c) 2020, American Megatrends International LLC. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef __DELAYED_DISPATCH_PPI_H__
+#define __DELAYED_DISPATCH_PPI_H__
+
+///
+/// Global ID for EFI_DELAYED_DISPATCH_PPI_GUID
+///
+#define EFI_DELAYED_DISPATCH_PPI_GUID \
+ { \
+ 0x869c711d, 0x649c, 0x44fe, { 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11, 0xc3, 0xe6} } \
+ }
+
+
+/**
+ Delayed Dispatch function. This routine is called sometime after the required
+ delay. Upon return, if NewDelay is 0, the function is unregistered. If NewDelay
+ is not zero, this routine will be called again after the new delay period.
+
+ @param[in,out] Context Pointer to Context. Can be updated by routine.
+ @param[out] NewDelay The new delay in us. Leave at 0 to unregister callback.
+
+**/
+
+typedef
+VOID
+(EFIAPI *EFI_DELAYED_DISPATCH_FUNCTION) (
+ IN OUT UINT64 *Context,
+ OUT UINT32 *NewDelay
+ );
+
+
+///
+/// The forward declaration for EFI_DELAYED_DISPATCH_PPI
+///
+
+typedef struct _EFI_DELAYED_DISPATCH_PPI EFI_DELAYED_DISPATCH_PPI;
+
+
+/**
+Register a callback to be called after a minimum delay has occurred.
+
+This service is the single member function of the EFI_DELAYED_DISPATCH_PPI
+
+ @param This Pointer to the EFI_DELAYED_DISPATCH_PPI instance
+ @param Function Function to call back
+ @param Context Context data
+ @param Delay Delay interval
+
+ @retval EFI_SUCCESS Function successfully loaded
+ @retval EFI_INVALID_PARAMETER One of the Arguments is not supported
+ @retval EFI_OUT_OF_RESOURCES No more entries
+
+**/
+typedef
+EFI_STATUS
+(EFIAPI *EFI_DELAYED_DISPATCH_REGISTER)(
+ IN EFI_DELAYED_DISPATCH_PPI *This,
+ IN EFI_DELAYED_DISPATCH_FUNCTION Function,
+ IN UINT64 Context,
+ OUT UINT32 Delay
+ );
+
+
+///
+/// This PPI is a pointer to the Delayed Dispatch Service.
+/// This service will be published by the Pei Foundation. The PEI Foundation
+/// will use this service to relaunch a known function that requests a delayed
+/// execution.
+///
+struct _EFI_DELAYED_DISPATCH_PPI {
+ EFI_DELAYED_DISPATCH_REGISTER Register;
+};
+
+
+extern EFI_GUID gEfiPeiDelayedDispatchPpiGuid;
+
+#endif
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 2591b8e135..4c05a46a3c 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -945,6 +945,9 @@
## Include/Ppi/PeiCoreFvLocation.h
gEfiPeiCoreFvLocationPpiGuid = { 0x52888eae, 0x5b10, 0x47d0, { 0xa8, 0x7f, 0xb8, 0x22, 0xab, 0xa0, 0xca, 0xf4 }}
+ ## Include/Ppi/DelayedDispatch.h
+ gEfiPeiDelayedDispatchPpiGuid = { 0x869c711d, 0x649c, 0x44fe, { 0x8b, 0x9e, 0x2c, 0xbb, 0x29, 0x11, 0xc3, 0xe6 }}
+
[Protocols]
## Include/Protocol/Pcd.h
gPcdProtocolGuid = { 0x11B34006, 0xD85B, 0x4D0A, { 0xA2, 0x90, 0xD5, 0xA5, 0x71, 0x31, 0x0E, 0xF7 }}
--
2.24.1.windows.2
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 5/5] MdePkg: Update structures for MpServices Protocol
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
` (3 preceding siblings ...)
2020-05-11 20:24 ` [PATCH v2 4/5] MdePkg: Added header file for Delayed Dispatch PPI Oleksiy Yakovlev
@ 2020-05-11 20:24 ` Oleksiy Yakovlev
2020-05-13 16:35 ` [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Liming Gao
5 siblings, 0 replies; 10+ messages in thread
From: Oleksiy Yakovlev @ 2020-05-11 20:24 UTC (permalink / raw)
To: devel; +Cc: liming.gao, michael.d.kinney, Felixp, oleksiyy, robert
From: Robert Phelps <robert@ami.com>
Added EXTENDED_PROCESSOR_INFORMATION structure and supporting
structures and definitions. The intent is to support updated
topology layout for CPUs. (PI 1.7a Mantis 2071)
Signed-off-by: Robert Phelps <robert@ami.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
---
MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/MdePkg/Include/Protocol/MpService.h b/MdePkg/Include/Protocol/MpService.h
index 10e2405daf..9445c5567f 100644
--- a/MdePkg/Include/Protocol/MpService.h
+++ b/MdePkg/Include/Protocol/MpService.h
@@ -47,6 +47,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
0x3fdda605, 0xa76e, 0x4f46, {0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08} \
}
+///
+/// Value used in the NumberProcessors parameter of the GetProcessorInfo function
+///
+#define CPU_V2_EXTENDED_TOPOLOGY BIT24
+
///
/// Forward declaration for the EFI_MP_SERVICES_PROTOCOL.
///
@@ -96,6 +101,47 @@ typedef struct {
UINT32 Thread;
} EFI_CPU_PHYSICAL_LOCATION;
+///
+/// Structure that defines the 6-level physical location of the processor
+///
+typedef struct {
+///
+/// Package Zero-based physical package number that identifies the cartridge of the processor.
+///
+UINT32 Package;
+///
+/// Module Zero-based physical module number within package of the processor.
+///
+UINT32 Module;
+///
+/// Tile Zero-based physical tile number within module of the processor.
+///
+UINT32 Tile;
+///
+/// Die Zero-based physical die number within tile of the processor.
+///
+UINT32 Die;
+///
+/// Core Zero-based physical core number within die of the processor.
+///
+UINT32 Core;
+///
+/// Thread Zero-based logical thread number within core of the processor.
+///
+UINT32 Thread;
+} EFI_CPU_PHYSICAL_LOCATION2;
+
+
+typedef union {
+ /// The 6-level physical location of the processor, including the
+ /// physical package number that identifies the cartridge, the physical
+ /// module number within package, the physical tile number within the module,
+ /// the physical die number within the tile, the physical core number within
+ /// package, and logical thread number within core.
+ EFI_CPU_PHYSICAL_LOCATION2 Location2;
+} EXTENDED_PROCESSOR_INFORMATION;
+
+
///
/// Structure that describes information about a logical CPU.
///
@@ -132,6 +178,10 @@ typedef struct {
/// logical thread number within core.
///
EFI_CPU_PHYSICAL_LOCATION Location;
+ ///
+ /// The extended information of the processor. This field is filled only when
+ /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber.
+ EXTENDED_PROCESSOR_INFORMATION ExtendedInformation;
} EFI_PROCESSOR_INFORMATION;
/**
--
2.24.1.windows.2
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
2020-05-11 20:24 [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
` (4 preceding siblings ...)
2020-05-11 20:24 ` [PATCH v2 5/5] MdePkg: Update structures for MpServices Protocol Oleksiy Yakovlev
@ 2020-05-13 16:35 ` Liming Gao
2020-05-14 16:35 ` robert
5 siblings, 1 reply; 10+ messages in thread
From: Liming Gao @ 2020-05-13 16:35 UTC (permalink / raw)
To: devel@edk2.groups.io, oleksiyy@ami.com
Cc: Kinney, Michael D, Felixp@ami.com, robert@ami.com
Reviewed-by: Liming Gao <liming.gao@intel.com> for the full patch set.
Besides, 3/5 patch has been merged into edk2 by Ard patch set.
Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy Yakovlev
> Sent: Tuesday, May 12, 2020 4:24 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
>
> From: Robert Phelps <robert@ami.com>
>
> The following patches add and update the current structures and
> definitions that were introduced by the PI 1.7 and PI 1.7a
> specifications
>
> Signed-off-by: Robert Phelps <robert@ami.com>
>
> Robert Phelps (5):
> MdePkg: New Status Codes
> MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
> MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
> MdePkg: Added header file for Delayed Dispatch PPI
> MdePkg: Updates to structures in the MP Services Protocol
>
> MdePkg/Include/Pi/PiDxeCis.h | 4 +-
> MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> MdePkg/Include/Pi/PiStatusCode.h | 17 ++++-
> MdePkg/Include/Ppi/DelayedDispatch.h | 85 ++++++++++++++++++++++
> MdePkg/Include/Protocol/MmCommunication2.h | 72 ++++++++++++++++++
> MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++
> MdePkg/MdePkg.dec | 10 +++
> 7 files changed, 236 insertions(+), 6 deletions(-)
> create mode 100644 MdePkg/Include/Ppi/DelayedDispatch.h
> create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
>
> --
> 2.24.1.windows.2
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
2020-05-13 16:35 ` [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Liming Gao
@ 2020-05-14 16:35 ` robert
2020-05-14 16:39 ` Liming Gao
0 siblings, 1 reply; 10+ messages in thread
From: robert @ 2020-05-14 16:35 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io, Oleksiy Yakovlev
Cc: Kinney, Michael D, Felix Polyudov
I apologize, but I am new to this. At this point, I have done the patches and the Patch updates and I have created the Pull Request. What is my next step, or is that all I need to do?
Rob Phelps
-----Original Message-----
From: Gao, Liming <liming.gao@intel.com>
Sent: Wednesday, May 13, 2020 12:35 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev <Oleksiyy@ami.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov <Felixp@ami.com>; Robert Phelps <Robert@ami.com>
Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
Reviewed-by: Liming Gao <liming.gao@intel.com> for the full patch set.
Besides, 3/5 patch has been merged into edk2 by Ard patch set.
Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Tuesday, May 12, 2020 4:24 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> robert@ami.com
> Subject: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI
> 1.7 and PI 1.7a
>
> From: Robert Phelps <robert@ami.com>
>
> The following patches add and update the current structures and
> definitions that were introduced by the PI 1.7 and PI 1.7a
> specifications
>
> Signed-off-by: Robert Phelps <robert@ami.com>
>
> Robert Phelps (5):
> MdePkg: New Status Codes
> MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
> MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
> MdePkg: Added header file for Delayed Dispatch PPI
> MdePkg: Updates to structures in the MP Services Protocol
>
> MdePkg/Include/Pi/PiDxeCis.h | 4 +-
> MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> MdePkg/Include/Pi/PiStatusCode.h | 17 ++++-
> MdePkg/Include/Ppi/DelayedDispatch.h | 85 ++++++++++++++++++++++
> MdePkg/Include/Protocol/MmCommunication2.h | 72 ++++++++++++++++++
> MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++
> MdePkg/MdePkg.dec | 10 +++
> 7 files changed, 236 insertions(+), 6 deletions(-) create mode
> 100644 MdePkg/Include/Ppi/DelayedDispatch.h
> create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
>
> --
> 2.24.1.windows.2
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>
>
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
2020-05-14 16:35 ` robert
@ 2020-05-14 16:39 ` Liming Gao
2020-05-14 16:51 ` Robert Phelps
0 siblings, 1 reply; 10+ messages in thread
From: Liming Gao @ 2020-05-14 16:39 UTC (permalink / raw)
To: Robert Phelps, devel@edk2.groups.io, Oleksiy Yakovlev
Cc: Kinney, Michael D, Felix Polyudov
You don't need do more. I will help merge this patch set.
> -----Original Message-----
> From: Robert Phelps <Robert@ami.com>
> Sent: Friday, May 15, 2020 12:36 AM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Oleksiy Yakovlev <Oleksiyy@ami.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov <Felixp@ami.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
>
> I apologize, but I am new to this. At this point, I have done the patches and the Patch updates and I have created the Pull Request.
> What is my next step, or is that all I need to do?
>
> Rob Phelps
>
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, May 13, 2020 12:35 PM
> To: devel@edk2.groups.io; Oleksiy Yakovlev <Oleksiyy@ami.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov <Felixp@ami.com>; Robert Phelps <Robert@ami.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
>
> Reviewed-by: Liming Gao <liming.gao@intel.com> for the full patch set.
>
> Besides, 3/5 patch has been merged into edk2 by Ard patch set.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> > Yakovlev
> > Sent: Tuesday, May 12, 2020 4:24 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> > robert@ami.com
> > Subject: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI
> > 1.7 and PI 1.7a
> >
> > From: Robert Phelps <robert@ami.com>
> >
> > The following patches add and update the current structures and
> > definitions that were introduced by the PI 1.7 and PI 1.7a
> > specifications
> >
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (5):
> > MdePkg: New Status Codes
> > MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
> > MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
> > MdePkg: Added header file for Delayed Dispatch PPI
> > MdePkg: Updates to structures in the MP Services Protocol
> >
> > MdePkg/Include/Pi/PiDxeCis.h | 4 +-
> > MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> > MdePkg/Include/Pi/PiStatusCode.h | 17 ++++-
> > MdePkg/Include/Ppi/DelayedDispatch.h | 85 ++++++++++++++++++++++
> > MdePkg/Include/Protocol/MmCommunication2.h | 72 ++++++++++++++++++
> > MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++
> > MdePkg/MdePkg.dec | 10 +++
> > 7 files changed, 236 insertions(+), 6 deletions(-) create mode
> > 100644 MdePkg/Include/Ppi/DelayedDispatch.h
> > create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
> >
> > --
> > 2.24.1.windows.2
> >
> >
> > Please consider the environment before printing this email.
> >
> > The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended to be read only by the individual or entity to whom it is
> > addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution
> of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600,
> and then delete or destroy all copies of the transmission.
> >
> >
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
2020-05-14 16:39 ` Liming Gao
@ 2020-05-14 16:51 ` Robert Phelps
0 siblings, 0 replies; 10+ messages in thread
From: Robert Phelps @ 2020-05-14 16:51 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io, Oleksiy Yakovlev
Cc: Kinney, Michael D, Felix Polyudov
Thank you
-----Original Message-----
From: Gao, Liming <liming.gao@intel.com>
Sent: Thursday, May 14, 2020 12:39 PM
To: Robert Phelps <Robert@ami.com>; devel@edk2.groups.io; Oleksiy Yakovlev <Oleksiyy@ami.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov <Felixp@ami.com>
Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a
You don't need do more. I will help merge this patch set.
> -----Original Message-----
> From: Robert Phelps <Robert@ami.com>
> Sent: Friday, May 15, 2020 12:36 AM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Oleksiy
> Yakovlev <Oleksiyy@ami.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov
> <Felixp@ami.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in
> PI 1.7 and PI 1.7a
>
> I apologize, but I am new to this. At this point, I have done the patches and the Patch updates and I have created the Pull Request.
> What is my next step, or is that all I need to do?
>
> Rob Phelps
>
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, May 13, 2020 12:35 PM
> To: devel@edk2.groups.io; Oleksiy Yakovlev <Oleksiyy@ami.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Felix Polyudov
> <Felixp@ami.com>; Robert Phelps <Robert@ami.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in
> PI 1.7 and PI 1.7a
>
> Reviewed-by: Liming Gao <liming.gao@intel.com> for the full patch set.
>
> Besides, 3/5 patch has been merged into edk2 by Ard patch set.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Oleksiy Yakovlev
> > Sent: Tuesday, May 12, 2020 4:24 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com;
> > robert@ami.com
> > Subject: [edk2-devel] [PATCH v2 0/5] Add Definitions introduced in
> > PI
> > 1.7 and PI 1.7a
> >
> > From: Robert Phelps <robert@ami.com>
> >
> > The following patches add and update the current structures and
> > definitions that were introduced by the PI 1.7 and PI 1.7a
> > specifications
> >
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (5):
> > MdePkg: New Status Codes
> > MdePkg: Updates to PI 1.7 Revision numbers for PEI and DXE
> > MdePkg: EFI_MM_COMUNICATION2_PROTOCOL
> > MdePkg: Added header file for Delayed Dispatch PPI
> > MdePkg: Updates to structures in the MP Services Protocol
> >
> > MdePkg/Include/Pi/PiDxeCis.h | 4 +-
> > MdePkg/Include/Pi/PiPeiCis.h | 4 +-
> > MdePkg/Include/Pi/PiStatusCode.h | 17 ++++-
> > MdePkg/Include/Ppi/DelayedDispatch.h | 85 ++++++++++++++++++++++
> > MdePkg/Include/Protocol/MmCommunication2.h | 72 ++++++++++++++++++
> > MdePkg/Include/Protocol/MpService.h | 50 +++++++++++++
> > MdePkg/MdePkg.dec | 10 +++
> > 7 files changed, 236 insertions(+), 6 deletions(-) create mode
> > 100644 MdePkg/Include/Ppi/DelayedDispatch.h
> > create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
> >
> > --
> > 2.24.1.windows.2
> >
> >
> > Please consider the environment before printing this email.
> >
> > The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended to be read only by the individual or entity to whom it is
> > addressed or by their designee. If the reader of this message is not
> > the intended recipient, you are on notice that any distribution
> of this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> >
> >
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply [flat|nested] 10+ messages in thread