Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking drivers

["Leif Lindholm" <leif@nuviainc.com>]

On Mon, May 11, 2020 at 17:50:54 +0200, Ard Biesheuvel wrote:
> On 5/10/20 1:15 PM, Samer El-Haj-Mahmoud wrote:
> > This series updates the ASIX USB networking drivers:
> > 
> >   - Create new Silicon/ASIX/ package
> >   - Move existing Ax88772 and Ax88772b drivers from OptionRomPkg
> >     to the newly created AsixPkg
> >   - Add new ASIX drivers Ax88179 and Ax88772c
> > 
> > Code pushed to https://github.com/samerhaj/edk2-platforms/tree/asix_usb_nic_drivers_v2
> > 
> > version 1: https://edk2.groups.io/g/devel/message/58771
> > version 2 changes:
> >   - Create new ASIX Package to host existing and new ASIX drivers[Ray]
> > 
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > 
> > Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> > 
> > Samer El-Haj-Mahmoud (4):
> >    Silicon/AsixPkg: Create AsixPkg
> >    Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg
> >    Silicon/AsixPkg: Add ASIX Ax88179 driver
> >    Silicon/AsixPkg: Add ASIX Ax88772c driver
> > 
> 
> I happened to have one of each of these dongles in my drawer, so I managed
> to test them both.
> 
> Both work fine, although the 88179 one was rather slow.
> 
> In any case, the 10/100 one I tried is an Apple one (05ac:1402) which is
> also supported by the 88772b driver. The only other vid/pid pair which that
> old driver supports is also supported by the new one, so I think we can drop
> the old one altogether. The non-b 7720 driver is also supported by the new
> 10/100 driver, so we can drop the old 88772 as well, afaict.

If we can drop the old ones, I will be very happy.
I was just about to start providing some feedback on those (beyond
what you have) including bits like "drop the Hungarian notation".

Fixing those would be a fair amount of effort, and moving out of their
legacy home before that would set a bad example.

/
    Leif