From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.3576.1589282131456955176 for ; Tue, 12 May 2020 04:15:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=PBSu1uRK; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id y16so7684014wrs.3 for ; Tue, 12 May 2020 04:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f4me6/q1t8a/jqeo2be7RO1rinActgskdA+FZz13efU=; b=PBSu1uRKJLtJGn3509zQQc2TcBQ8cSzTgtDxDia3Ydp50sYpK/Q2Ag/j/fCBgOmc8D knhoSD5pRqdwie0vt9jnbid4KP47Fv2dGOCMMYr4BdxKKB5tn7UNsyaYVa0cg4IioQbd KmfZeftPnZcUhPveRjINGgMowhl5AX7lkGtQVoJWTWn2qmcwa+Y02Zi1mGr9ZCifj5kC UX8NO2WF5znUrzHO4UQruDV8/BD9REz7SdVsY9eDPyTSu+Pjvt330B89moUPntPWyQ4t PwzHoQ8UJISaQbr2Ro3rileJQUfgsdWtfPuyKQGFCQ6G0dQWDpWnYF3aCUKAQPyjQjAT h7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f4me6/q1t8a/jqeo2be7RO1rinActgskdA+FZz13efU=; b=HHTXicF01UEAd3OLaesBk/5pll16txFTR23wgCP7fxRmvma8blUH+KX5BIKCaRjZsp fBzdCw2RhSn96RyLBb+L0knKZr55Oc56uvTjktIVlg19IW+k3I/Zkiwd/dvy1cnVidjj iPnnJKjNp1cyL1jTv/fmlnzooQr4DjwpXNDIx8mSVF1CAvnnQ1Bws2sodgzo2CqRMkoz 2NBfrzzsRu0/+kRCvWNimvv/Dldy8BZrtQ51szozF+u86uign3fdqIeAWkNbbS3z/Rz3 hanPbache1+BHDoyCwYSW7ZeGEZv9XA+SJoDFfHnIRQ3Vd1ime/UWXCn/hRPHJhvpBUc xlNQ== X-Gm-Message-State: AGi0PuZHPFknpcx2PJbQVB3C08ltfsqxS1i3kykaZvi84I+6emU3VsT5 BY6vxzdSH60l6jn7YJfv5Vodgg== X-Google-Smtp-Source: APiQypLhIQFgZJo6WQPYEJtVQmnxyUPgJ0tuPPRUtgVIpW/ezB0ZCXpaHTFLy5zuOAVnV1amjexheA== X-Received: by 2002:adf:9567:: with SMTP id 94mr5153798wrs.167.1589282130031; Tue, 12 May 2020 04:15:30 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id b14sm19209911wmb.18.2020.05.12.04.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 04:15:29 -0700 (PDT) Date: Tue, 12 May 2020 12:15:27 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud , devel@edk2.groups.io, Ray Ni , Michael D Kinney Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking drivers Message-ID: <20200512111527.GC21486@vanye> References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com> <3ae3d8da-2f51-edce-4457-b1db79e501f5@arm.com> MIME-Version: 1.0 In-Reply-To: <3ae3d8da-2f51-edce-4457-b1db79e501f5@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 11, 2020 at 17:50:54 +0200, Ard Biesheuvel wrote: > On 5/10/20 1:15 PM, Samer El-Haj-Mahmoud wrote: > > This series updates the ASIX USB networking drivers: > > > > - Create new Silicon/ASIX/ package > > - Move existing Ax88772 and Ax88772b drivers from OptionRomPkg > > to the newly created AsixPkg > > - Add new ASIX drivers Ax88179 and Ax88772c > > > > Code pushed to https://github.com/samerhaj/edk2-platforms/tree/asix_usb_nic_drivers_v2 > > > > version 1: https://edk2.groups.io/g/devel/message/58771 > > version 2 changes: > > - Create new ASIX Package to host existing and new ASIX drivers[Ray] > > > > Cc: Ray Ni > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > > > Signed-off-by: Samer El-Haj-Mahmoud > > > > Samer El-Haj-Mahmoud (4): > > Silicon/AsixPkg: Create AsixPkg > > Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg > > Silicon/AsixPkg: Add ASIX Ax88179 driver > > Silicon/AsixPkg: Add ASIX Ax88772c driver > > > > I happened to have one of each of these dongles in my drawer, so I managed > to test them both. > > Both work fine, although the 88179 one was rather slow. > > In any case, the 10/100 one I tried is an Apple one (05ac:1402) which is > also supported by the 88772b driver. The only other vid/pid pair which that > old driver supports is also supported by the new one, so I think we can drop > the old one altogether. The non-b 7720 driver is also supported by the new > 10/100 driver, so we can drop the old 88772 as well, afaict. If we can drop the old ones, I will be very happy. I was just about to start providing some feedback on those (beyond what you have) including bits like "drop the Hungarian notation". Fixing those would be a fair amount of effort, and moving out of their legacy home before that would set a bad example. / Leif