From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.6906.1589294124760012699 for ; Tue, 12 May 2020 07:35:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=fAHCuM+/; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id f134so9850092wmf.1 for ; Tue, 12 May 2020 07:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x+R6Z9xoTNApWj5hcQroI90txjBeglMuJj92npv9Nvo=; b=fAHCuM+/9CXQJ9GtpahmxQD/vqPa82x06alVthWJsiF1/Hb90gxI+gHrNU+2qzYJhY lYaL3DRhUaz5eDzPfEgoz7Ah5WCe7nE7pQrSJHSsgVJHj+AvkToku2y8QzeWXNvv1a9D hFoy2nnZIEIEztXhrgB7ynJdes8aCgZ8jlywtKjv5AOF1sRnPN/J5r0ccCXVOgXoFnkj HHIS/a7cs4W0pRJVsqRbBrBmzG8lPohUMMIYprU5ohO0w6Bp2hPb9nGlLSr+Qnsh1WsD tt/V7mIigs6oHbE0QUXqoO4wx5gk2n4+ZAtrIzdoo4Dj5mFbx8AAkRvQCaIr5YAZ0/wu rp8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x+R6Z9xoTNApWj5hcQroI90txjBeglMuJj92npv9Nvo=; b=S3HVwH9XrCrpjZFCfIfaRLrDGriWcMo3srIbGG2kaIyVMT8GADNZ5D6joMnZ3AATcU 9hI0il0atqg1D4lvYm0JC1X83TrNHS5Kc69t38c7BtpUr6+j5U49vXq28yPmkZXRMwtR ePL2CNg6oPD4wQFuwFUQBZabbYmol6sH/uhQdcwG94yjCGZnYH3mwUpRBwsZYpTRTtrJ dYMQla3F1Y5Pq9SVEi84fgj5hPDdBLmc2IeynUK1HRJ+QYXItkG2xj7JSVPSKxJT7Mza d+/rsMrxvwE+Y9kEHcr/FoKSqQXMT8J6f9l/wIYOZgXk9t6SPHYdFpWmoCAx5j9ipKRg 1PkA== X-Gm-Message-State: AGi0PuYNdgPAjVlip+I91DaodXKs29ValtKxPOk34PjH8Yk5vvmSM2Gy 076W552Bdwr0DwTe7B8plLvDGA== X-Google-Smtp-Source: APiQypKem7NPvblBRQp7moVTj5MQy3ODXpELEVWSeu/ROKhDTHXe/lZebDB24Z/MLDeL3Zeq+zuDBA== X-Received: by 2002:a05:600c:295a:: with SMTP id n26mr41063993wmd.16.1589294123335; Tue, 12 May 2020 07:35:23 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h137sm40769318wme.0.2020.05.12.07.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 07:35:22 -0700 (PDT) Date: Tue, 12 May 2020 15:35:20 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, philmd@redhat.com, Pete Batard , Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Jeremy Linton Subject: Re: [PATCH edk2-platforms v2 0/7] Add Broadcom GENET driver for RPi4 Message-ID: <20200512143520.GI21486@vanye> References: <20200512075512.12645-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200512075512.12645-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 12, 2020 at 09:55:05 +0200, Ard Biesheuvel wrote: > This is a followup to Samer's v1 [0], and incorporates all the delta > changes posted for review over the past couple of days. This is a > roundup of all that work, and therefore supersedes it. > > It provides an implementation of the SimpleNetworkProtocol for the > Raspberry Pi4's GENET network controller, in a way that adheres to the > UEFI driver model. > > The original submission was provided by Jared, based on Jeremy's MAC > programming-only driver and the existing BSD driver for the GENET IP. > Cumulative changes and fixes as well as review feedback were provided > by all of the below. > > https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v2 > > Cc: Pete Batard > Cc: Jared McNeill > Cc: Andrei Warkentin > Cc: Samer El-Haj-Mahmoud > Cc: Jeremy Linton For 1-2,4,6-7/7: Reviewed-by: Leif Lindholm > Andrei Warkentin (1): > Platform/RaspberryPi4: Remove PlatformPcdLib > > Ard Biesheuvel (6): > Platform/RaspberryPi4: set DMA translation for BCM Genet driver > Silicon/Broadcom: Add BcmGenetPlatformDevice protocol > Silicon/Broadcom/BcmGenetDxe: Add GENET driver > Platform/RaspberryPi4: Clean up PCDs out of the GENET driver > Platform/RaspberryPi4: Register GENET platform device protocol > Platform/RaspberryPi4: remove ASIX 88772b driver > > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 2 + > Silicon/Broadcom/Drivers/Net/BcmNet.dec | 8 +- > Platform/RaspberryPi/RPi4/RPi4.dsc | 8 +- > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 - > .../RaspberryPi/AcpiTables/AcpiTables.inf | 2 +- > .../Drivers/ConfigDxe/ConfigDxe.inf | 29 +- > .../Library/PlatformPcdLib/PlatformPcdLib.inf | 43 - > .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 46 +- > .../Include/IndustryStandard/Bcm2711.h | 3 + > .../Drivers/Net/BcmGenetDxe/GenericPhy.h | 106 +++ > .../Drivers/Net/BcmGenetDxe/GenetUtil.h | 364 ++++++++ > .../Broadcom/Drivers/Net/Include/Net/Genet.h | 21 - > .../Include/Protocol/BcmGenetPlatformDevice.h | 24 + > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 108 ++- > .../Library/PlatformPcdLib/PlatformPcdLib.c | 45 - > .../Drivers/Net/BcmGenetDxe/ComponentName.c | 198 +++++ > .../Drivers/Net/BcmGenetDxe/DriverBinding.c | 408 +++++++++ > .../Drivers/Net/BcmGenetDxe/GenericPhy.c | 405 +++++++++ > .../Broadcom/Drivers/Net/BcmGenetDxe/Genet.c | 114 --- > .../Drivers/Net/BcmGenetDxe/GenetUtil.c | 816 +++++++++++++++++ > .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 834 ++++++++++++++++++ > Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- > 22 files changed, 3319 insertions(+), 268 deletions(-) > delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.h > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.h > delete mode 100644 Silicon/Broadcom/Drivers/Net/Include/Net/Genet.h > create mode 100644 Silicon/Broadcom/Drivers/Net/Include/Protocol/BcmGenetPlatformDevice.h > delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/ComponentName.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.c > delete mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c > > -- > 2.17.1 >