From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, philmd@redhat.com,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Pete Batard <pete@akeo.ie>, Jared McNeill <jmcneill@invisible.ca>,
Andrei Warkentin <awarkentin@vmware.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4
Date: Tue, 12 May 2020 18:41:17 +0200 [thread overview]
Message-ID: <20200512164125.28139-1-ard.biesheuvel@arm.com> (raw)
This is a followup to Samer's v1 [0], and incorporates all the delta
changes posted for review over the past couple of days. This is a
roundup of all that work, and therefore supersedes it.
It provides an implementation of the SimpleNetworkProtocol for the
Raspberry Pi4's GENET network controller, in a way that adheres to the
UEFI driver model.
The original submission was provided by Jared, based on Jeremy's MAC
programming-only driver and the existing BSD driver for the GENET IP.
Cumulative changes and fixes as well as review feedback were provided
by all of the below.
Changes since v2:
- replace 'master' include with per C file includes of the required
headers
- add comments describing the PHY registers to GenericPhy.h
- split off patch #5 from subsequent ConfigDxe change
- other minor style fixes suggested by Leif
- add Leif's ack where given
https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v2
https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v3
Cc: Pete Batard <pete@akeo.ie>
Cc: Jared McNeill <jmcneill@invisible.ca>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>
[0] https://edk2.groups.io/g/devel/message/58903
Andrei Warkentin (1):
Platform/RaspberryPi4: Remove PlatformPcdLib
Ard Biesheuvel (7):
Platform/RaspberryPi4: set DMA translation for BCM Genet driver
Silicon/Broadcom: Add BcmGenetPlatformDevice protocol
Silicon/Broadcom/BcmGenetDxe: Add GENET driver
Platform/RaspberryPi4: Clean up PCDs out of the GENET driver
Platform/RaspberryPi/ConfigDxe: preliminary cleanup
Platform/RaspberryPi4: Register GENET platform device protocol
Platform/RaspberryPi4: remove ASIX 88772b driver
Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 2 +
Silicon/Broadcom/Drivers/Net/BcmNet.dec | 8 +-
Platform/RaspberryPi/RPi4/RPi4.dsc | 8 +-
Platform/RaspberryPi/RPi4/RPi4.fdf | 1 -
.../RaspberryPi/AcpiTables/AcpiTables.inf | 2 +-
.../Drivers/ConfigDxe/ConfigDxe.inf | 29 +-
.../Library/PlatformPcdLib/PlatformPcdLib.inf | 43 -
.../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 46 +-
.../Include/IndustryStandard/Bcm2711.h | 3 +
.../Drivers/Net/BcmGenetDxe/BcmGenetDxe.h | 363 ++++++++
.../Drivers/Net/BcmGenetDxe/GenericPhy.h | 133 +++
.../Broadcom/Drivers/Net/Include/Net/Genet.h | 21 -
.../Include/Protocol/BcmGenetPlatformDevice.h | 24 +
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 108 ++-
.../Library/PlatformPcdLib/PlatformPcdLib.c | 45 -
.../Drivers/Net/BcmGenetDxe/ComponentName.c | 202 +++++
.../Drivers/Net/BcmGenetDxe/DriverBinding.c | 408 +++++++++
.../Drivers/Net/BcmGenetDxe/GenericPhy.c | 404 +++++++++
.../Broadcom/Drivers/Net/BcmGenetDxe/Genet.c | 114 ---
.../Drivers/Net/BcmGenetDxe/GenetUtil.c | 814 +++++++++++++++++
.../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 838 ++++++++++++++++++
Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
22 files changed, 3350 insertions(+), 268 deletions(-)
delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.h
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.h
delete mode 100644 Silicon/Broadcom/Drivers/Net/Include/Net/Genet.h
create mode 100644 Silicon/Broadcom/Drivers/Net/Include/Protocol/BcmGenetPlatformDevice.h
delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/ComponentName.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.c
delete mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.c
create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c
--
2.17.1
next reply other threads:[~2020-05-12 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 16:41 Ard Biesheuvel [this message]
2020-05-12 16:41 ` [PATCH edk2-platforms v3 1/8] Platform/RaspberryPi4: set DMA translation for BCM Genet driver Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 2/8] Silicon/Broadcom: Add BcmGenetPlatformDevice protocol Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 3/8] Silicon/Broadcom/BcmGenetDxe: Add GENET driver Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 4/8] Platform/RaspberryPi4: Clean up PCDs out of the " Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 5/8] Platform/RaspberryPi/ConfigDxe: preliminary cleanup Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 6/8] Platform/RaspberryPi4: Register GENET platform device protocol Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 7/8] Platform/RaspberryPi4: Remove PlatformPcdLib Ard Biesheuvel
2020-05-12 16:41 ` [PATCH edk2-platforms v3 8/8] Platform/RaspberryPi4: remove ASIX 88772b driver Ard Biesheuvel
2020-05-12 17:15 ` [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4 Leif Lindholm
2020-05-12 17:21 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512164125.28139-1-ard.biesheuvel@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox