From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.10634.1589303744288655986 for ; Tue, 12 May 2020 10:15:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=OltxsNGC; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id l18so16474163wrn.6 for ; Tue, 12 May 2020 10:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OTgcRWJjDId2jmDfQ0qiPa1e/v0aT+ov5/ancl3oVdg=; b=OltxsNGCR7WI9o/332xsSmAhvB7qXL30T5Lqv4q8hQbZYxSSeCAfdcVCAs9z5jweY1 leVsCxZii6piFx3h5O5e8KVr+avT4J6Y55xIlT6nqpZt0plLp+qaVTp7rF4fJI9yCJKE SPTHVtXHYWNaLkNqM53iI3u9ptAEsAvUTGzF2GzOiZ4X5wIdE1m6qYz2csIhWaNqpqZd 46Gux2dHk1vNqxtuZY4bEDjUHKa/pT9K9i9kUAw5DE7B2aVYCW4pmtfGZ4TN3G1fS1mF on7yd8UYcNlbwiSQoLtc3p8gwED7qGTLSjlCDymmivzY7XX3P9XYYWdtwEX+wQMes6QM vZRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OTgcRWJjDId2jmDfQ0qiPa1e/v0aT+ov5/ancl3oVdg=; b=IrdNe9Mnk3R3x39plpep+g7zLZXQbqBs+Vej8nrevfnejHHojJFkx+6BpvnebLdbw4 ORZZvEaDdfIodbf698TBhrCx+FuQrEXNzqXXnJt/pIkJVaUIFmZcrZKMxBhnKKW7tr7E Z0nSWtZ+x1DdLCJuXE0X88vYTNiCmDUSdjaEzvnf3CPuEeUYZZ0KJwfttjL/9thvAwjD pSHfpGaSVTf8CgPNYmcCfV/crZkHA+mxa0DErXnBKcrbEyUOpKhx3geGO7okNmJWeiBY cBon2OCjs7svC/8JqAjZJFSNDF6YiSEdQZLReBVeDE0HtjkyVqxGuMhxAa4mIDFbEySR D6zA== X-Gm-Message-State: AGi0PuZYvxrIHSYz6ONJGrn9v2ASz9QsyBF9FRG6uh4cxraNTr1a33Ll h/o9KNbxLtUZQgTTwxAeeL7HmuS/hSjIkko4u3zMC31Oh3JBl1Ug4G+acG084JEfdPjATdHjueg 6UnRyJOTGNwCX810ddxYIXPd9wi0GHt7wclM8E2YBrThn+V5oWhxp+afOihjIXknOjA== X-Google-Smtp-Source: APiQypIaT9CSC6QX0VvYoofczeK3CTYsn2HLnejz/OIhrqHqdsE10cKUaKpKsNk5a3C7Ky+TakgxhA== X-Received: by 2002:a5d:6702:: with SMTP id o2mr19641046wru.231.1589303742547; Tue, 12 May 2020 10:15:42 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id t71sm34098358wmt.31.2020.05.12.10.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 10:15:42 -0700 (PDT) Date: Tue, 12 May 2020 18:15:39 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, ard.biesheuvel@arm.com Cc: philmd@redhat.com, Pete Batard , Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Jeremy Linton Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4 Message-ID: <20200512171539.GM21486@vanye> References: <20200512164125.28139-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200512164125.28139-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 12, 2020 at 18:41:17 +0200, Ard Biesheuvel wrote: > This is a followup to Samer's v1 [0], and incorporates all the delta > changes posted for review over the past couple of days. This is a > roundup of all that work, and therefore supersedes it. > > It provides an implementation of the SimpleNetworkProtocol for the > Raspberry Pi4's GENET network controller, in a way that adheres to the > UEFI driver model. > > The original submission was provided by Jared, based on Jeremy's MAC > programming-only driver and the existing BSD driver for the GENET IP. > Cumulative changes and fixes as well as review feedback were provided > by all of the below. > > Changes since v2: > - replace 'master' include with per C file includes of the required > headers > - add comments describing the PHY registers to GenericPhy.h > - split off patch #5 from subsequent ConfigDxe change > - other minor style fixes suggested by Leif > - add Leif's ack where given Thanks! For remaining patches in set: Reviewed-by: Leif Lindholm > https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v2 > https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v3 > > Cc: Pete Batard > Cc: Jared McNeill > Cc: Andrei Warkentin > Cc: Samer El-Haj-Mahmoud > Cc: Jeremy Linton > > [0] https://edk2.groups.io/g/devel/message/58903 > > Andrei Warkentin (1): > Platform/RaspberryPi4: Remove PlatformPcdLib > > Ard Biesheuvel (7): > Platform/RaspberryPi4: set DMA translation for BCM Genet driver > Silicon/Broadcom: Add BcmGenetPlatformDevice protocol > Silicon/Broadcom/BcmGenetDxe: Add GENET driver > Platform/RaspberryPi4: Clean up PCDs out of the GENET driver > Platform/RaspberryPi/ConfigDxe: preliminary cleanup > Platform/RaspberryPi4: Register GENET platform device protocol > Platform/RaspberryPi4: remove ASIX 88772b driver > > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 2 + > Silicon/Broadcom/Drivers/Net/BcmNet.dec | 8 +- > Platform/RaspberryPi/RPi4/RPi4.dsc | 8 +- > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 - > .../RaspberryPi/AcpiTables/AcpiTables.inf | 2 +- > .../Drivers/ConfigDxe/ConfigDxe.inf | 29 +- > .../Library/PlatformPcdLib/PlatformPcdLib.inf | 43 - > .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 46 +- > .../Include/IndustryStandard/Bcm2711.h | 3 + > .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.h | 363 ++++++++ > .../Drivers/Net/BcmGenetDxe/GenericPhy.h | 133 +++ > .../Broadcom/Drivers/Net/Include/Net/Genet.h | 21 - > .../Include/Protocol/BcmGenetPlatformDevice.h | 24 + > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 108 ++- > .../Library/PlatformPcdLib/PlatformPcdLib.c | 45 - > .../Drivers/Net/BcmGenetDxe/ComponentName.c | 202 +++++ > .../Drivers/Net/BcmGenetDxe/DriverBinding.c | 408 +++++++++ > .../Drivers/Net/BcmGenetDxe/GenericPhy.c | 404 +++++++++ > .../Broadcom/Drivers/Net/BcmGenetDxe/Genet.c | 114 --- > .../Drivers/Net/BcmGenetDxe/GenetUtil.c | 814 +++++++++++++++++ > .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 838 ++++++++++++++++++ > Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- > 22 files changed, 3350 insertions(+), 268 deletions(-) > delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.h > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.h > delete mode 100644 Silicon/Broadcom/Drivers/Net/Include/Net/Genet.h > create mode 100644 Silicon/Broadcom/Drivers/Net/Include/Protocol/BcmGenetPlatformDevice.h > delete mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/ComponentName.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/DriverBinding.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenericPhy.c > delete mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/GenetUtil.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/SimpleNetwork.c > > -- > 2.17.1 > > > >