public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ard.biesheuvel@arm.com>,
	<leif@nuviainc.com>, <thomas.abraham@arm.com>,
	<Matteo.Carlini@arm.com>, <Laura.Moretta@arm.com>, <nd@arm.com>
Subject: [PATCH edk2-platforms v1 0/1] Use BaseMemoryLibMmio with NorFlashDxe
Date: Thu, 14 May 2020 09:46:05 +0100	[thread overview]
Message-ID: <20200514084607.25956-1-sami.mujawar@arm.com> (raw)

NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.

The AlignedCopyMem() in NorFlashDxe was used to
copy the flash data which prevented unaligned
access to device memory. However, the compiler
could optimize the code to generate pre/post
indexed or LDP operations. This is a problem
for guest/virtual firmware as the hypervisor
code cannot get the syndrome information for
the trapped accesses.

With the introduction of virtual firmware
support for Kvmtool guests, it is necessary
to link NorFlashDxe with BaseMemoryLibMmio
(as it enforces aligned MMIO accesses).

This patch series updates the workspaces
for platforms that use the NorFlashDxe to
link with BaseMemoryLibMmio.

This patch series is dependent on the edk2
patch series that implements BaseMemoryLibMmio
and can be seen at:
https://edk2.groups.io/g/devel/topic/patch_v2_00_11_kvmtool/74200861?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,74200861

This changes in this patch series can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/299_kvmtool_plat_support_v2

Sami Mujawar (2):
  Platform/ARM: Link NorFlashDxe with BaseMemoryLibMmio
  Platform/Comcast: Link NorFlashDxe with BaseMemoryLibMmio

 Platform/ARM/JunoPkg/ArmJuno.dsc                     | 7 +++++--
 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc              | 5 ++++-
 Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc    | 7 +++++--
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +++++--
 Platform/Comcast/RDKQemu/RDKQemu.dsc                 | 8 ++++++--
 5 files changed, 25 insertions(+), 9 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


             reply	other threads:[~2020-05-14  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  8:46 Sami Mujawar [this message]
2020-05-14  8:46 ` [PATCH edk2-platforms v1 1/2] Platform/ARM: Link NorFlashDxe with BaseMemoryLibMmio Sami Mujawar
2020-05-14  8:46 ` [PATCH edk2-platforms v1 2/2] Platform/Comcast: " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514084607.25956-1-sami.mujawar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox