From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.43]) by mx.groups.io with SMTP id smtpd.web12.8536.1589446004757820635 for ; Thu, 14 May 2020 01:46:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=GFZa16Ns; spf=pass (domain: arm.com, ip: 40.107.21.43, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJvf/AwidxlRnbQRIxzFM46VCBeWAI7MSuk6R554ryg=; b=GFZa16NsRmREQIdy1/cV1gCcBmrH+AkzXfpx0TWB6VJ3wEQKj/X7M0AGiEmXPKdKI1Z6ygPCsfjJ8/ehydMUScSiHnVRUjcym0rT66To2Ie8GS8wA94qmNZneyW7leaQL7p6jCfMaMn91Du5k1lQIIsDqENXj1Sv0rSMkMJkIhk= Received: from AM0PR03CA0067.eurprd03.prod.outlook.com (2603:10a6:208::44) by DB6PR0801MB2007.eurprd08.prod.outlook.com (2603:10a6:4:78::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Thu, 14 May 2020 08:46:41 +0000 Received: from AM5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:0:cafe::b7) by AM0PR03CA0067.outlook.office365.com (2603:10a6:208::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Thu, 14 May 2020 08:46:41 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT010.mail.protection.outlook.com (10.152.16.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 08:46:41 +0000 Received: ("Tessian outbound e88319d7ccd0:v54"); Thu, 14 May 2020 08:46:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b40cca9e5449691b X-CR-MTA-TID: 64aa7808 Received: from ca225fdee3fe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3852CEDC-B9BA-4954-A1E1-ED8605A21A6B.1; Thu, 14 May 2020 08:46:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca225fdee3fe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 May 2020 08:46:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZO7l5E95fwkM3KbHBJWb9kZ7APAJA9KUhfgkzeu1P78krlWRM3avoZlnmuCdnCvq8VBZSnm5xkR9WC/d7J2CaJUiYchX+Ozdg+RW999VXziCNJoX6/DWgkLG/ufkXCRyMxGOSY1VuqZvRebGFak1Ie8bCsFjglnqua7iDQmIGJ++9c5BW+/gUAEmSr6tUi+HFVMcyJ/ce2GZnCpyQPVFfDLXC+Bp70ul+vEQPuNDN6WR5uuc9Wocw9eahiVwbZLIuZ9KDuG0h8xb6FsUSTfG6127gmwBqB+5kZPzCjH8QELZUrqFJ81uLAvSZ+mDoovDAL8l7FNbI2D41pxC2Ev5qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJvf/AwidxlRnbQRIxzFM46VCBeWAI7MSuk6R554ryg=; b=Gao7qKD6B0IDDPE39gdGXRW7C8+b6CKOf8jIVn0rnF1JMNdclYoPDOOiGaM2SSipKbg6hNEc1rlOUXtymFCzgcokg0PMLdtbgJNZn0nN7ffS5vS13HAfuYCK6ltH0sJF65QDRO5zgVwf+/6IyUvzsJM2TM1pCjFqrFqZRWpjXLJiD0h9xKQAYwYz0sGz0TxvDEMeFUXMpwabDXg6UYl7q91Ln7hEvRSM6jbTnbeze+STnzYwVoih07DImd0YPdWivgOek9h3RYvoHrc6BdBEXHRj7m4ruVUOBML7hw0x2bj1yzi+o9oGW2dIwDTrcOF0uOK1BRan9HcA5S4GDVoIHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJvf/AwidxlRnbQRIxzFM46VCBeWAI7MSuk6R554ryg=; b=GFZa16NsRmREQIdy1/cV1gCcBmrH+AkzXfpx0TWB6VJ3wEQKj/X7M0AGiEmXPKdKI1Z6ygPCsfjJ8/ehydMUScSiHnVRUjcym0rT66To2Ie8GS8wA94qmNZneyW7leaQL7p6jCfMaMn91Du5k1lQIIsDqENXj1Sv0rSMkMJkIhk= Received: from MR2P264CA0106.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::22) by AM0PR08MB3700.eurprd08.prod.outlook.com (2603:10a6:208:fc::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Thu, 14 May 2020 08:46:30 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:33:cafe::cb) by MR2P264CA0106.outlook.office365.com (2603:10a6:500:33::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Thu, 14 May 2020 08:46:30 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 08:46:29 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Thu, 14 May 2020 08:46:08 +0000 Received: from E107187.Arm.com (10.57.42.179) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Thu, 14 May 2020 08:46:08 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [PATCH edk2-platforms v1 1/2] Platform/ARM: Link NorFlashDxe with BaseMemoryLibMmio Date: Thu, 14 May 2020 09:46:06 +0100 Message-ID: <20200514084607.25956-2-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200514084607.25956-1-sami.mujawar@arm.com> References: <20200514084607.25956-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(136003)(346002)(39860400002)(396003)(376002)(46966005)(86362001)(336012)(82740400003)(478600001)(26005)(5660300002)(70586007)(426003)(54906003)(8936002)(8676002)(2906002)(70206006)(47076004)(1076003)(356005)(6916009)(316002)(7696005)(81166007)(186003)(36756003)(82310400002)(44832011)(2616005)(4326008)(19627235002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bdfd525-3652-4806-42e3-08d7f7e35290 X-MS-TrafficTypeDiagnostic: AM0PR08MB3700:|DB6PR0801MB2007: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-Forefront-PRVS: 040359335D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: luLQPVxUOS3F8c73riZCNWqi9N+UK1MhUQy8Rv2HgXocLZced+IF3B8eSmG/gsVjZKITN8bu165WnwWyHq7Aws4qJr6TKhR07W8TdGdGM4tLevb9IyoDuIVC+KwAcerwQOEQ4tthuPwY+WVzXugHtMa+UZfBc2O+tr1SetKABidFkWfSGdZst39Xl2LaP5OzwoTBXspFWIqTcEga4hJtEXbtsi4ByTYzgGRV5FAuVitAlOQojzOuuN2hWvW91/TJLPnHhuxuMlr8tvPfIVw7KCNh+SKbvXld0W6ba4/W0aYW3SuSrXa3mwfZxOLWbiJCRNGSHEHReqMK+9NV3uD80MWVwu6QUGzsvKuXV50rySGc2w7msHT8m+K6GcQE+ZSebHcpYzLZQi+0cb4DE5p4MX5K8b/CIRf3EZqKPEKBvb6ZQAH4RaxFWLs3ZqYZhrb5/NqZBllhZDmiOf3y+VuUr5hAi4jfnUVKSCcvRkYHs8y2zSPTiSGw8+Gr+SW9uAD9ypjVU3YplN+3/WnWsW6thw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3700 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(396003)(376002)(136003)(346002)(46966005)(8676002)(36756003)(19627235002)(1076003)(426003)(2906002)(478600001)(5660300002)(36906005)(82310400002)(316002)(70206006)(8936002)(2616005)(336012)(44832011)(82740400003)(54906003)(186003)(70586007)(6916009)(7696005)(86362001)(4326008)(81166007)(26005)(47076004);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: ed0e672b-b0f7-4176-574e-08d7f7e34bdf X-Forefront-PRVS: 040359335D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kj2ZlK5IQDLKzTOzp2Cd8lA3PL9VMv9kyawgCQyriUM65XI/i24g/JcBv3UNNHJ0yEjgOsyo9sPWs8ntd29OF+cnJgnm/h1yBoCGpLQURbZe1uD8mAWWTUQXurf1F7PJFyWRYp25t7ckTYFON4K5A8yOWXMIdS2OQjP4mGdI+bcRdXN/b+mhUSHeWrA2RwsD1BzIKz1kiS7GBqw6N2rxeZ8ValIMB66ROb8pgNT0pEyiHrGL8l9z7ipreNda9guhJ9Mj/fRSPxlI8OmKAbSfadG7vzkmofJDIK7S+3JeyhS3yS+5alyIbb2zXt92PrHnfBxa8kAnYn4EToZpy3p+RIER4A8tCa3pftI8zOB+tZ1oRrqEgXAt8o/owuIGtoUgzJcOHruW+cQZqWkAUm6El4jV1nvUvR2hsNJBM+qn66LYwIEfpxxr0G4oWG1ODRa0ZnEL7AreMpXFxw09GsH0c463Zhj7zUgWGJcs2sHnbvtBbsc9b/02HPuNh14zc4tevSqE2Fzl0z+FB9NLZ5gmLA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 08:46:41.0487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bdfd525-3652-4806-42e3-08d7f7e35290 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2007 Content-Type: text/plain NorFlashDxe must use aligned MMIO accesses to read data from flash as this is device memory. The AlignedCopyMem() in NorFlashDxe was used to copy the flash data which prevented unaligned access to device memory. However, the compiler could optimize the code to generate pre/post indexed or LDP operations. This is a problem for guest/virtual firmware as the hypervisor code cannot get the syndrome information for the trapped accesses. To address the such issues, BaseMemoryLibMmio library has been introduced to perform aligned MMIO accesses. The NorFlashDxe has been updated to use CopyMem() instead of using AlignedCopyMem() and therefore the NorFlashDxe must be linked with BaseMemoryLibMmio. This patch updates the workspace files to link NorFlashDxe with BaseMemoryLibMmio for the following platforms: - Arm Juno - Sgi Platform - Arm VExpress CTA15-A7 - Arm VExpress FVP Signed-off-by: Sami Mujawar --- Platform/ARM/JunoPkg/ArmJuno.dsc | 7 +++++-- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 5 ++++- Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 7 +++++-- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +++++-- 4 files changed, 19 insertions(+), 7 deletions(-) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc index a6ea957b383219283354500d4c9f0baaa7ade6c9..fc9f2450fddac69e605a2821efa5fc3476ac7c2f 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2018, ARM Limited. All rights reserved. +# Copyright (c) 2013-2020, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -275,7 +275,10 @@ [Components.common] MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf ArmPkg/Drivers/ArmGic/ArmGicDxe.inf - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf { + + BaseMemoryLib|MdePkg/Library/BaseMemoryLibMmio/BaseMemoryLibMmio.inf + } ArmPkg/Drivers/TimerDxe/TimerDxe.inf ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc index f5f9f144eee9ee1d24aaac1a434a7d26f28c4eb3..c57c561c58502f3429f353207680692d3be2b837 100644 --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc @@ -225,7 +225,10 @@ [Components.common] ArmPkg/Drivers/TimerDxe/TimerDxe.inf ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf { + + BaseMemoryLib|MdePkg/Library/BaseMemoryLibMmio/BaseMemoryLibMmio.inf + } EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc index 144dd4f8b8e9bf3639719709ad02c042ea8481eb..3a2d25bc8ec64094f3c51b203cde678afbf43d78 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2012-2018, ARM Limited. All rights reserved. +# Copyright (c) 2012-2020, ARM Limited. All rights reserved. # Copyright (c) 2015, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -228,7 +228,10 @@ [Components.common] MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf ArmPkg/Drivers/ArmGic/ArmGicDxe.inf - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf { + + BaseMemoryLib|MdePkg/Library/BaseMemoryLibMmio/BaseMemoryLibMmio.inf + } ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf ArmPkg/Drivers/TimerDxe/TimerDxe.inf ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc index a6f536a332281a624403dac2e4bf18aa9ba96d0b..b0066e12d75820ebf5972d73b4b3907f3f5f697e 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2018, ARM Limited. All rights reserved. +# Copyright (c) 2011-2020, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -270,7 +270,10 @@ [Components.common] !endif ArmPkg/Drivers/ArmGic/ArmGicDxe.inf - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf { + + BaseMemoryLib|MdePkg/Library/BaseMemoryLibMmio/BaseMemoryLibMmio.inf + } ArmPkg/Drivers/TimerDxe/TimerDxe.inf !ifdef EDK2_ENABLE_PL111 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'