From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.42]) by mx.groups.io with SMTP id smtpd.web12.8540.1589446009078775718 for ; Thu, 14 May 2020 01:46:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=fC7UEpKI; spf=pass (domain: arm.com, ip: 40.107.7.42, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIzo7HRTRGmEwfxhBXKpzo1Rjqi0yEkissDNj3RMRSw=; b=fC7UEpKIdBVFTcffJUgr1cGqetcCfD2O7Y0kzm2cekgjT3fFmjwPb8420ExBnGDXa72jQRKtDwEXRdvvMmBkCGky1bIks2mtXGKCaDe00w+PkLNv1a1t5kUL17OBJ+IMTjr1bGUPtWsd7vYcoF1k/MiB+qeOz7guIsMIxh5k5lY= Received: from PR3P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::15) by AM6PR08MB3287.eurprd08.prod.outlook.com (2603:10a6:209:41::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 14 May 2020 08:46:46 +0000 Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:102:56:cafe::c7) by PR3P192CA0010.outlook.office365.com (2603:10a6:102:56::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Thu, 14 May 2020 08:46:45 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 08:46:44 +0000 Received: ("Tessian outbound ff098c684b24:v54"); Thu, 14 May 2020 08:46:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 500e73ef70f17485 X-CR-MTA-TID: 64aa7808 Received: from 3a3ad69f3b93.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A0C6777-0829-4C2C-B178-50056489A2E6.1; Thu, 14 May 2020 08:46:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3a3ad69f3b93.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 May 2020 08:46:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKK1nu40pTEJTKJz/Y6mc5RFE3jh6u1n5O1Tyiw+nceT0uQgPHqdvajsg1MkdBYBh6DLOU6ZseNkGC8Ppq3lbbhtGQbxLtjAb4uh0DwRkoRPBNcs+Eg4eOdv/t/XC4Gs36Kditw3w9Cf5PjUPuO4imKRBXuPhonGIVm99aiYrXavOpGgCCKSaUcUTtMAd/h9NJdOqnEOD9cefJmOfcl9wOBFLKO5oItWA3rYKQaA5zK65K+brMhx7qdmFh4pgSUH9+Vw/tFsEY7EdUUYBoLyWVJ+YtaqWaDRZcNNUhd7gKafeCVpefdBuuG++aYjOG6HatEKg6NcF3ShmyrpWcCmzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIzo7HRTRGmEwfxhBXKpzo1Rjqi0yEkissDNj3RMRSw=; b=OAoXdFfjjjtcEllPGF7kDg9VI2FVWfXAgNtq9aRScNQ5vJ92utSJtKYyJ5WJ4CX1rKpLiItIorZgq1mhUmQyW0x4wdhrbN1Zkhk830bZT6s1ZC+0Qz7KsjMdc8TFCI09j3WGf2EkvEt8mqeXpHVyowRyBpQGeDg6RfcDFyCozabLC5DzfEUqW7ne+YclPK8I4U2ucXOlm6e+Hozx3pfz79SmbYMP1OREYguMmvlstQBGTnOeOyNZK9TpTyxYgwUQhuE+cXSeszLxBSKlY5x1X+wvXP21CbC9bIhJEkO8KmXFKCSe41fYBrbVD+1gsnk5Z/P3I30q/80RetkG/OMmYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIzo7HRTRGmEwfxhBXKpzo1Rjqi0yEkissDNj3RMRSw=; b=fC7UEpKIdBVFTcffJUgr1cGqetcCfD2O7Y0kzm2cekgjT3fFmjwPb8420ExBnGDXa72jQRKtDwEXRdvvMmBkCGky1bIks2mtXGKCaDe00w+PkLNv1a1t5kUL17OBJ+IMTjr1bGUPtWsd7vYcoF1k/MiB+qeOz7guIsMIxh5k5lY= Received: from MR2P264CA0107.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::23) by AM6PR08MB4533.eurprd08.prod.outlook.com (2603:10a6:20b:b5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Thu, 14 May 2020 08:46:38 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:33:cafe::d8) by MR2P264CA0107.outlook.office365.com (2603:10a6:500:33::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Thu, 14 May 2020 08:46:37 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 08:46:37 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Thu, 14 May 2020 08:46:09 +0000 Received: from E107187.Arm.com (10.57.42.179) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Thu, 14 May 2020 08:46:09 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [PATCH edk2-platforms v1 2/2] Platform/Comcast: Link NorFlashDxe with BaseMemoryLibMmio Date: Thu, 14 May 2020 09:46:07 +0100 Message-ID: <20200514084607.25956-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200514084607.25956-1-sami.mujawar@arm.com> References: <20200514084607.25956-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966005)(86362001)(82310400002)(5660300002)(336012)(36756003)(186003)(426003)(2616005)(1076003)(2906002)(44832011)(26005)(478600001)(356005)(81166007)(54906003)(8676002)(70206006)(7696005)(82740400003)(4326008)(70586007)(47076004)(316002)(6916009)(8936002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b6583f8-30a0-40f7-b412-08d7f7e354cb X-MS-TrafficTypeDiagnostic: AM6PR08MB4533:|AM6PR08MB3287: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-Forefront-PRVS: 040359335D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tqgBvnUO4PQBlIwmSz/wy7uIF/Fxj0lYnH+1184JT4UXqTJ6lIiyNh6Qa9HmoRR57Dww64GKcdbFTUcwXNFvDCvJfOV0X2vngXIBK+SoLB63gqi7StHomm1pIgedQpFjTdzYUFKX1c80Fjv8gPRYxQEqTCe92c4lUFqui0YCcxyMxco4WaJYu9pXjisnoNLMENsmkn7Yv0IX1MXt+7vPqrDQ95UwiVbxAInXnemjod6WnpCGSRsUJiAlN1oljueXifa4OMLl2Jl8bRW2sNGXTt2NUP4pFKF5krhWMEYqixnCebvChZxyt9IUyjyWcuvc5vEdBE8SuSFnCjFNGRNBHp2KUvsMgmxjxf5rA7A2cBjtIadLO+hJg45Gbp54BNwQ9YDCUr0f1mJd7DgrUeKy7fiCNDwoVSc96r0TxvY1wB6hRGp6GQ0eHdgOjI5FIllj5fdabfnFEMwXQVpxuVFr/372/gFsU/+Nje5aMXDjk/AP+LFFdDPkfB/dxCg7f1GWzSwP+CAQ3OlCAeYoEh7/oQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4533 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(46966005)(2616005)(86362001)(44832011)(316002)(82740400003)(70206006)(1076003)(47076004)(70586007)(7696005)(8676002)(36756003)(26005)(2906002)(54906003)(36906005)(426003)(82310400002)(6916009)(478600001)(4326008)(5660300002)(186003)(81166007)(8936002)(336012);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: f7173a70-fea1-47dd-81f9-08d7f7e35066 X-Forefront-PRVS: 040359335D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y7Yjbv8kpS1jlT6FBTk4uVWKah2dwCNH3pMGDyfx2OJcVKnTU95LMCHWie4Ul50v2ckFNzoCKaOBLUCinO81IFUX1hfKmHxZZuJLxkkebxCXzzcZdS4ALarpLqIsQNlW40REXjpCD7MQF1DFRDtMD7JAaJkvXLH27w0hJil7N2c6EaesAzdovD2rx2JMHorMC0H58mEbfEGx2C2JNh1L0z2uvGdwnsud4OUa5QTcKZXyUN9v8/qN+QCe7mLNTmx7EwnJjW+l5spO7f3D3tZTksf3cbsVK/5kGCpElPsnAgNalOeFxEbmcLQIHTBEXtWbTBREmrvAfJN2eOP6yFqwFFCpLLJVc6d40gFLXVfTQwY9Gj5XrVNOQ1AjH6zwnCj0UojqhITyA2tIc4+QBZFvEeQ1K+fZWFYdVaQ20VlMFGk3nqYd2IISKFnhRxqoahCSrWsL/0tJMF0gJJMcS/KHxjP5dmtGp0aG9HRkUNe8cyVhg28iMaL2RgxAJrnQom/OvEi3JexHodCR75p9M7SuyA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 08:46:44.7278 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6583f8-30a0-40f7-b412-08d7f7e354cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3287 Content-Type: text/plain NorFlashDxe must use aligned MMIO accesses to read data from flash as this is device memory. The AlignedCopyMem() in NorFlashDxe was used to copy the flash data which prevented unaligned access to device memory. However, the compiler could optimize the code to generate pre/post indexed or LDP operations. This is a problem for guest/virtual firmware as the hypervisor code cannot get the syndrome information for the trapped accesses. To address the such issues, BaseMemoryLibMmio library has been introduced to perform aligned MMIO accesses. The NorFlashDxe has been updated to use CopyMem() instead of using AlignedCopyMem() and therefore the NorFlashDxe must be linked with BaseMemoryLibMmio. This patch updates the workspace files to link NorFlashDxe with BaseMemoryLibMmio for the RDK Qemu platform. Signed-off-by: Sami Mujawar --- Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc index 440d2ace917cb639a04d1581fae71364d49c774f..c4e09c716a506c7e33a9cafd3612d81c21375751 100644 --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. +# Copyright (c) 2011-2020, ARM Limited. All rights reserved. # Copyright (c) 2014 - 2018, Linaro Limited. All rights reserved. # Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. # @@ -301,7 +301,11 @@ [Components.common] NULL|ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.inf } - ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf + ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf { + + BaseMemoryLib|MdePkg/Library/BaseMemoryLibMmio/BaseMemoryLibMmio.inf + } + MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf # -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'