From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, andrey.warkentin@gmail.com,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH edk2-platforms 1/1] Silicon/Socionext/SynQuacer: use Generic Event Device for power button
Date: Fri, 15 May 2020 10:32:35 +0200 [thread overview]
Message-ID: <20200515083235.13415-1-ard.biesheuvel@arm.com> (raw)
Drop the description of the interrupt handling part of the GPIO
controller, and use a ACPI0013 Generic Event device instead to
handle the power button event. This way, an OS can handle these
events without the need for a SoC specific driver.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 52 ++++++++++++--------
1 file changed, 31 insertions(+), 21 deletions(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
index f6ff3988aa91..3cfd025fbc16 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
@@ -196,18 +196,40 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
})
}
- Device (EXIU) {
- Name (_HID, "SCX0008")
+ Device (GED0) {
+ Name (_HID, "ACPI0013")
Name (_UID, Zero)
Name (_CRS, ResourceTemplate () {
- Memory32Fixed (ReadWrite, SYNQUACER_EXIU_BASE, SYNQUACER_EXIU_SIZE)
- })
- Name (_DSD, Package () {
- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
- Package () {
- Package () { "socionext,spi-base", 112 },
- }
+ Interrupt (ResourceConsumer, Edge, ActiveHigh, ExclusiveAndWake) { 152 }
})
+ OperationRegion (EXIU, SystemMemory, SYNQUACER_EXIU_BASE, 0x20)
+ Field (EXIU, DWordAcc, NoLock, Preserve)
+ {
+ MASK, 32,
+ SRCS, 32,
+ REQS, 32,
+ RAWR, 32,
+ REQC, 32,
+ LEVL, 32,
+ EDGC, 32,
+ SWIR, 32,
+ }
+
+ Method (_INI) {
+ REQC = 0xffffffff
+ MASK = 0xffffffff
+
+ /* enable the power button on line 8 as edge active low */
+ LEVL &= ~0x100
+ EDGC |= 0x100
+ REQC = 0x100
+ MASK = 0xfffffeff
+ }
+
+ Method (_EVT) {
+ REQC = 0x100
+ Notify (\_SB.PWRB, 0x80)
+ }
}
Device (GPIO) {
@@ -215,9 +237,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
Name (_UID, Zero)
Name (_CRS, ResourceTemplate () {
Memory32Fixed (ReadWrite, SYNQUACER_GPIO_BASE, SYNQUACER_GPIO_SIZE)
- Interrupt (ResourceConsumer, Edge, ActiveLow, ExclusiveAndWake, 0, "\\_SB.EXIU") {
- 8,
- }
})
Name (_DSD, Package () {
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
@@ -237,15 +256,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
}
}
})
- Name (_AEI, ResourceTemplate () {
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault, 0, "\\_SB.GPIO")
- {
- 8
- }
- })
- Method (_E08) {
- Notify (\_SB.PWRB, 0x80)
- }
}
Device (PWRB) {
--
2.17.1
next reply other threads:[~2020-05-15 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 8:32 Ard Biesheuvel [this message]
2020-05-15 20:00 ` [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext/SynQuacer: use Generic Event Device for power button Andrei Warkentin
2020-05-15 22:20 ` Ard Biesheuvel
2020-05-17 11:03 ` Ard Biesheuvel
2020-05-18 17:20 ` Leif Lindholm
2020-05-19 12:30 ` [edk2-devel] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515083235.13415-1-ard.biesheuvel@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox