public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashley E Desimone" <ashley.e.desimone@intel.com>
To: devel@edk2.groups.io
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Puja Pandya <puja.pandya@intel.com>,
	Erik Bjorge <erik.c.bjorge@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Prince Agyeman <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
Date: Fri, 15 May 2020 17:19:01 -0700	[thread overview]
Message-ID: <20200516001901.13008-1-ashley.e.desimone@intel.com> (raw)

When attempting to resolve whether a manifest is a loose
manifest or cannot be found pass a ManifestXML object to
the recurisve call toe find_project_in_all_indices

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
index 08c4fe6..db41e75 100644
--- a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
+++ b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
@@ -197,7 +197,7 @@ def find_project_in_all_indices (project, edkrepo_cfg, edkrepo_user_cfg, except_
         except EdkrepoManifestNotFoundException:
             return None, None, project
     elif os.path.isfile(os.path.join(os.getcwd(), project)):
-        manifest = os.path.join(os.getcwd(), project)
+        manifest = ManifestXml(os.path.join(os.getcwd(), project))
         try:
             found_manifest_repo, found_cfg, found_project = find_project_in_all_indices(manifest.project_info.codename,
                                                                                         edkrepo_cfg,
-- 
2.16.2.windows.1


             reply	other threads:[~2020-05-16  0:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  0:19 Ashley E Desimone [this message]
2020-05-16  0:40 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices Bjorge, Erik C
2020-05-18  1:58 ` [edk2-devel] " Nate DeSimone
2020-05-18  2:03 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516001901.13008-1-ashley.e.desimone@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox