* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
@ 2020-05-16 0:19 Ashley E Desimone
2020-05-16 0:40 ` Bjorge, Erik C
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ashley E Desimone @ 2020-05-16 0:19 UTC (permalink / raw)
To: devel
Cc: Nate DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew,
Prince Agyeman
When attempting to resolve whether a manifest is a loose
manifest or cannot be found pass a ManifestXML object to
the recurisve call toe find_project_in_all_indices
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
index 08c4fe6..db41e75 100644
--- a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
+++ b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
@@ -197,7 +197,7 @@ def find_project_in_all_indices (project, edkrepo_cfg, edkrepo_user_cfg, except_
except EdkrepoManifestNotFoundException:
return None, None, project
elif os.path.isfile(os.path.join(os.getcwd(), project)):
- manifest = os.path.join(os.getcwd(), project)
+ manifest = ManifestXml(os.path.join(os.getcwd(), project))
try:
found_manifest_repo, found_cfg, found_project = find_project_in_all_indices(manifest.project_info.codename,
edkrepo_cfg,
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
2020-05-16 0:19 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices Ashley E Desimone
@ 2020-05-16 0:40 ` Bjorge, Erik C
2020-05-18 1:58 ` [edk2-devel] " Nate DeSimone
2020-05-18 2:03 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Bjorge, Erik C @ 2020-05-16 0:40 UTC (permalink / raw)
To: Desimone, Ashley E, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com>
Sent: Friday, May 15, 2020 5:19 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
When attempting to resolve whether a manifest is a loose manifest or cannot be found pass a ManifestXML object to the recurisve call toe find_project_in_all_indices
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
index 08c4fe6..db41e75 100644
--- a/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
+++ b/edkrepo/common/workspace_maintenance/manifest_repos_maintenance.py
@@ -197,7 +197,7 @@ def find_project_in_all_indices (project, edkrepo_cfg, edkrepo_user_cfg, except_
except EdkrepoManifestNotFoundException:
return None, None, project
elif os.path.isfile(os.path.join(os.getcwd(), project)):
- manifest = os.path.join(os.getcwd(), project)
+ manifest = ManifestXml(os.path.join(os.getcwd(), project))
try:
found_manifest_repo, found_cfg, found_project = find_project_in_all_indices(manifest.project_info.codename,
edkrepo_cfg,
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
2020-05-16 0:19 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices Ashley E Desimone
2020-05-16 0:40 ` Bjorge, Erik C
@ 2020-05-18 1:58 ` Nate DeSimone
2020-05-18 2:03 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-05-18 1:58 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Ashley E
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E
> Desimone
> Sent: Friday, May 15, 2020 5:19 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a
> ManifestXML to find_project_in_all_indices
>
> When attempting to resolve whether a manifest is a loose manifest or
> cannot be found pass a ManifestXML object to the recurisve call toe
> find_project_in_all_indices
>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>
> edkrepo/common/workspace_maintenance/manifest_repos_maintenance.
> py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> b/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> index 08c4fe6..db41e75 100644
> ---
> a/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> +++
> b/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> @@ -197,7 +197,7 @@ def find_project_in_all_indices (project,
> edkrepo_cfg, edkrepo_user_cfg, except_
> except EdkrepoManifestNotFoundException:
> return None, None, project
> elif os.path.isfile(os.path.join(os.getcwd(), project)):
> - manifest = os.path.join(os.getcwd(), project)
> + manifest = ManifestXml(os.path.join(os.getcwd(), project))
> try:
> found_manifest_repo, found_cfg, found_project =
> find_project_in_all_indices(manifest.project_info.codename,
> edkrepo_cfg,
> --
> 2.16.2.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices
2020-05-16 0:19 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices Ashley E Desimone
2020-05-16 0:40 ` Bjorge, Erik C
2020-05-18 1:58 ` [edk2-devel] " Nate DeSimone
@ 2020-05-18 2:03 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-05-18 2:03 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Ashley E
Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew, Agyeman, Prince
Pushed: 66daf5ee
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashley E
> Desimone
> Sent: Friday, May 15, 2020 5:19 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a
> ManifestXML to find_project_in_all_indices
>
> When attempting to resolve whether a manifest is a loose manifest or
> cannot be found pass a ManifestXML object to the recurisve call toe
> find_project_in_all_indices
>
> Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>
> edkrepo/common/workspace_maintenance/manifest_repos_maintenance.
> py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> b/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> index 08c4fe6..db41e75 100644
> ---
> a/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> +++
> b/edkrepo/common/workspace_maintenance/manifest_repos_maintenanc
> e.py
> @@ -197,7 +197,7 @@ def find_project_in_all_indices (project,
> edkrepo_cfg, edkrepo_user_cfg, except_
> except EdkrepoManifestNotFoundException:
> return None, None, project
> elif os.path.isfile(os.path.join(os.getcwd(), project)):
> - manifest = os.path.join(os.getcwd(), project)
> + manifest = ManifestXml(os.path.join(os.getcwd(), project))
> try:
> found_manifest_repo, found_cfg, found_project =
> find_project_in_all_indices(manifest.project_info.codename,
> edkrepo_cfg,
> --
> 2.16.2.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-18 2:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-16 0:19 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices Ashley E Desimone
2020-05-16 0:40 ` Bjorge, Erik C
2020-05-18 1:58 ` [edk2-devel] " Nate DeSimone
2020-05-18 2:03 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox