Re: Patch List for 202005 stable tag

["Leif Lindholm" <leif@nuviainc.com>]

On Tue, May 19, 2020 at 11:09:42 +0000, Gao, Liming wrote:
> Hi Stewards and all:
>   I collect current patch lists in devel mail list. Those patch contributors request to add them for 200205 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.
> 
> Feature List (pass review):
> https://edk2.groups.io/g/devel/message/59578 [PATCH V7 0/1] Disable safe string constraint assertions

This one I might even be persuaded to wave through in hard
freeze. Yes, please include.

> https://edk2.groups.io/g/devel/message/59589 [PATCH V7 0/6] Add definitions introduced in UEFI 2.8a

1,3-4 only adds definitions - I'm fine with those.

2/6 looks out of place compared with the set description, but as it
falls within the scope of "align codebase with current spec", and it
is a correction, it can stay. (It should also not break anything, and
if it does, that's automatically a bug isn't it?)

5-6, I have no comment on. Someone else will have to make that call.

> Bug List (pass review):
> https://edk2.groups.io/g/devel/message/59735 [PATCH v3] SecurityPkg: Change default value source

Patch is pretty garbled in groups.io. Thankfully, it looks better in
gmail.

I have a minor concern in that neither the comments on v2 nor the
changelog in v3 indicates the (useful) addition of the bit-value
lookup table for PcdTcg2PhysicalPresenceFlags in SecurityPkg.dec
and its associated dropping of the line
"# Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT".

But if SecurityPkg maintainers are happy they haven't missed any other
changes in v3, I'm OK with this going in.

Regards,

Leif

> 
> Thanks
> Liming
> 
>