From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.10099.1589889859733330491 for ; Tue, 19 May 2020 05:04:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=peWN8dUs; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id j5so15655187wrq.2 for ; Tue, 19 May 2020 05:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3MImHRCrEloK3Eu7hNSJJS7agcc6VDExMEyEHxoDbts=; b=peWN8dUslHaCEjxaVU7xwgtz41zAkad7BBxhQ/bmvFfgIBJrh3tRxosEBG/ZUhErxm KxsbvGbbRnw6kFsDfKpcMM5dSNXcHQZvmlw9YvucqBg7TQUJm0VRQ8NTB3q9FgdpPlz0 37HLMMWJXSRSovcqbqAnrtkmniQbjkZOd0tLPyxaArySSA2bWsmVLbvh4rrcdBfjwDqe RN75C/LPikoZXVRGQK5HKkr1Dl+KKzf4cbIR28XHSVOu1lk4dhc/TyCxOyFoyLUFE0zp thULhetSIdvnl8NPrTIP523iUl/2pTvFoQuAf2ZwmBDRmwENeoRnq6XlDvDm5Zx70ddZ /ZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3MImHRCrEloK3Eu7hNSJJS7agcc6VDExMEyEHxoDbts=; b=YsKxYHVIF8iccf0zHaVJOqIdFnfBlmBy4NzAnUQKTz+aTNu958J86r1EKZSPWBVbOY hqxZqiOsCnUrz8kgjnjdKp9+2+HYZdGzeRddr9s0YXcPauT08zuvG8ugtpbeXk/2woMH YFcZp/hf/3tFK6jj1YRkAKbLgUJVoZtPYedHlsBexkS+mwxf2nCtfyXRhEu15rl6zgEc D83pWXN+00emgI6IZdIJ43bm7wgw5pGz1xdijiCET6csquam5qwjO01WBD7Ot3ensnMU uHRMGRbE/rrDR98+HwtDAVlJOxGbsB0nwCx4lEaZacVYpDN2v0zaaR9u7r4ZbocbS8E+ 9uuw== X-Gm-Message-State: AOAM532yrpor6xkJTqw/ZLJTVpz44yR+0wfkAQ+jEc9hcJ1HeYGpBFmL SKO7Blsa+gBR8jaiSCrTF1o5yA== X-Google-Smtp-Source: ABdhPJy2S/slkv6le0z6R7rAuKQC0ZIe6rluWzy51iQo3R+84kUQp8+24ObEE/shoQs1CvvbQclTLA== X-Received: by 2002:a5d:5089:: with SMTP id a9mr24165711wrt.147.1589889858206; Tue, 19 May 2020 05:04:18 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a15sm20619630wrw.56.2020.05.19.05.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:04:17 -0700 (PDT) Date: Tue, 19 May 2020 13:04:15 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: Laszlo Ersek , "Kinney, Michael D" , "afish@apple.com" , "devel@edk2.groups.io" Subject: Re: Patch List for 202005 stable tag Message-ID: <20200519120415.GN10467@vanye> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 19, 2020 at 11:09:42 +0000, Gao, Liming wrote: > Hi Stewards and all: > I collect current patch lists in devel mail list. Those patch contributors request to add them for 200205 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them. > > Feature List (pass review): > https://edk2.groups.io/g/devel/message/59578 [PATCH V7 0/1] Disable safe string constraint assertions This one I might even be persuaded to wave through in hard freeze. Yes, please include. > https://edk2.groups.io/g/devel/message/59589 [PATCH V7 0/6] Add definitions introduced in UEFI 2.8a 1,3-4 only adds definitions - I'm fine with those. 2/6 looks out of place compared with the set description, but as it falls within the scope of "align codebase with current spec", and it is a correction, it can stay. (It should also not break anything, and if it does, that's automatically a bug isn't it?) 5-6, I have no comment on. Someone else will have to make that call. > Bug List (pass review): > https://edk2.groups.io/g/devel/message/59735 [PATCH v3] SecurityPkg: Change default value source Patch is pretty garbled in groups.io. Thankfully, it looks better in gmail. I have a minor concern in that neither the comments on v2 nor the changelog in v3 indicates the (useful) addition of the bit-value lookup table for PcdTcg2PhysicalPresenceFlags in SecurityPkg.dec and its associated dropping of the line "# Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT". But if SecurityPkg maintainers are happy they haven't missed any other changes in v3, I'm OK with this going in. Regards, Leif > > Thanks > Liming > >