From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io, graeme.gregory@linaro.org,
tanmay.jagdale@linaro.org, lersek@redhat.com,
sami.mujawar@arm.com
Subject: Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings
Date: Tue, 19 May 2020 13:28:40 +0100 [thread overview]
Message-ID: <20200519122840.GQ10467@vanye> (raw)
In-Reply-To: <20200519122351.18405-1-ard.biesheuvel@arm.com>
On Tue, May 19, 2020 at 14:23:49 +0200, Ard Biesheuvel wrote:
> Add build time checks for serial terminal settings, so we don't end up
> with a non-functional serial console if the PCDs are set incorrectly
>
> v1 was just the second patch. v2 adds the first patch switching to
> STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
> as well.
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks Ard, and Laszlo!
> Ard Biesheuvel (2):
> ArmPkg/PlatformBootManagerLib: use static assertion for console type
> ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
> count
>
> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-19 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 12:23 [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings Ard Biesheuvel
2020-05-19 12:23 ` [PATCH v2 1/2] ArmPkg/PlatformBootManagerLib: use static assertion for console type Ard Biesheuvel
2020-05-19 12:23 ` [PATCH v2 2/2] ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count Ard Biesheuvel
2020-05-19 12:28 ` Leif Lindholm [this message]
2020-05-19 12:40 ` [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings Sami Mujawar
2020-05-19 16:32 ` Laszlo Ersek
2020-06-03 14:07 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519122840.GQ10467@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox