From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.10496.1589891323945623625 for ; Tue, 19 May 2020 05:28:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ChS1tihZ; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id m185so3319268wme.3 for ; Tue, 19 May 2020 05:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=14oAAmPfGgzNJ++pbIY4rX6OrOhXTeGus9+D1GqERWg=; b=ChS1tihZoZOpdQEYz3psw2KT34SMhJUwn78r6uQAGtB40JuKPzmxsApWCRs6+OGjco kZpYFzrcbyRFZAHzch8m5w8U4VyEkLmgLQJJqE22rQGCfdYW701sw2h1ptxLP9RcJkID SJOZAFNoxFHuXteTjbfzhKEWYnZVcr503U0ESYKU0hshvm2qCkuQGSTi+0VXgXwMZtor ETGd1aulVZPvw2Ii9QbCvu7Ozxmo7+XKHL6qB8h+qt61SqJMrYfeN7AYToyIfh+JvrBJ 2I1r57N/aSRK+vzIq140Yc5Kv/iCBqQ1g+hRR+exd2rjxff0KhZrLwL7qtViT0zhHZaj lMeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=14oAAmPfGgzNJ++pbIY4rX6OrOhXTeGus9+D1GqERWg=; b=nehLhgrUfRLR2t+WBnHFXOgN/WeJcYej+BZo7Xg75AdZXr62GQae8zzWZ8RgBSiX7S G0iVXmP9HMIuyq8SbCUxkAfBJpCIyvrIqxRAQqIA+DzQefWnD7//DL2Xzhu38hPt3ZsT Vm8Tpowqe5RKv0zSiRwM33vv7OeNkTLpFD47yrCgEKsAq356SUEwzyFPGxdcng1LzvGc +fQW/gQXoGJudlECEFRmLX6DACJvwBrSknVeNn8w3P+bdWDoCU2aFW/g+rtsURazY/J+ Y5ytpz+PXYEpN4GHH7fEOa/dZwhPc5DXE+5pymnxlY8ifU+pA6ZcUeNv2CtCaZyiDxc3 GURw== X-Gm-Message-State: AOAM533Ifd6OK6szjiBuEvhbBHyE9w/kielpZAq8UNomo2+ypV55560c vkDrFBoCgT1t8JOrvVYeVNuPdg== X-Google-Smtp-Source: ABdhPJy03QNymwpKp2057D8Q9wI5NEbcwnNQC75o8reE5QJaLTvA4h7yQ27P9auItn8UM+Ol21fjfg== X-Received: by 2002:a1c:7212:: with SMTP id n18mr5628763wmc.129.1589891322509; Tue, 19 May 2020 05:28:42 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id v131sm4093404wmb.27.2020.05.19.05.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:28:42 -0700 (PDT) Date: Tue, 19 May 2020 13:28:40 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, graeme.gregory@linaro.org, tanmay.jagdale@linaro.org, lersek@redhat.com, sami.mujawar@arm.com Subject: Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings Message-ID: <20200519122840.GQ10467@vanye> References: <20200519122351.18405-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200519122351.18405-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 19, 2020 at 14:23:49 +0200, Ard Biesheuvel wrote: > Add build time checks for serial terminal settings, so we don't end up > with a non-functional serial console if the PCDs are set incorrectly > > v1 was just the second patch. v2 adds the first patch switching to > STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one > as well. Reviewed-by: Leif Lindholm Thanks Ard, and Laszlo! > Ard Biesheuvel (2): > ArmPkg/PlatformBootManagerLib: use static assertion for console type > ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit > count > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > -- > 2.17.1 >