From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility
Date: Tue, 19 May 2020 14:18:37 +0100 [thread overview]
Message-ID: <20200519131837.GA1923@vanye> (raw)
In-Reply-To: <20200519123658.21501-1-ard.biesheuvel@arm.com>
On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote:
> Operator precedence is funny in DEPEX expressions, so let's add some
> parentheses to make it self explanatory. The resulting truth value
> is the same.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks!
> ---
> Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> index 7e0d6bf21a35..3d9ca559e60b 100644
> --- a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> +++ b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf
> @@ -43,4 +43,6 @@ [FixedPcd]
> g96BoardsTokenSpaceGuid.PcdI2c1BusFrequencyHz
>
> [Depex]
> - g96BoardsMezzanineProtocolGuid AND g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
> + g96BoardsMezzanineProtocolGuid AND (
> + g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid
> + )
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-19 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 12:36 [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility Ard Biesheuvel
2020-05-19 13:18 ` Leif Lindholm [this message]
2020-05-19 13:26 ` [edk2-devel] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519131837.GA1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox