From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.11591.1589894320925963983 for ; Tue, 19 May 2020 06:18:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=jIEwx/fF; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id f13so3020495wmc.5 for ; Tue, 19 May 2020 06:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZOLUir/huM+6XbJ3wUAwhttCLimKn8NVChdqz+JTU2Q=; b=jIEwx/fF+2vWp8reg4qCereBafbwaUewcE3ejTKBpSexYW3I3jZ1+lrP8Jmncuj3QW wtZ7dWeMu2CqtmtBEvJMQkSLfjbT2fM7qF9vHdla5vJQ60++BuSfwIP1eQ/gGSgtVhMt CanUm7lqPn574lxQAqKuoSzQmncDGMyWRCg6hDm/AOcn/qTRDqVoU0wL4O0qaOk2ReMZ jL9fpBqsKfqIihYmWkGDQiJmwjOTCz23sw2svtplBwoiDc0IrFErpkDlYl+0nyhX1xxW tyhBr3WhxkUr0YfibEVZjxlgohf/RQSnDXM61/rxYFYGgD2t25PMecnfnWCHWBil1C9q vIJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZOLUir/huM+6XbJ3wUAwhttCLimKn8NVChdqz+JTU2Q=; b=ra7QDF+sOZsAd4WNZPlRLIDZpljNnpUFcV0RWNWTDQTicATHOV0xPXtWP0XaaFAU0f q4Demt92iyv30SjSu8ShhvNcHNdrddhEs5JtmL3B/YieMSLDU9vxX559rRht7gMDeHWt E3fkLfu/DR4vyWrOBZ2Pc1J4aDGxvL3A74AlkAzNFpgYy6XIWIv/aXf5MjWsxLThLA+Z 0CTYGMHGXRB5f6372BsYQMvtGzBXZCgP+hL9AL0rDHiOjAp4pIevuurUZ04e++b7vRxy RPcnW98r2ElFiM8nlosFOxy/xrKFoj6DAIr7Nw1DQ/tUuPw5vQv8VY5nkejvQp5/Bt9J 99SQ== X-Gm-Message-State: AOAM5316kslW/YwKN2njYHufzhvfs17i4nUezUNGHVo19vUsFCxOGk6b wrXcz0LQ+CR3DgEWOoir1FK64Q== X-Google-Smtp-Source: ABdhPJz42yp9lSDvp0+0xQvGErJ9WQpd/hX9zPMMyWHjEBZo8sWHvsBs+x4jpTt/Ms4Jj+YgRSyc0Q== X-Received: by 2002:a1c:9804:: with SMTP id a4mr5611930wme.80.1589894319356; Tue, 19 May 2020 06:18:39 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h74sm21999051wrh.76.2020.05.19.06.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:18:38 -0700 (PDT) Date: Tue, 19 May 2020 14:18:37 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/1] Platform/96Boards/96BoardsI2cDxe: rewrite DEPEX expression for legibility Message-ID: <20200519131837.GA1923@vanye> References: <20200519123658.21501-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200519123658.21501-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 19, 2020 at 14:36:58 +0200, Ard Biesheuvel wrote: > Operator precedence is funny in DEPEX expressions, so let's add some > parentheses to make it self explanatory. The resulting truth value > is the same. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks! > --- > Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf > index 7e0d6bf21a35..3d9ca559e60b 100644 > --- a/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf > +++ b/Platform/96Boards/96BoardsI2cDxe/96BoardsI2cDxe.inf > @@ -43,4 +43,6 @@ [FixedPcd] > g96BoardsTokenSpaceGuid.PcdI2c1BusFrequencyHz > > [Depex] > - g96BoardsMezzanineProtocolGuid AND g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid > + g96BoardsMezzanineProtocolGuid AND ( > + g96BoardsI2c0MasterGuid OR g96BoardsI2c1MasterGuid > + ) > -- > 2.17.1 >