Re: [edk2-platforms: PATCH v2 1/3] Marvell/Library: UtmiLib: update USB2.0 analog settings

["Leif Lindholm" <leif@nuviainc.com>]

On Tue, May 19, 2020 at 01:09:37 +0200, Marcin Wojtas wrote:
> Hi Leif,
> 
> pon., 18 maj 2020 o 20:16 Leif Lindholm <leif@nuviainc.com> napisał(a):
> >
> > On Mon, May 18, 2020 at 20:11:49 +0200, Marcin Wojtas wrote:
> > > Hi Leif,
> > >
> > > pon., 18 maj 2020 o 19:12 Leif Lindholm <leif@nuviainc.com> napisał(a):
> > > >
> > > > On Fri, May 15, 2020 at 23:05:56 +0200, Marcin Wojtas wrote:
> > > > > This patch introduce following modifications, allowing to
> > > > > overcome the instabilities observed with certain USB2.0 endpoints:
> > > > > * Add additional step which enables the Impedance and PLL calibration.
> > > > > * Enable old squelch detector instead of the new analog squelch detector
> > > > >   circuit and update host disconnect threshold value.
> > > > > * Update LS TX driver strength coarse and fine adjustment values.
> > > > >
> > > > > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> > > > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > >
> > > > I'm OK with the current version of the code, but just noticed this.
> > > > No one can give Signed-off-by for another.
> > > > If Grzegorz is the author, that should be noted in a From: tag. Git
> > > > format-patch does this automatically if the commit's Author metadata
> > > > is set.
> > > >
> > > > This applies to all 3 patches.
> > > >
> > >
> > > The 3/3 has only only my signed-off tag (and my authorship).
> >
> > OK, I admit it, I was lazy and spotted this and only checked 2/3 and
> > assumed it was all of them :)
> >
> > > Regarding the first 2, I did the actual change, but it was based on
> > > the original U-Boot patch from Grzegorz. How about, instead of the tag,
> > > I give him a credit in a following way:
> > >
> > > Based on the original U-Boot patch from Grzegorz Jaszczyk <jaz@semihalf.com>
> > >
> > > Would that work for you?
> >
> > I have no objections to that as such, but perhaps a link to the patch
> > posting in an email archive, or the commit in a git repo, would be
> > more generically useful.
> 
> The patches have not yet made their way to the mainline U-Boot and are
> not public. I talked to Grzegorz and he's ok to withdraw the credit
> lines - changes are too minor to spend so much time on such detail.

No problem.
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as e744a0ef6815..66d22b1b4406

Regards,

Leif

> Thanks,
> Marcin
> 
> > >
> > > >
> > > > > ---
> > > > >  Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 10 +++++++++-
> > > > >  Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 18 ++++++++++++++----
> > > > >  2 files changed, 23 insertions(+), 5 deletions(-)
> > > > >
> > > > > diff --git a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h
> > > > > index 20e3133..8659110 100644
> > > > > --- a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h
> > > > > +++ b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h
> > > > > @@ -44,6 +44,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > >  #define UTMI_CALIB_CTRL_REG                       0x8
> > > > >  #define UTMI_CALIB_CTRL_IMPCAL_VTH_OFFSET         8
> > > > >  #define UTMI_CALIB_CTRL_IMPCAL_VTH_MASK           (0x7 << UTMI_CALIB_CTRL_IMPCAL_VTH_OFFSET)
> > > > > +#define UTMI_CALIB_CTRL_IMPCAL_START_OFFSET       13
> > > > > +#define UTMI_CALIB_CTRL_IMPCAL_START_MASK         (0x1 << UTMI_CALIB_CTRL_IMPCAL_START_OFFSET)
> > > > > +#define UTMI_CALIB_CTRL_PLLCAL_START_OFFSET       22
> > > > > +#define UTMI_CALIB_CTRL_PLLCAL_START_MASK         (0x1 << UTMI_CALIB_CTRL_PLLCAL_START_OFFSET)
> > > > >  #define UTMI_CALIB_CTRL_IMPCAL_DONE_OFFSET        23
> > > > >  #define UTMI_CALIB_CTRL_IMPCAL_DONE_MASK          (0x1 << UTMI_CALIB_CTRL_IMPCAL_DONE_OFFSET)
> > > > >  #define UTMI_CALIB_CTRL_PLLCAL_DONE_OFFSET        31
> > > > > @@ -54,8 +58,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > >  #define UTMI_TX_CH_CTRL_DRV_EN_LS_MASK            (0xf << UTMI_TX_CH_CTRL_DRV_EN_LS_OFFSET)
> > > > >  #define UTMI_TX_CH_CTRL_IMP_SEL_LS_OFFSET         16
> > > > >  #define UTMI_TX_CH_CTRL_IMP_SEL_LS_MASK           (0xf << UTMI_TX_CH_CTRL_IMP_SEL_LS_OFFSET)
> > > > > +#define UTMI_TX_CH_CTRL_AMP_OFFSET                20
> > > > > +#define UTMI_TX_CH_CTRL_AMP_MASK                  (0x7 << UTMI_TX_CH_CTRL_AMP_OFFSET)
> > > > >
> > > > >  #define UTMI_RX_CH_CTRL0_REG                      0x14
> > > > > +#define UTMI_RX_CH_CTRL0_DISCON_THRESH_OFFSET     8
> > > > > +#define UTMI_RX_CH_CTRL0_DISCON_THRESH_MASK       (0x3 << UTMI_RX_CH_CTRL0_DISCON_THRESH_OFFSET)
> > > > >  #define UTMI_RX_CH_CTRL0_SQ_DET_OFFSET            15
> > > > >  #define UTMI_RX_CH_CTRL0_SQ_DET_MASK              (0x1 << UTMI_RX_CH_CTRL0_SQ_DET_OFFSET)
> > > > >  #define UTMI_RX_CH_CTRL0_SQ_ANA_DTC_OFFSET        28
> > > > > @@ -63,7 +71,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > >
> > > > >  #define UTMI_RX_CH_CTRL1_REG                      0x18
> > > > >  #define UTMI_RX_CH_CTRL1_SQ_AMP_CAL_OFFSET        0
> > > > > -#define UTMI_RX_CH_CTRL1_SQ_AMP_CAL_MASK          (0x3 << UTMI_RX_CH_CTRL1_SQ_AMP_CAL_OFFSET)
> > > > > +#define UTMI_RX_CH_CTRL1_SQ_AMP_CAL_MASK          (0x7 << UTMI_RX_CH_CTRL1_SQ_AMP_CAL_OFFSET)
> > > > >  #define UTMI_RX_CH_CTRL1_SQ_AMP_CAL_EN_OFFSET     3
> > > > >  #define UTMI_RX_CH_CTRL1_SQ_AMP_CAL_EN_MASK       (0x1 << UTMI_RX_CH_CTRL1_SQ_AMP_CAL_EN_OFFSET)
> > > > >
> > > > > diff --git a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
> > > > > index 3881ebd..42f38db 100644
> > > > > --- a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
> > > > > +++ b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
> > > > > @@ -118,23 +118,33 @@ UtmiPhyConfig (
> > > > >
> > > > >    /* Impedance Calibration Threshold Setting */
> > > > >    RegSet (UtmiBaseAddr + UTMI_CALIB_CTRL_REG,
> > > > > -    0x6 << UTMI_CALIB_CTRL_IMPCAL_VTH_OFFSET,
> > > > > +    0x7 << UTMI_CALIB_CTRL_IMPCAL_VTH_OFFSET,
> > > > >      UTMI_CALIB_CTRL_IMPCAL_VTH_MASK);
> > > > >
> > > > > +  /* Start Impedance and PLL Calibration */
> > > > > +  Mask = UTMI_CALIB_CTRL_PLLCAL_START_MASK;
> > > > > +  Data = (0x1 << UTMI_CALIB_CTRL_PLLCAL_START_OFFSET);
> > > > > +  Mask |= UTMI_CALIB_CTRL_IMPCAL_START_MASK;
> > > > > +  Data |= (0x1 << UTMI_CALIB_CTRL_IMPCAL_START_OFFSET);
> > > > > +  RegSet (UtmiBaseAddr + UTMI_CALIB_CTRL_REG, Data, Mask);
> > > > > +
> > > > >    /* Set LS TX driver strength coarse control */
> > > > >    Mask = UTMI_TX_CH_CTRL_DRV_EN_LS_MASK;
> > > > >    Data = 0x3 << UTMI_TX_CH_CTRL_DRV_EN_LS_OFFSET;
> > > > > -  /* Set LS TX driver fine adjustment */
> > > > > +  Mask |= UTMI_TX_CH_CTRL_AMP_MASK;
> > > > > +  Data |= 0x4 << UTMI_TX_CH_CTRL_AMP_OFFSET;
> > > > >    Mask |= UTMI_TX_CH_CTRL_IMP_SEL_LS_MASK;
> > > > >    Data |= 0x3 << UTMI_TX_CH_CTRL_IMP_SEL_LS_OFFSET;
> > > > >    RegSet (UtmiBaseAddr + UTMI_TX_CH_CTRL_REG, Data, Mask);
> > > > >
> > > > >    /* Enable SQ */
> > > > >    Mask = UTMI_RX_CH_CTRL0_SQ_DET_MASK;
> > > > > -  Data = 0x0 << UTMI_RX_CH_CTRL0_SQ_DET_OFFSET;
> > > > > +  Data = 0x1 << UTMI_RX_CH_CTRL0_SQ_DET_OFFSET;
> > > > >    /* Enable analog squelch detect */
> > > > >    Mask |= UTMI_RX_CH_CTRL0_SQ_ANA_DTC_MASK;
> > > > > -  Data |= 0x1 << UTMI_RX_CH_CTRL0_SQ_ANA_DTC_OFFSET;
> > > > > +  Data |= 0x0 << UTMI_RX_CH_CTRL0_SQ_ANA_DTC_OFFSET;
> > > > > +  Mask |= UTMI_RX_CH_CTRL0_DISCON_THRESH_MASK;
> > > > > +  Data |= 0x0 << UTMI_RX_CH_CTRL0_DISCON_THRESH_OFFSET;
> > > > >    RegSet (UtmiBaseAddr + UTMI_RX_CH_CTRL0_REG, Data, Mask);
> > > > >
> > > > >    /* Set External squelch calibration number */
> > > > > --
> > > > > 2.7.4
> > > > >