From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.10999.1589975496311732489 for ; Wed, 20 May 2020 04:51:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=DzsPrXfl; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id m12so2275930wmc.0 for ; Wed, 20 May 2020 04:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9aDNzp+l+ozOpIzaYWJAlyktigzrpFYdzzlWgD6XtEg=; b=DzsPrXflB+Rxct2otRveB5YPkKIzuBBdMlFq453sALEH3qFd5On1LFQEmwaHloTMRq fl1OOjMHirUgWGVuIRLdUWWohxlFvoIMAh2p0Wkid6u6SSwDq8SqJY8EJbvQ5ELEjAZD yXjr3CJg/W74IXXOZUE6hJXZhXhv4UD6LGaU94ZEpdOZsQy12/NS19pEnG1jrLjo+nP+ wRGlSzDYROLlhuDmofyctvc5C4NWLYXHOQFyUfC1TiokLdskuJqMxosQlahuV5ap/ybr sYWWWA5fkc93Pu3AR8ddHPvGzluX1SElMkw0E2UnTXi2wjx6xprjsgjPa/iu9K5p+oTC 47Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9aDNzp+l+ozOpIzaYWJAlyktigzrpFYdzzlWgD6XtEg=; b=g1Tc5rUo3ZxfMzz57vwHYsMlqbbMd8lXj5CM+K5bfmlSH6T+dHD486+io9/2jD8+wg 8hqOT37Gueyq9RLJISLKJcklbBy5M0FfFWaXpdqp4Sv/ruVU+Ncvfc+UXduPIQjaJRWQ m0YqSLbIXWJpdiRh3QJKv0gxFSNBSD6nxWK9Boiqn25G26Yg/b08NNPWL28VmBxwwDnN yXPf+JQ/eybUrCHfXmphg1IjjTgxNDc87dJi2CCF2iiM8LimCrTCfl1C4IR6mgiMM8UP spuXcnTGt4sSF8fMBer/gACULyI/pL1HlGE9BYOrM4/WDzYOp4+N5O4msZX/h+r4SeVZ edwA== X-Gm-Message-State: AOAM533WiJISUlCrBfYalEzgCyoblMLkwAzoYf18p9dLwYrZXtGCKfTn ZmYFAmXTa6fBOQ6h5kdBFYjUig== X-Google-Smtp-Source: ABdhPJx/vWWvbv/ISkYv9JaR6yXYT471RcwSMYIzNcOXnXlExJlU1oPH+t4csDskHoZB3ztrwAlKHw== X-Received: by 2002:a1c:bb57:: with SMTP id l84mr4633648wmf.128.1589975494855; Wed, 20 May 2020 04:51:34 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id b12sm3024551wmj.0.2020.05.20.04.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 04:51:34 -0700 (PDT) Date: Wed, 20 May 2020 12:51:32 +0100 From: "Leif Lindholm" To: Daniel Schaefer Cc: devel@edk2.groups.io, Gilbert Chen , Abner Chang , Michael D Kinney Subject: Re: [PATCH v2 1/3] ProcessorPkg/RiscVOpensbLib: Add opensbi submodule Message-ID: <20200520115132.GL1923@vanye> References: <20200515133937.29909-1-daniel.schaefer@hpe.com> <20200515133937.29909-2-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20200515133937.29909-2-daniel.schaefer@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 15, 2020 at 15:39:35 +0200, Daniel Schaefer wrote: > Add submodule opensbi under > Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbLlib. > The current supported opensbi version for RISC-V edk2 port is tags/v0.6. > > Signed-off-by: Daniel Schaefer > Co-authored-by: Gilbert Chen > Co-authored-by: Abner Chang Please drop the above two lines. >>From a project standpoint they are no-ops and I don't really mind keeping them in 2-3/3 (I appreciate the sentiment), but this patch isn't interesting enough to justify it, and mainly duplicates/modifies content already in edk2/ReadMe.rst. With that: Reviewed-by: Leif Lindholm > > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Michael D Kinney > Cc: Leif Lindholm > --- > .gitmodules | 3 ++ > Readme.md | 36 ++++++++++++++++++++ > Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi | 1 + > 3 files changed, 40 insertions(+) > > diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 000000000000..88aafaf15820 > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi"] > + path = Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi > + url = https://github.com/riscv/opensbi > diff --git a/Readme.md b/Readme.md > index 8f9522659d7b..8f7317e6b029 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -10,6 +10,10 @@ The majority of the content in the EDK II open source project uses a > [BSD-2-Clause Plus Patent License](License.txt). Additional details on EDK II > open source project code contributions can be found in the edk2 repository > [Readme.md](https://github.com/tianocore/edk2/blob/master/Readme.md). > +The EDK II Platforms open source project contains the following components that > +are covered by additional licenses: > + > +- [`Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi`](https://github.com/riscv/opensbi/blob/master/COPYING.BSD) > > # INDEX > * [Overview](#overview) > @@ -260,3 +264,35 @@ For more information, see the > # Maintainers > > See [Maintainers.txt](Maintainers.txt). > + > +# Submodules > + > +Submodule in EDK II Platforms is allowed but submodule chain should be avoided > +as possible as we can. Currently EDK II Platforms contains the following > +submodules > + > +- Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi > + > +To get a full, buildable EDK II repository, use following steps of git command > + > +```bash > + git clone https://github.com/tianocore/edk2-platforms.git > + cd edk2-platforms > + git submodule update --init > + cd .. > +``` > + > +If there's update for submodules, use following git commands to get the latest > +submodules code. > + > +```bash > + cd edk2-platforms > + git pull > + git submodule update > +``` > + > +Note: When cloning submodule repos, '--recursive' option is not recommended. > +EDK II Platforms itself will not use any code/feature from submodules in above > +submodules. So using '--recursive' adds a dependency on being able to reach > +servers we do not actually want any code from, as well as needlessly > +downloading code we will not use. > diff --git a/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi b/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi > new file mode 160000 > index 000000000000..ac5e821d50be > --- /dev/null > +++ b/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi > @@ -0,0 +1 @@ > +Subproject commit ac5e821d50be631f26274765a59bc1b444ffd862 > -- > 2.26.1 >