From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io, glin@suse.com, lersek@redhat.com,
liming.gao@intel.com
Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics
Date: Thu, 21 May 2020 14:16:44 +0100 [thread overview]
Message-ID: <20200521131644.GT1923@vanye> (raw)
In-Reply-To: <de3d4703-f374-c0d6-e871-76b9f45d9753@arm.com>
On Thu, May 21, 2020 at 14:58:56 +0200, Ard Biesheuvel wrote:
> > Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> > Thanks!
> >
>
> Apparently, GCC 10 is getting fixed so that we can set a #pragma in
> MdePkg/Include/AArch64/ProcessorBind.h, and be done with it.
>
> That does mean you would need GCC 10.2 at least, or you get the error,
> unless we merge this patch as well. That would mean the intrinsics are never
> used in practice, but using a compiler that does use them will not break the
> build.
>
> I am leaning towards omitting this patch, but I could be convinced to adopt
> both mitigations. But the #pragma is strongly preferred.
What is the codesize impact on a full RELEASE image?
If non-negligable, how about #ifdefing the whole content out unless
some specific preprocessor flag is passed? Then at least there's a
quick workaround for anyone who needs it.
/
Leif
next prev parent reply other threads:[~2020-05-21 13:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:44 [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics Ard Biesheuvel
2020-05-20 12:37 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-21 16:40 ` Philippe Mathieu-Daudé
2020-05-21 16:45 ` Ard Biesheuvel
2020-05-21 16:59 ` Philippe Mathieu-Daudé
2020-05-21 17:02 ` Ard Biesheuvel
2020-05-21 17:07 ` Philippe Mathieu-Daudé
2020-05-20 15:59 ` Laszlo Ersek
2020-05-21 11:23 ` Leif Lindholm
2020-05-21 12:58 ` [edk2-devel] " Ard Biesheuvel
2020-05-21 13:16 ` Leif Lindholm [this message]
2020-05-21 13:31 ` Ard Biesheuvel
2020-05-21 14:16 ` Leif Lindholm
2020-05-21 20:22 ` Laszlo Ersek
2020-05-22 8:16 ` Ard Biesheuvel
2020-05-22 10:54 ` Leif Lindholm
2020-05-22 13:27 ` Ard Biesheuvel
2020-05-22 19:04 ` Laszlo Ersek
2020-06-02 0:50 ` Liming Gao
2020-06-02 7:09 ` Ard Biesheuvel
2020-05-28 1:36 ` Gary Lin
2020-05-28 9:49 ` Leif Lindholm
2020-05-28 15:48 ` Liming Gao
2020-05-28 20:09 ` Laszlo Ersek
2020-05-29 3:04 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521131644.GT1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox