public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tomas Pilar (tpilar)" <Tomas.Pilar@arm.com>
To: <devel@edk2.groups.io>
Cc: <nd@arm.com>, Ray Ni <ray.ni@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>
Subject: [PATCH v2 0/6] Standalone AcpiView Application
Date: Thu, 21 May 2020 19:44:15 +0100	[thread overview]
Message-ID: <20200521184421.2222-1-Tomas.Pilar@arm.com> (raw)

This patchset adds a new application module to the 
ShellPkg with the functionality of the 'acpiview' command.

The existing code is tidied and a clean boundary between
the UEFI shell command wrapper and the acpiview functionality
is created. Then, a new application wrapper is added.

The motivation for a standalone AcpiView application lies
in the desire to test implementation of the Acpi tables on 
a wide selection of platforms, particularly platforms still
in development, platforms that might have an older implementation
of the UEFI shell or platforms that might not include the 'acpiview'
command in the internal build of the UEFI shell. Furthermore,
this application can then be integrated in larger firmware
testing frameworks.

---

v2: Patch formatting

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>

Tomas Pilar (6):
  ShellPkg/AcpiView: Move log reset to main method
  ShellPkg/AcpiView: Refactor configuration
  ShellPkg/AcpiView: Move table count reset
  ShellPkg/AcpiView: Move parameter parsing
  ShellPkg/AcpiView: Refactor DumpAcpiTableToFile
  ShellPkg/AcpiView: Add application wrapper

 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c                               | 189 ++++++++++++++++++++++++++++
 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf                             |  31 +++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c               |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c                      | 469 +++++-----------------------------------------------------------------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h                      | 113 +++--------------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c                | 246 +++++++++++++++++++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h                | 177 +++++++++++++++++++++++++++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c       |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c       |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c       |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c       |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c       |   1 +
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c   | 276 ++++++++++++++++++++++++++++++++++++++++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.h   |  27 +++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf |  32 ++---
 ShellPkg/ShellPkg.dsc                                                        |   6 +-
 17 files changed, 1017 insertions(+), 556 deletions(-)
 create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c
 create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h

-- 
2.24.1.windows.2



             reply	other threads:[~2020-05-21 18:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 18:44 Tomas Pilar (tpilar) [this message]
2020-05-21 18:44 ` [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method Tomas Pilar (tpilar)
2020-06-12  2:40   ` Gao, Zhichao
2020-05-21 18:44 ` [PATCH v2 2/6] ShellPkg/AcpiView: Refactor configuration Tomas Pilar (tpilar)
2020-06-12  2:40   ` Gao, Zhichao
2020-05-21 18:44 ` [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset Tomas Pilar (tpilar)
2020-06-12  2:40   ` [edk2-devel] " Gao, Zhichao
2020-05-21 18:44 ` [PATCH v2 4/6] ShellPkg/AcpiView: Move parameter parsing Tomas Pilar (tpilar)
2020-06-12  2:40   ` [edk2-devel] " Gao, Zhichao
2020-05-21 18:44 ` [PATCH v2 5/6] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile Tomas Pilar (tpilar)
2020-06-12  2:41   ` [edk2-devel] " Gao, Zhichao
2020-05-21 18:44 ` [PATCH v2 6/6] ShellPkg/AcpiView: Add application wrapper Tomas Pilar (tpilar)
2020-06-12  2:41   ` [edk2-devel] " Gao, Zhichao
2020-06-15 11:57     ` Tomas Pilar (tpilar)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200521184421.2222-1-Tomas.Pilar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox