From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Wasim Khan <wasim.khan@oss.nxp.com>,
devel@edk2.groups.io, meenakshi.aggarwal@nxp.com,
vabhav.sharma@nxp.com, V.Sethi@nxp.com, jon@solid-run.com,
Wasim Khan <wasim.khan@nxp.com>
Subject: Re: [PATCH edk2-platforms 00/16] Add PCIe Support
Date: Fri, 22 May 2020 11:58:53 +0100 [thread overview]
Message-ID: <20200522105853.GZ1923@vanye> (raw)
In-Reply-To: <8e8d0ede-17e6-bbb1-2b3a-ea420933c62b@arm.com>
On Fri, May 22, 2020 at 11:46:07 +0200, Ard Biesheuvel wrote:
> On 5/22/20 1:02 AM, Wasim Khan wrote:
> > From: Wasim Khan <wasim.khan@nxp.com>
> >
> > Add PCIe Support for NXP Layerscape SoC which supports
> > different PCIe controllers.
> > Use generic PCIe drivers and wire up PciHostBridgeLib,
> > PciSegmentLib and PciCpuIo2Dxe driver for controller
> > specific implementation.
> >
>
> Thanks. This is looking good. Please take a look at the feedback, and give
> others some time to respond as well.
>
> In the meantime, I think we can simply merge #14 and #16 right away (unless
> Leif has any objections)
(Looking at those two out of order.)
16, sure.
14 - is there any reason to do so before there is PCI to connect
network devices through?
/
Leif
>
> > Wasim Khan (16):
> > Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.
> > Silicon/NXP: LS1043A: Define PCIe related PCDs
> > Silicon/NXP: Implement PciHostBridgeLib support
> > Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS
> > Ctrl
> > Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU
> > Windows
> > Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451
> > Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows
> > Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows
> > Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller
> > Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS
> > Controller
> > Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller
> > Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264
> > Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver
> > Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
> > Platform/NXP: LS1043aRdbPkg: Enable PCIE support
> > Platform/NXP: LS1043aRdbPkg : Increase fv image size
> >
> > Silicon/NXP/NxpQoriqLs.dec | 13 +
> > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 8 +
> > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 20 +
> > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 20 +-
> > Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf | 40 +
> > .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 45 ++
> > .../NXP/Library/PciSegmentLib/PciSegmentLib.inf | 36 +
> > Silicon/NXP/Include/Pcie.h | 231 ++++++
> > Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c | 628 +++++++++++++++
> > .../Library/PciHostBridgeLib/PciHostBridgeLib.c | 842 +++++++++++++++++++++
> > Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c | 699 +++++++++++++++++
> > 11 files changed, 2579 insertions(+), 3 deletions(-)
> > create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
> > create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> > create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
> > create mode 100755 Silicon/NXP/Include/Pcie.h
> > create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
> > create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
> > create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c
> >
>
next prev parent reply other threads:[~2020-05-22 10:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 23:02 [PATCH edk2-platforms 00/16] Add PCIe Support Wasim Khan
2020-05-21 23:02 ` [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs Wasim Khan
2020-05-22 9:12 ` Ard Biesheuvel
2020-05-24 18:31 ` Wasim Khan (OSS)
2020-05-26 6:16 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 02/16] Silicon/NXP: LS1043A: Define " Wasim Khan
2020-05-21 23:02 ` [PATCH edk2-platforms 03/16] Silicon/NXP: Implement PciHostBridgeLib support Wasim Khan
2020-05-22 9:20 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 04/16] Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS Ctrl Wasim Khan
2020-05-22 9:22 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 05/16] Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU Windows Wasim Khan
2020-05-22 9:24 ` Ard Biesheuvel
2020-05-24 18:31 ` Wasim Khan (OSS)
2020-05-21 23:02 ` [PATCH edk2-platforms 06/16] Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451 Wasim Khan
2020-05-21 23:02 ` [PATCH edk2-platforms 07/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows Wasim Khan
2020-05-22 9:33 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 08/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows Wasim Khan
2020-05-22 9:31 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller Wasim Khan
2020-05-22 9:29 ` Ard Biesheuvel
2020-05-24 18:32 ` Wasim Khan (OSS)
2020-05-25 4:30 ` Jon Nettleton
2020-05-25 15:21 ` Wasim Khan (OSS)
2020-05-21 23:02 ` [PATCH edk2-platforms 10/16] Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS Controller Wasim Khan
2020-05-22 9:36 ` Ard Biesheuvel
2020-05-24 18:32 ` Wasim Khan (OSS)
2020-05-21 23:02 ` [PATCH edk2-platforms 11/16] Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller Wasim Khan
2020-05-22 9:38 ` Ard Biesheuvel
2020-05-24 18:32 ` Wasim Khan (OSS)
2020-05-21 23:02 ` [PATCH edk2-platforms 12/16] Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264 Wasim Khan
2020-05-22 9:39 ` Ard Biesheuvel
2020-05-24 18:32 ` Wasim Khan (OSS)
2020-05-21 23:02 ` [PATCH edk2-platforms 13/16] Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver Wasim Khan
2020-05-22 9:42 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 14/16] Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg Wasim Khan
2020-05-22 9:42 ` Ard Biesheuvel
2020-05-21 23:02 ` [PATCH edk2-platforms 15/16] Platform/NXP: LS1043aRdbPkg: Enable PCIE support Wasim Khan
2020-05-21 23:02 ` [PATCH edk2-platforms 16/16] Platform/NXP: LS1043aRdbPkg : Increase fv image size Wasim Khan
2020-05-22 9:44 ` Ard Biesheuvel
2020-05-22 9:46 ` [PATCH edk2-platforms 00/16] Add PCIe Support Ard Biesheuvel
2020-05-22 10:58 ` Leif Lindholm [this message]
2020-05-24 18:32 ` Wasim Khan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522105853.GZ1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox