From: graeme.gregory@linaro.org
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
Radoslaw Biernacki <rad@semihalf.com>,
Tanmay Jagdale <tanmay.jagdale@linaro.org>
Subject: Re: [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup
Date: Sat, 23 May 2020 21:49:20 +0100 [thread overview]
Message-ID: <20200523204902.GA23028@xora-xps13> (raw)
In-Reply-To: <20200522233944.6845-1-leif@nuviainc.com>
On Sat, May 23, 2020 at 12:39:41AM +0100, Leif Lindholm wrote:
> The SbsaQemu platform port has been in flight for a long time now,
> so to facilitate getting it merged, here is a set of proposed layout
> changes and minor tweaks that I would prefer to have included.
>
> I also propose changing the commit message as follows:
> ---
> SbsaQemu: add port for SbsaQemu platform
>
> From: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
>
> The QEMU sbsa-ref platform provides an SBSA-compliant platform,
> providing EL3/EL2 support, non-virtio inerfaces, etc. This patch adds
> initial support for this platform.
>
> We are using FDF to compose EFI flash images with TF-A images.
> Flash0 (secure) is used by BL1 and FIP (BL2 + BL31).
> Flash1 contains EFI code and EFI variables.
>
> Signed-off-by: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> ---
>
> If Graeme, Radek, or Tanmay acks this set, I will squash this into the
> v4 SbsaQemu patch and push it.
>
Looks all good to me.
Acked-by: Graeme Gregory <graeme.gregory@linaro.org>
> Leif Lindholm (3):
> Silicon/Qemu: mirror Platform layout
> Silicon/Qemu: clean up SbsaQemu.dec
> Maintainers.txt: update format
>
> Maintainers.txt | 23 ++++++++-----------
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 8 +++----
> Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 2 +-
> .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 0
> .../SbsaQemuPlatformDxe.inf | 2 +-
> .../Library/SbsaQemuLib/SbsaQemuHelper.S | 0
> .../Library/SbsaQemuLib/SbsaQemuLib.c | 0
> .../Library/SbsaQemuLib/SbsaQemuLib.inf | 2 +-
> .../Library/SbsaQemuLib/SbsaQemuMem.c | 0
> .../SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c | 0
> .../SbsaQemuNorFlashLib.inf | 0
> .../SbsaQemuPciHostBridgeLib.c | 0
> .../SbsaQemuPciHostBridgeLib.inf | 0
> .../SbsaQemu.dec} | 3 ---
> 14 files changed, 16 insertions(+), 24 deletions(-)
> rename Silicon/Qemu/{ => SbsaQemu}/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf (92%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuLib/SbsaQemuHelper.S (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuLib/SbsaQemuLib.c (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuLib/SbsaQemuLib.inf (92%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuLib/SbsaQemuMem.c (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.inf (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c (100%)
> rename Silicon/Qemu/{ => SbsaQemu}/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.inf (100%)
> rename Silicon/Qemu/{SbsaQemuPkg.dec => SbsaQemu/SbsaQemu.dec} (93%)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-05-23 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 23:39 [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup Leif Lindholm
2020-05-22 23:39 ` [FIXUPS edk2-platforms 1/3] Silicon/Qemu: mirror Platform layout Leif Lindholm
2020-05-25 12:50 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-22 23:39 ` [FIXUPS edk2-platforms 2/3] Silicon/Qemu: clean up SbsaQemu.dec Leif Lindholm
2020-05-22 23:39 ` [FIXUPS edk2-platforms 3/3] Maintainers.txt: update format Leif Lindholm
2020-05-23 20:49 ` graeme.gregory [this message]
2020-05-25 12:53 ` [edk2-devel] [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup Philippe Mathieu-Daudé
2020-05-25 16:14 ` Radosław Biernacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523204902.GA23028@xora-xps13 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox