From: "Leif Lindholm" <leif@nuviainc.com>
To: Ming Huang <huangming23@huawei.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org,
lidongzhan@huawei.com, songdongkuang@huawei.com,
wanghuiqiang@huawei.com, qiuliangen@huawei.com
Subject: Re: [RFC edk2-platforms v1 0/3] Improve D0x
Date: Tue, 26 May 2020 19:09:20 +0100 [thread overview]
Message-ID: <20200526180920.GO1923@vanye> (raw)
In-Reply-To: <1590072184-16219-1-git-send-email-huangming23@huawei.com>
On trying to build the resulting output, I found the build breaks with
/work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:
In function ‘FlashFvbInitialize’:
/work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:1231:20:
error: ‘gEfiEventVirtualAddressChangeGuid’ undeclared (first use in
this function); did you mean ‘EfiSetVirtualAddressMap’?
&gEfiEventVirtualAddressChangeGuid,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
EfiSetVirtualAddressMap
The error would appear identical to that resolved by
commit a327627dd3f9edc113b1de6d897222d0517834db
Could you please provide a corresponding fix?
Best Regards,
Leif
On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote:
> Main Changes:
> Add update sas address feature in AcpiPlatformDxe.
>
> Ming Huang (3):
> Silicon/Hisilicon: Change updating dsdt in ready to boot event
> Silicon/Hisilicon/Acpi: Add update sas address feature
> Silicon/Hisilicon: Rename EthMac files
>
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 62 +-
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 +-
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 500 ----------------
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h | 16 -
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c | 612 ++++++++++++++++++++
> Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h | 16 +
> 6 files changed, 689 insertions(+), 525 deletions(-)
> delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c
> delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h
> create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c
> create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h
>
> --
> 2.8.1
>
next prev parent reply other threads:[~2020-05-26 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 14:43 [RFC edk2-platforms v1 0/3] Improve D0x Ming Huang
2020-05-21 14:43 ` [RFC edk2-platforms v1 1/3] Silicon/Hisilicon: Change updating dsdt in ready to boot event Ming Huang
2020-05-26 17:40 ` Leif Lindholm
2020-05-27 11:38 ` Ming Huang
2020-05-21 14:43 ` [RFC edk2-platforms v1 2/3] Silicon/Hisilicon/Acpi: Add update sas address feature Ming Huang
2020-05-26 18:49 ` Leif Lindholm
2020-05-27 14:21 ` Ming Huang
2020-05-21 14:43 ` [RFC edk2-platforms v1 3/3] Silicon/Hisilicon: Rename EthMac files Ming Huang
2020-05-26 18:50 ` Leif Lindholm
2020-05-27 14:22 ` Ming Huang
2020-05-26 18:09 ` Leif Lindholm [this message]
2020-05-27 14:31 ` [RFC edk2-platforms v1 0/3] Improve D0x Ming Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526180920.GO1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox