From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.1099.1590516564060454381 for ; Tue, 26 May 2020 11:09:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uCqUhVs2; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id u12so463721wmd.3 for ; Tue, 26 May 2020 11:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EGsOR3wnwOjUYok5JAzEIUrD3/VxntT22uTfYcjyPVg=; b=uCqUhVs2mg+Yi4DsbNoJu/f4eC+BNYTsLHZryxYyRTrWrSpwuk4yIsC+8NCcj8jiq8 FPGzzzuJybgiPAnXeSJLgE/IXS+OTkDKrSMtQ1wnBWKiRaVOTINhn08QdN60ytizMb64 rsCUoiHorE4rTkF3TQ4i8z/+nJCcje9GAaM7flouS2kTlChTeySKUMgkU1pipjK5Fumr WcXvre1uqaNAuLDv8NqtpapmynKukeuI5eQPU/HjKTof9v4vxYltNXr/fFNns0rgXbgu HLZX134GAJUa1Svov7GWI9yVx14iIca3N0uHBo3wiTjDzvpxUB+DyaGYkAml7SlWRFjK USpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EGsOR3wnwOjUYok5JAzEIUrD3/VxntT22uTfYcjyPVg=; b=PzTuePM0+G3Q7/2/DHAvG+nGYXt4DvXwGLg6EJG/1sfiiuyzboCTvo07f/wr0zfb/i 2X2rDktV4mH4NxmNcNeXtgCFTgptzNpvI7kfBkxBbdEuPq85GpnkxD4A24mHyocrRSKZ jRFDE+bk21roFNORkWwBcPVeCwX4V5SDe6yten1Vn7WjfnD+VcFETyBWXQ2wZs+S0qDE z5QuDSGdkVDeJ6t0+U3AXZiGhHVHU/ixz8vIyMY93IP/XzHOKId1Ov0fJAEBrNNbFpUY rGAD4HrIassf+Gndq0FRH+i8BA/M8fdM1O177BWPhJz85UFukpU+fdSsPF2H+2C2r2l3 uqRQ== X-Gm-Message-State: AOAM5318jepW9rnIQ8DqadaOZLRvj6LJEiM8vcljLKXoTxRtaYoMXHLy R2gUfX0U/e/KriEp+g6PF53R4A== X-Google-Smtp-Source: ABdhPJx0vItxmqSsxV/D61x7Q1uWWoXem/OS8Ayj8Pys6huFed69THC3KtiE1MlhX0lnoGOAgDo3LA== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr427245wmh.31.1590516562654; Tue, 26 May 2020 11:09:22 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id v22sm265948wml.21.2020.05.26.11.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 11:09:22 -0700 (PDT) Date: Tue, 26 May 2020 19:09:20 +0100 From: "Leif Lindholm" To: Ming Huang Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, lidongzhan@huawei.com, songdongkuang@huawei.com, wanghuiqiang@huawei.com, qiuliangen@huawei.com Subject: Re: [RFC edk2-platforms v1 0/3] Improve D0x Message-ID: <20200526180920.GO1923@vanye> References: <1590072184-16219-1-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1590072184-16219-1-git-send-email-huangming23@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On trying to build the resulting output, I found the build breaks with /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c: In function ‘FlashFvbInitialize’: /work/git/edk2-platforms/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.c:1231:20: error: ‘gEfiEventVirtualAddressChangeGuid’ undeclared (first use in this function); did you mean ‘EfiSetVirtualAddressMap’? &gEfiEventVirtualAddressChangeGuid, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ EfiSetVirtualAddressMap The error would appear identical to that resolved by commit a327627dd3f9edc113b1de6d897222d0517834db Could you please provide a corresponding fix? Best Regards, Leif On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote: > Main Changes: > Add update sas address feature in AcpiPlatformDxe. > > Ming Huang (3): > Silicon/Hisilicon: Change updating dsdt in ready to boot event > Silicon/Hisilicon/Acpi: Add update sas address feature > Silicon/Hisilicon: Rename EthMac files > > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 62 +- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 +- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 500 ---------------- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h | 16 - > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c | 612 ++++++++++++++++++++ > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h | 16 + > 6 files changed, 689 insertions(+), 525 deletions(-) > delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c > delete mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.h > create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.c > create mode 100644 Silicon/Hisilicon/Drivers/AcpiPlatformDxe/UpdateDsdt.h > > -- > 2.8.1 >