From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method
Date: Tue, 26 May 2020 21:49:40 +0100 [thread overview]
Message-ID: <20200526204940.GS1923@vanye> (raw)
In-Reply-To: <20200525182455.18481-1-ard.biesheuvel@arm.com>
On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote:
> The _EVT method on the ACPI0013 Generic Event device takes a single
> argument. Even though we are not interested in its value (given that
> there is only one interrupt source), we still have to declare the
> prototype correctly, or the OS might complain and refuse to call it.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 0ea8ce6d5f44..50f1753c3565 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> @@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
> MASK = 0xfffffeff
> }
>
> - Method (_EVT) {
> + Method (_EVT, 0x1) {
> REQC = 0x100
> Notify (\_SB.PWRB, 0x80)
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-26 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:24 [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method Ard Biesheuvel
2020-05-26 20:49 ` Leif Lindholm [this message]
2020-05-27 7:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526204940.GS1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox