From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web11.422.1590526184782857144 for ; Tue, 26 May 2020 13:49:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=vRaHgeVo; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id c71so971340wmd.5 for ; Tue, 26 May 2020 13:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUP281N79v18YQQVgL1QGbkf9N6vr0PlVxPd8PqxF18=; b=vRaHgeVonxvLdTVoEBPJjTN7qGJj4bVWKJ6w+chVK7uvYH3Zml+BYSSL5li/V83vYK SjCJko7TsouXFrltt0UTVdfhArbVeCLlWgNXTqY+E2Vo6Bi/uVWNOcfYaaggOmvAhYT4 Gpgv4UjNaQdDSQm/8u1Kxg36+D4sPg99Sn1jjsohPpkzgCnIpZXVchpjkkTxsNPBlwgL ZfMVlkc11onVw+yMU6e83C8MgUJ72PfgSvo5tHL11MMP7V/Zb0Gx04MYhAq5wk0n6eMt kwChbBeZEJZWI4TusDagOKOqxbFGHMfD3ISAj6sSUfKi/OMxLyQOGWwR9TSsogbXejxt KD8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUP281N79v18YQQVgL1QGbkf9N6vr0PlVxPd8PqxF18=; b=SkfSfQBmzfugyUkaXa6nYDUirtnc7oviiEvgXGdAfMOqP0R0pyJg0UcuW+4D89NN3J UilU4SIq7eNLSaSBLGSF6Dh66w9tLip5eFC3A7B1u0dhLMlRO68zx2NglgnRHFYHLT4o c8RwOKdqZ78/x2LgrLWi17d+wuHcaoOlwvxP/iZAsrz7eIjkbMiLk/KWaclKTcPr+5o2 TYc/hFH2tWdU9FwbII4GA/Mf7SEPvFW6lx6vhXXz1ITYpJufM2AwHFyZTWKxEWwGnWvX B5C/h+C5vP/i1ovV3DN+6IfjMf6ZeLuPVvrA8OSC3LVM6bY4O5HBrZGJNt0ZLHV7QEjg 8K7A== X-Gm-Message-State: AOAM531A+0I/eOxwgQ3d5hBlvHy1ZMOMEMDfUtb+LgsMf0/Jkkfw5Swv rnqcoMvOh7zB6JvI5FHEyHKwRw== X-Google-Smtp-Source: ABdhPJxALB4Nn2LEg4v5aBxVlkquEWk3rp8Itq7yMyjPe3DxKjzTi/W+u65AxK5Acc7KwSzvXSMJeQ== X-Received: by 2002:a7b:c0d9:: with SMTP id s25mr965177wmh.175.1590526183368; Tue, 26 May 2020 13:49:43 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id j135sm699384wmj.43.2020.05.26.13.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 13:49:42 -0700 (PDT) Date: Tue, 26 May 2020 21:49:40 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method Message-ID: <20200526204940.GS1923@vanye> References: <20200525182455.18481-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200525182455.18481-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote: > The _EVT method on the ACPI0013 Generic Event device takes a single > argument. Even though we are not interested in its value (given that > there is only one interrupt source), we still have to declare the > prototype correctly, or the OS might complain and refuse to call it. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > index 0ea8ce6d5f44..50f1753c3565 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > @@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", > MASK = 0xfffffeff > } > > - Method (_EVT) { > + Method (_EVT, 0x1) { > REQC = 0x100 > Notify (\_SB.PWRB, 0x80) > } > -- > 2.17.1 >