From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.groups.io with SMTP id smtpd.web12.639.1590528450129751120 for ; Tue, 26 May 2020 14:27:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=y4SOWRn7; spf=pass (domain: nuviainc.com, ip: 209.85.128.51, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f51.google.com with SMTP id j198so861740wmj.0 for ; Tue, 26 May 2020 14:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+yLIrfVgFYFJOgA9sET5vKItxZb4lRsl32Ad2+4AY1A=; b=y4SOWRn7eCiy3QV19kGg9mBdeE4VRUup4Yw2lCI2wEFHbGZGtSeoidOX1q07Ogppvs jYUbu3pzYREaDfoUv9MHWX0PpsVRRirUnMBvp947YTjAmV6A4I6bzbwc6ltYprlI2eR8 7u8yI68BjV+zSK1gW7yFc5ihN+gCGqMhXbKQF8PG1mt5+A5dDly0Vjtt00Y6Pvvsb3hv i6eY9yCmgVbDwXgg9qAu6qzHvT/hNrsNCDOPugNbcfm8HDOfFeVEoi5oAl1+ZV6bVMJh cBtT+A/9isg33J+BLBTx5pQpeeWNDSZyRUnkDhPA9BjPo+rqMrwLn9WXJ4fxvsJkUW+M GJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+yLIrfVgFYFJOgA9sET5vKItxZb4lRsl32Ad2+4AY1A=; b=st49h3/j8K0yDHw1ScV8fDjJ+5WWZb/0UaE6nEBKyyd2MbrELDSbWtJvtQ4j52uG+o aZ7VD/XChe3QR2osDVgT1Crq2USlDjmxahZtDr2qGIXrMHWqMfnOaogOILxXzMA0i2oQ hGtmlJEBHQG2voRfNO28fAgw9sgpu0EPH5z5ByCxGRIBZuwawdG9cRcOrEenDZDXS2ZW u4yiJ1OpYsjZBZRRByI3TWEd+/NJtBZ5yLT/L7dKV7T3/9jEvegw37h8sTwtnI42h+KV 9o4m1gelt/Qa2DSEeSV5sHmwGTmuwdciCrBzCiuGs8+sxvoVrH5PCj3O8YC8PjelcMUO +/TQ== X-Gm-Message-State: AOAM533Q77tugq56QIr6wY0oKtmlxPdgwt7LPnR+TSoW5lB2eSIqxtMd D76ypPnpPU2EAnagnm7KdHzmxRJchykwB9RrdzJDxlX7OWMaMZRWTymnbMe60mNwxhG/84ArQcR pcE0FE3+5nMmV2Fq9XKWwn7Ttrbo9p4eq/Kg4BTeFLK0Yj9ucA6otAZWuf8UTI91Yaw== X-Google-Smtp-Source: ABdhPJyi/Ib1VT5/6pvjFxb2mwcgsye2vaFlL8z0V5Yst8HWWPbKcqZ0/Ui5HvWyRQIvfwC96eOaow== X-Received: by 2002:a1c:80d4:: with SMTP id b203mr1066456wmd.138.1590528448461; Tue, 26 May 2020 14:27:28 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a21sm680471wmm.7.2020.05.26.14.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 14:27:27 -0700 (PDT) Date: Tue, 26 May 2020 22:27:25 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, ard.biesheuvel@arm.com Cc: jon@solid-run.com Subject: Re: [edk2-devel] [PATCH 3/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option Message-ID: <20200526212725.GU1923@vanye> References: <20200526161359.4810-1-ard.biesheuvel@arm.com> <20200526161359.4810-4-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200526161359.4810-4-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 26, 2020 at 18:13:57 +0200, Ard Biesheuvel wrote: > Without ConnectAll() being called on the boot path, the UEFI shell will > be entered with no block devices or anything else connected, and so for > the novice user, this is not a very accommodating environment. Now that > we have made the UiApp the last resort when on boot failure, and made > the UEFI Shell accessible directly via the 's hotkey if you really need Typo 's -> 's'. / Leif > it, let's hide it as an ordinary boot option. > > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index f91f7cd09ca1..b465f9ff388f 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -778,7 +778,7 @@ PlatformBootManagerAfterConsole ( > Key.ScanCode = SCAN_NULL; > Key.UnicodeChar = L's'; > PlatformRegisterFvBootOption ( > - &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key > + &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_HIDDEN, &Key > ); > } > > -- > 2.17.1 > > > >