From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m9a0014g.houston.softwaregrp.com (m9a0014g.houston.softwaregrp.com [15.124.64.90]) by mx.groups.io with SMTP id smtpd.web10.2773.1590572708690966635 for ; Wed, 27 May 2020 02:45:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.90, mailfrom: glin@suse.com) Received: FROM m9a0014g.houston.softwaregrp.com (15.121.0.191) BY m9a0014g.houston.softwaregrp.com WITH ESMTP; Wed, 27 May 2020 09:44:31 +0000 Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 27 May 2020 09:31:00 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.124.8.14) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Wed, 27 May 2020 09:31:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUUn2lQsWk7RoBTMPJlE/kD00bc6rUCe4H1PlR2c8vrS5l4qZdC6htHP+nOEUypC5ivGAZLarQFzCM2afZcBUE74joJqo+Q30V0nve/nN/Cm6qI4OXtpwAfzYoV4MzvKRy5YRiMvybsYV1mkNFHZO2dSYWzpdvZtGXpHpdSOkApPG6uvUcuRkEfitQjeYjN+L++fGtUIZthg/IpCzToyMRa1KdsJcwtZ48y8+6m4UHdWUwg8CRYjGixZMXAeMuGnSuGotokEfH5OQpaBr96wzxlXpbhhJjEgUzT+VF0J33RZLyw0l23BX0SorW5LgECYrQJba7mJowfbH8t+XlQQTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q7O2RcmSMDp0K2oRoJZhL70+/agYXDUBnCXyr8zIP5c=; b=cShPczLu1hx40YCh4AU7j+KDTv7oeE5Yt5cOP6gWqqSrFYzfN5gYX9vfPNOXEmKtpSd4f28p2NJcYSBS7n2AID1FNRaPufjwa5p78SjGEGSkiH4UqIWo3kv2ZDioK5djSq2/IPTepqSpLr1uw6gscDWL/36u/4LHzpOz7sVyT79d36g06SBDCQiAQbd2ZeD/0oG1dGH1zzxd2/giMdqp15lbIN5N3mudo40Te2q1Z3wDeIW+BVR+6MGhXSDrDZC39T+8dM3ggHRUNnrZaq96JzHLlicx4bTMbVp/tNMZeL7O10No97bpUNfVA/pv04FRV/0FfJGwKo39BbfZdrm28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=suse.com; Received: from SN1PR18MB2237.namprd18.prod.outlook.com (2603:10b6:802:24::17) by SN1PR18MB2270.namprd18.prod.outlook.com (2603:10b6:802:2f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Wed, 27 May 2020 09:30:59 +0000 Received: from SN1PR18MB2237.namprd18.prod.outlook.com ([fe80::a85d:80ef:1ad3:e8c4]) by SN1PR18MB2237.namprd18.prod.outlook.com ([fe80::a85d:80ef:1ad3:e8c4%7]) with mapi id 15.20.3021.030; Wed, 27 May 2020 09:30:59 +0000 Date: Wed, 27 May 2020 17:30:46 +0800 From: "Gary Lin" To: , CC: Leif Lindholm , Ard Biesheuvel , , , Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ Message-ID: <20200527093046.GD24379@GaryWorkstation> References: <20200522101202.15016-1-ard.biesheuvel@arm.com> <36effdcd-91a7-da00-855d-570e64d650b8@redhat.com> <5587f0f0-9f30-62ce-9d07-5eed4ac6daa7@arm.com> <20200526143725.GM1923@vanye> <0f2f90b9-e2fe-5658-e507-299a387e0ce5@redhat.com> In-Reply-To: <0f2f90b9-e2fe-5658-e507-299a387e0ce5@redhat.com> X-ClientProxiedBy: CWLP123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:88::18) To SN1PR18MB2237.namprd18.prod.outlook.com (2603:10b6:802:24::17) Return-Path: GLin@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryWorkstation (60.251.47.115) by CWLP123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:88::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Wed, 27 May 2020 09:30:56 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dd69b63-cb8d-4204-aa15-08d80220aa61 X-MS-TrafficTypeDiagnostic: SN1PR18MB2270: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 04163EF38A X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3jKKnIeDE50wO/9dbr4G+u/3MjZ4CcQG2fSO1onW1NBNM0vjKLZvmnD9XMv7jiHynXVYsMtoqpo6FX9AlitURFL/RmM0bUvOXXt3WmhCJKU8B/AAMW23MB4Mnrmy2DgDcoKphACvTn+3H10Y4OopZtQNSagKkc73REl4cJm85NaK09kdm7vC6a678tdrIgVVJkTeZNqypvFOuAPv/0tTHcn50UTYdm6YFaU+m9zaUyNWfRLHEgM99ILZfUvWQZaiKoRq5PMg6C9eZEWeqXDlj5vgMwH0WMR7lC4R6J5PYs4KK2hPnsVtMCaFq8GEhp3erTSiq9AN7B7VtxTVGPlrGzxWYsRTn3tjiQ3mL0bgk48joGbFcg+9/OCtPGkjaZo8YdwF01uKKbTbmPL+GiaHxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR18MB2237.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(39860400002)(366004)(136003)(376002)(66476007)(52116002)(66556008)(6666004)(9686003)(55236004)(33716001)(53546011)(186003)(5660300002)(6496006)(26005)(16526019)(54906003)(956004)(316002)(19627235002)(8676002)(55016002)(8936002)(66946007)(33656002)(4326008)(478600001)(966005)(2906002)(86362001)(1076003)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: bP9oQV8kRjg+p49zfJsXdCiPsj6lfJAp8TkvyRNJ+sW5C62j7Cw3vmulBMxPf3RJlFr9VzQDgtugbfiMQPtwbAfECMNDJrSbEJc8y7S6yKrBxcTbIbV3zBlT29MF10RAFY7ps1Di7imrLHXQm+RtiHBQyInR4nVyuFQLyyFrfpCWHLLzPOoyQyaSJjDj7ZCqcMVlZjWLNWNxO1q++xZB2baN2vQDKeNZbguSP8VHKZaCl4QpoHoS87kVd8nQkSRvSPEEinfL2I0OD07FisN6pd+B6mx09Ks4MT6eW3zHL6mODT+YcMzgYxOAI8XbNbEM5CjfeRw4p+9QX9cMvrQ7pkr2s9Ntu5rNY2l9tkPodqtoPQj9FrwkIXSFOVE/V3tsKpUyzRhUmGyxYKNa2FG31pI70txIcdCb+wik3ROu3YnArUDs4EWPtz2NpO5GmQSrn3+LPzNZqJgGrb+Ute8rfIbBdAV/bBKukyZAlbiy4xg= X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd69b63-cb8d-4204-aa15-08d80220aa61 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2020 09:30:59.7049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MZ09WmPpxR6u4tlADf4VMLoCHKqE231J6QRV0C1GaQQ3P7sD0ozWXujOfLfnMxMI X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR18MB2270 X-OriginatorOrg: suse.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, May 27, 2020 at 11:12:23AM +0200, Laszlo Ersek wrote: > On 05/26/20 16:37, Leif Lindholm wrote: > > On Sat, May 23, 2020 at 00:09:52 +0200, Ard Biesheuvel wrote: > >>>>> diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h > >>>>> index 896bf273ac7a..a3ca8f09e51c 100644 > >>>>> --- a/MdePkg/Include/AArch64/ProcessorBind.h > >>>>> +++ b/MdePkg/Include/AArch64/ProcessorBind.h > >>>>> @@ -24,6 +24,17 @@ > >>>>> #pragma pack() > >>>>> #endif > >>>>> +#if defined(__GNUC__) && !defined(__clang__) > >>>>> + > >>>>> +// > >>>>> +// Disable GCC outline atomics > >>>>> +// Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2723 > >>>>> +// > >>>>> +#if __GNUC__ > 10 || (__GNUC__ == 10 && __GNUC_MINOR__ >= 2) > >>>>> +#pragma GCC target "no-outline-atomics" > >>>>> +#endif > >>>>> +#endif > >>>>> + > >>>>> #if defined(_MSC_EXTENSIONS) > >>>>> // > >>>> > >>>> Reviewed-by: Laszlo Ersek > >>>> > >>>> But I think it should be merged later, after GCC 10.2 is out. > >>>> > >>>> (Obviously I don't "insist" that we follow this approach, I'm just OK > >>>> with it.) > >>> > >>> Oh and I think both this patch and the assembly language implementation > >>> for the atomics should be delayed after the stable tag. gcc-10 is a new > >>> toolchain; so even if we don't introduce a new toolchain tag such as > >>> GCC10 for it, whatever we do in order to make it work, that's feature > >>> enablement in my book. > >> > >> Works for me. By the time the next stable tag comes around, early adopters > >> that are now on GCC 10.1 will likely have moved to 10.2 by that time, and so > >> we may not need the assembly patch at all. > > > > I'm not ecstatic that we'll be releasing the first stable tag known to > > break with current toolchains. > > If this breakage affects "current toolchains", then why was > only reported on > 2020-May-19, four days into the soft feature freeze? > > > This isn't just affecting random crazies pulling latest toolchains > > down, but people using their distro defaults (native or cross). > > ... "people using their distro defaults" to *not* build upstream edk2 > until 2020-May-19, apparently. > openSUSE Tumbleweed is going to change the default gcc version to 10. I actually wrote a workaround patch to add "-mno-outline-atomics" and apply it conditionally in the rpm spec file. Anyway, we can live with the workaround, so it's not intolerant to me if the intrinsics patch is not included. > > I don't recall if 10.1 ended up being default in F32, but it was > > definitely included. In Arch, it does appear default. > > > > Debian/Ubuntu are unaffected in their stable releases. > > > > I agree it's a transitional issue, but I would really prefer to have > > the intrinsics included in the release. > > OK, let's delay the release then, by a few days. I agree the present > patch may qualify as a bugfix, but the other patch with the assembly > language intrinsics doesn't. If it's really that important to have in > the upcoming stable tag, then it's worth delaying the tag for. I'm fine > delaying the release for it; it wouldn't be without precedent. > > Also, I think Ard's assembly language patch needs a Tested-by from Gary > at the least (reporter of TianoCore#2723). Please reach out to him in > that thread. > > ... More precisely, please *ping* Gary for a Tested-by in that thread, > because Ard CC'd him from the start, and even credited Gary in the > commit message. > I thought the patch would be abondoned so didn't try it. Will test it soon. Cheers, Gary Lin > Thanks, > Laszlo > > > >