From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.3540.1590576211190841166 for ; Wed, 27 May 2020 03:43:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=r0bVtLdb; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id j16so11070232wrb.7 for ; Wed, 27 May 2020 03:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ORJB77GOQkEJv/oU2WWR29k+Kavrzu7OAkZRooAryVg=; b=r0bVtLdb+vPqx3PZGtVPCWwFAYJTH3iYIxzdu8YzKwELiKCYPEBQLGFypdm3gqO84I Ev9H7khcaOkqkJqKosmVVhhWimlZvMzz1AHyqS6y4Jp5CqUjqTfnQ9alcHRy5nPwfr88 SGevnsJSueiGFS1OvpSjVq4IQAkU9PJ3vRBDBfZFlxNMuF5AvY/0xZNsma9TbUnlOcKB TwVLY+6Cy+VgtFbjh49T1q6Ahp23Isih1d+jBExOBJ5G+JZGJaMVFevAhJgXO0BkTWDI DgYrVIOTxNVf/T18rF2Kn9PMgIsiGRObhitfQqr8DvylSu+rqjEx2Wai7NQw1P8spfx/ /f8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ORJB77GOQkEJv/oU2WWR29k+Kavrzu7OAkZRooAryVg=; b=S2ZvMewLNVtnR7yfUgMxgM4HGoRCiPmentg5lYUYdNgMu7UnT3cOd+s8s7+xO36HOD P2S1o5y+NPGliFb2JH579uGH1ad21qA/G6G5KMbrhnrpb74m2L6EI572aE2F6rLYRMnf 3mpny8RfF4AfhsW0hXx+iVE7k/dd/n/ZhsXTV5LK8FvxzsQfwGi9OqbsCuvx+WHA9ZMb H2+xlGqQTLCXBfNDdfuvfzRCSadu7iClzl7hi5/c8b1xMzHZkf64SIcWmRa+Omw5chXH sJ0KxYez6CLeRQfIMLox4ny1uIJJqQ3PuJQfh+nUv4QXjbDXQsY/MXLtIXbC2L1iuhkv 67Vw== X-Gm-Message-State: AOAM53350ZbiN0CbW2UbqctFsmdDRTaNIV+GcEcbPHKCRMY/mY+5kb9P wfoyqRsdpn7FOO0ewIFDtyfqaA== X-Google-Smtp-Source: ABdhPJydc5NI4dALoY+7/UNWgt3R9NAS2GGmOxgWyOflh470vDpn3AG2fOxfpB7TKMtV0xj1ELqMhQ== X-Received: by 2002:a05:6000:12c8:: with SMTP id l8mr23789990wrx.148.1590576209437; Wed, 27 May 2020 03:43:29 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id m6sm2484273wrq.5.2020.05.27.03.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 03:43:28 -0700 (PDT) Date: Wed, 27 May 2020 11:43:26 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao Subject: Re: [edk2-devel] [PATCH 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll() Message-ID: <20200527104326.GW1923@vanye> References: <20200526161359.4810-1-ard.biesheuvel@arm.com> <20200526220151.GV1923@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2020 at 07:35:18 +0200, Ard Biesheuvel wrote: > On 5/27/20 12:01 AM, Leif Lindholm via groups.io wrote: > > On Tue, May 26, 2020 at 18:13:54 +0200, Ard Biesheuvel wrote: > > > Currently, Armpkg's PlatformBootManagerLib connects all controller to > > > their drivers recursively, even if the active boot option does not > > > require it. There are some historical reasons for this, some of which are > > > being addressed in separate patches. > > > > > > This series addresses the way ArmPkg's PlatformBootManagerLib implementation > > > deals with the UEFI Shell and the UiApp: currently, the shell is always > > > added as an ordinary boot option, which will be started if no other boot > > > options can be started, or if it is the first one in the boot order. > > > > > > Once we remove the ConnectAll() call from PlatformBootManagerLib, those shells > > > will be launched without any block or other devices connected, which may > > > confuse novice users. So before doing so, let's make the handling a bit more > > > sane: > > > - add a 's' hotkey that enters the UEFI shell regardless of its priority > > > in the BootOrder - this shell will be entered with no devices connected > > > after patch #4 > > > - enter the UiApp as a last resort if no boot options can be started > > > - make the UEFI Shell boot option hidden, so it is not started by default > > > (only by hotkey or BootNext) > > > - remove the ConnectAll() call from PlatformBootManagerLib > > > - finally, add a plugin library for UiApp to expose the UEFI Shell via an > > > ordinary main menu option (this works around the fact that patch #3 will > > > result in the UEFI Shell disappearing from the Boot Manager list). > > > Entering the shell this way will resemble the old situation, given that > > > UiApp connects all devices and refreshes all boot options etc at launch. > > > > I get why this set was sent in isolation, but could we also discuss > > somewhat what we would plan to do with the edk2-platforms that make > > use of the ArmPkg PlatformBootManagerLib? > > > > Not attempting a fallback boot onto network is probably an acceptable > > change to pick up, but having an undocumented hotkey as the only way > > into a shell that now doesn't map devices could be a bit aggravating. > > > > It is not the only way, and it is not even the preferred way. Patch 5/5 adds > an option to the UiApp root menu to enter the UEFI Shell, in a way that is > independent from boot option handling. Since you enter UiApp first, all > handles will be connected and boot options refreshed as usual. > > In cases where you want to avoid this from happening, you can use the 's' > key to drop into a shell directly. Yes, that's exactly what I am referring to. But in order for the new (and I agree improved) functionality to be available, the new Shell library needs to be explicitly added to .dsc for the platforms affected. I want an active decision to be made about how that is going to happen, if it is going to happen, as part of the conversation about *this* set. Merging this and *then* looking into it makes for too harsh a break in behaviour. / Leif