From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.6191.1590586922026454586 for ; Wed, 27 May 2020 06:42:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=xq//wrJc; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id f5so3078784wmh.2 for ; Wed, 27 May 2020 06:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VKAqZNkFBYlsIbEoMudGnVLZxnoHhiSdkIObsKcOVaU=; b=xq//wrJcsxVJcr4c+W+Kbiz03ueDVVRUHE6Aw2mve1o5X/CxtLEW5Ecc2xNAROUPQJ jPfnMdbstmo/IRxcEWSQXSlBelVnuoQl6KQoYsWfszc0H8kROqqt7w9JaKi0bJdAFqGB zYWTdnCPRdEIU9cAjgmiMf1us0fTdZfjjtZa7cw0AUgSejv+GY+Zc7Z+YcH0fe9CabrV IggfyTq7exD6muAMoJ0yprNB53potCDi+D54C5iEDQwkZlMGP5HC+NHK6yictmSeeTJd cIPxQUDC0mhTJ+YvCJNBgOgyTUVZyDrRv3QqhW6xqmQDaL7tVNLfHpjuOQKDdb20RTFg ap7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VKAqZNkFBYlsIbEoMudGnVLZxnoHhiSdkIObsKcOVaU=; b=Ga6kU1DyCpKlVv50uKP7bFonGve7Gf1so78WtxKEWItQSPcJ1q8go9fbYQMnctPki8 uiS1YwAu3P+vMupYsce6RzwfpcWLJJA9rkS7v7Lbw1OfKoWUbLQhQw3Rvl5BDry3mwQS ceOiKhv6/tQwBXYNTMAytFoMBplD5THH9H7JQJONCRtT9Kq4Slvic9DyZi/eUQ71/HPo z7YoulTRFayGPky+Ih8MEenFViLH8J1JOuX+57Cs0pO3eNwdgJmWQgGJaHEVyjpalXwE VkhnghcvitlVOTCFIKpDv3UNURL9YIZfCTlCragZjrUXmW4/mO8zFT1HYZeI3DwXkNDI TrFQ== X-Gm-Message-State: AOAM530HXKC24EUOKS0KX3b8419foqFL3agPuvGEnKDbuy/pkFJlS+Ne zWO8huU+hmg7D6+qLO6T9lbaWQ== X-Google-Smtp-Source: ABdhPJxkku/Q3ylJtVKNFHf/LgQIuxdIqfYIPOWVM030Q/WA8vY3uPgXVH/wKlyawJjHiZFDdrxj7A== X-Received: by 2002:a1c:4c8:: with SMTP id 191mr4229241wme.14.1590586920437; Wed, 27 May 2020 06:42:00 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id o15sm2944754wrv.48.2020.05.27.06.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 06:41:53 -0700 (PDT) Date: Wed, 27 May 2020 14:41:51 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao Subject: Re: [edk2-devel] [PATCH 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll() Message-ID: <20200527134151.GX1923@vanye> References: <20200526161359.4810-1-ard.biesheuvel@arm.com> <20200526220151.GV1923@vanye> <20200527104326.GW1923@vanye> <8d729290-d703-bd98-17ab-9d06c7450398@arm.com> MIME-Version: 1.0 In-Reply-To: <8d729290-d703-bd98-17ab-9d06c7450398@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2020 at 12:50:53 +0200, Ard Biesheuvel wrote: > > > > Not attempting a fallback boot onto network is probably an acceptable > > > > change to pick up, but having an undocumented hotkey as the only way > > > > into a shell that now doesn't map devices could be a bit aggravating. > > > > > > > > > > It is not the only way, and it is not even the preferred way. Patch 5/5 adds > > > an option to the UiApp root menu to enter the UEFI Shell, in a way that is > > > independent from boot option handling. Since you enter UiApp first, all > > > handles will be connected and boot options refreshed as usual. > > > > > > In cases where you want to avoid this from happening, you can use the 's' > > > key to drop into a shell directly. > > > > Yes, that's exactly what I am referring to. But in order for the new > > (and I agree improved) functionality to be available, the new Shell > > library needs to be explicitly added to .dsc for the platforms affected. > > > > I want an active decision to be made about how that is going to > > happen, if it is going to happen, as part of the conversation about > > *this* set. Merging this and *then* looking into it makes for too > > harsh a break in behaviour. > > > > All existing platforms that incorporate ArmPkg's PlatformBootManagerLib must > add this NULL library class resolution to UiApp first. So once we agree that > this approach is acceptable (including the change to ShellPkg), I can > prepare a patch for edk2-platforms implementing this for all such platforms > living there. I suggest that we don't do the 3-way handshake here (edk2 pre, > edk2-platforms, edk2 post), given that the build won't break, it's just that > if you pull and build your platform right at the minute between merging the > edk2 changes and the edk2-platform ones, you will see the slightly > unintuitive behavior if you also happen to clear your Boot#### variables at > the same time. Yeah, that's fine with me. But I'd prefer that set to be ready to go immediately afer this one hits. (Insert generic note on benefit of *not* breaking the project up into ever increasing number of repositories.) Should I interpret this set more as RFC (in which case I may have slightly overreacted) than the PATCH it says in the subject line? / Leif