Re: SbsaQemu: Initial support for static ACPI tables

["Leif Lindholm" <leif@nuviainc.com>]

On Tue, May 26, 2020 at 14:16:52 +0100, Graeme Gregory wrote:
> On Mon, May 25, 2020 at 03:44:24AM +0530, Tanmay Jagdale wrote:
> > Add the following static ACPI tables for the SBSA Qemu platform
> >   - DSDT
> >   - FADT
> >   - GTDT
> >   - MADT
> 
> Comment below on MADT

...

> > +  {
> > +    // Format: EFI_ACPI_6_0_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags,
> > +    //                                          PmuIrq, GicBase, GicVBase,
> > +    //                                          GicHBase, GsivId, GicRBase)
> > +    // Note: The GIC Structure of the primary CPU must be the first entry
> > +    // (see note in 5.2.12.14 GICC Structure of ACPI v6.0).
> > +    EFI_ACPI_6_0_GICC_STRUCTURE_INIT( // A53-0
> > +        0, 0, GET_MPID(0, 0), EFI_ACPI_6_0_GIC_ENABLED, 23,
> > +        FixedPcdGet32 (PcdGicDistributorBase),
> > +        0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
> 
> Sometimes you stare at code so long you missed that this says A53 when
> SbsaQemu obviously uses A57 emulated cores.

SbsaQemu *currently* uses A57 emulated cores.
However, this is only a comment.
I guess, for now, when we're still hard-coding stuff, CPU-# would be a
better comment than A53-#.
I don't have any other comments on this.

/
    Leif