From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web10.173.1590615257634179164 for ; Wed, 27 May 2020 14:34:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=r+gXI24W; spf=pass (domain: nuviainc.com, ip: 209.85.128.44, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f44.google.com with SMTP id u188so1075625wmu.1 for ; Wed, 27 May 2020 14:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DHx7S0glI+NKQ/mKQnytTk6wbaf/j2urLpewDQB8LkM=; b=r+gXI24WUle2cL0WweMAlBKFC8hPLa4DRhc+YGHEQPW4/Z5CG+r16hZrRHzw7+58Mn 1FvmZzJ7BVJVUkd07uDwma89Fo3kM6BDvr6dkQNtfRsZODYSWfgEZJ0HPb9Z2xQJk6hQ UWllsnYdIKQC3XB2JSllVEEMAi6AoXxosyxiRUxGt36ldc7P2TE8bR4l/VPKYzXTqXDA W5fYid9cJF44+Yk1pDDeWAKMYQ8cpmDj0guY/SG4Oaaslz1UHDjqelqprpJTIUnsUpzL ZLrYkILtZx78yqijWhzcE2g/qtX6PLfyw3L5JbhN607uHtFqVkG2Hn/YqbTlSYMvupt3 CDgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DHx7S0glI+NKQ/mKQnytTk6wbaf/j2urLpewDQB8LkM=; b=Zjnqp6dD65n5Cd3iix+gwj7C/21oZyPgfm2VnUnzV7JA0aajHSXU7hVB2V7aeEN+eF L2ydiL6EUMrX9IryApPsO0mnDgWJnS0Aq0Gu8s4vjNERsqAkNaVVS4H23OiKRxV56Bn1 habySlHTh5K1Y/O3it92yQlCbR0EtHcffvI6JTpWgN+wnxwKKUMfL69rzxI00IJxjZDg 0rh3YP78NoLfI5Ys47a0Q1bS0xkjLsz0PUpnIMACX+4yHWLjN3sda5T3+qjZfIgs7nMQ byUvj/SiC8S6FeCnKyrMq9ei/fBvPXMKVmJAm4SguAMdRe5X8Lc/ACyEn8DhD++ArKYV EQ7g== X-Gm-Message-State: AOAM533RXygN3bMj/04AOc4gf5Dqaf+zCQplQdHJOjY5zTteHtayj7A5 EnoN83aPORvWt38xa0DnDJL5gA== X-Google-Smtp-Source: ABdhPJxBtST8DXwJDoTzoaeKJi6ahjd4k72E47fg9uuKn+utjXRWRjQ2if6YInla64aBzgCP1zDh8Q== X-Received: by 2002:a1c:b654:: with SMTP id g81mr119273wmf.128.1590615256165; Wed, 27 May 2020 14:34:16 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id w15sm3851516wmk.30.2020.05.27.14.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 14:34:15 -0700 (PDT) Date: Wed, 27 May 2020 22:34:13 +0100 From: "Leif Lindholm" To: Graeme Gregory Cc: Tanmay Jagdale , ard.biesheuvel@arm.com, devel@edk2.groups.io, jonathan.cameron@huawei.com Subject: Re: SbsaQemu: Initial support for static ACPI tables Message-ID: <20200527213413.GA1923@vanye> References: <20200524221424.209745-1-tanmay.jagdale@linaro.org> <20200526131652.GA28427@xora-monster> MIME-Version: 1.0 In-Reply-To: <20200526131652.GA28427@xora-monster> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 26, 2020 at 14:16:52 +0100, Graeme Gregory wrote: > On Mon, May 25, 2020 at 03:44:24AM +0530, Tanmay Jagdale wrote: > > Add the following static ACPI tables for the SBSA Qemu platform > > - DSDT > > - FADT > > - GTDT > > - MADT > > Comment below on MADT ... > > + { > > + // Format: EFI_ACPI_6_0_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, > > + // PmuIrq, GicBase, GicVBase, > > + // GicHBase, GsivId, GicRBase) > > + // Note: The GIC Structure of the primary CPU must be the first entry > > + // (see note in 5.2.12.14 GICC Structure of ACPI v6.0). > > + EFI_ACPI_6_0_GICC_STRUCTURE_INIT( // A53-0 > > + 0, 0, GET_MPID(0, 0), EFI_ACPI_6_0_GIC_ENABLED, 23, > > + FixedPcdGet32 (PcdGicDistributorBase), > > + 0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */), > > Sometimes you stare at code so long you missed that this says A53 when > SbsaQemu obviously uses A57 emulated cores. SbsaQemu *currently* uses A57 emulated cores. However, this is only a comment. I guess, for now, when we're still hard-coding stuff, CPU-# would be a better comment than A53-#. I don't have any other comments on this. / Leif