From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8610.1590657478729140927 for ; Thu, 28 May 2020 02:17:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDD0731B; Thu, 28 May 2020 02:17:55 -0700 (PDT) Received: from e123331-lin.nice.arm.com (unknown [10.37.8.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A87C3F6C4; Thu, 28 May 2020 02:17:53 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: jon@solid-run.com, Ard Biesheuvel , Laszlo Ersek , Leif Lindholm , Ray Ni , Zhichao Gao Subject: [PATCH v2 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll() Date: Thu, 28 May 2020 11:17:36 +0200 Message-Id: <20200528091741.14610-1-ard.biesheuvel@arm.com> X-Mailer: git-send-email 2.17.1 Currently, Armpkg's PlatformBootManagerLib connects all controllers to their drivers recursively, even if the active boot option does not require it. There are some historical reasons for this, some of which are being addressed in separate patches. This series addresses the way ArmPkg's PlatformBootManagerLib implementation deals with the UEFI Shell and the UiApp: currently, the shell is always added as an ordinary boot option, which will be started if no other boot options can be started, or if it is the first one in the boot order. Once we remove the ConnectAll() call from PlatformBootManagerLib, those shells will be launched without any block or other devices connected, which may confuse novice users. So before doing so, let's make the handling a bit more sane: - add a 's' hotkey that enters the UEFI shell regardless of its priority in the BootOrder - this shell will be entered with no devices connected after patch #4 - enter the UiApp as a last resort if no boot options can be started - make the UEFI Shell boot option inactive, so it is not started by default (only by hotkey or BootNext), but is still accessible via the UiApp boot manager menu - remove the ConnectAll() call from PlatformBootManagerLib Changes since v1: - add Laszlo's R-b to patches #1, #2 and #5, but omit it from #4, which has changed - make the generated boot option for the shell inactive but not hidden - this will prevent it from being selected by default - add a patch to deal with inactive boot options correctly, by not omitting them from the boot selection menu presented by the boot manager in UiApp - some commit log tweaks to fix typos and align the text with the above changes Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ray Ni Cc: Zhichao Gao Ard Biesheuvel (5): ArmPkg/PlatformBootManagerLib: register 's' as UEFI Shell hotkey ArmPkg/PlatformBootManagerLib: fall back to the UiApp on boot failure MdeModulePkg/BootManagerUiLib: show inactive boot options ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option ArmPkg/PlatformBootManagerLib: don't connect all devices on each boot .../PlatformBootManagerLib/PlatformBm.c | 35 +++++++++++-------- .../Library/BootManagerUiLib/BootManager.c | 4 +-- 2 files changed, 22 insertions(+), 17 deletions(-) -- 2.17.1