From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8613.1590657487223579891 for ; Thu, 28 May 2020 02:18:07 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9E1731B; Thu, 28 May 2020 02:18:06 -0700 (PDT) Received: from e123331-lin.nice.arm.com (unknown [10.37.8.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB0833F6C4; Thu, 28 May 2020 02:18:04 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: jon@solid-run.com, Ard Biesheuvel , Laszlo Ersek , Leif Lindholm , Ray Ni , Zhichao Gao Subject: [PATCH v2 5/5] ArmPkg/PlatformBootManagerLib: don't connect all devices on each boot Date: Thu, 28 May 2020 11:17:41 +0200 Message-Id: <20200528091741.14610-6-ard.biesheuvel@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200528091741.14610-1-ard.biesheuvel@arm.com> References: <20200528091741.14610-1-ard.biesheuvel@arm.com> In order to avoid boot delays from devices such as network controllers that may not even be involved in booting at all, drop the call to EfiBootManagerConnectAll () from the boot path. It will be called by UiApp, so when going through the menu, all devices will be connected as usual, but for the default boot, it is really not necessary so let's get rid of this. Enumerating all possible boot options and creating Boot#### variables for them is equally unnecessary in the default case, and also happens automatically in UiApp, so drop that as well. Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c index 1e9b736993d0..15c5cac1bea0 100644 --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -753,11 +753,6 @@ PlatformBootManagerAfterConsole ( } } - // - // Connect the rest of the devices. - // - EfiBootManagerConnectAll (); - // // On ARM, there is currently no reason to use the phased capsule // update approach where some capsules are dispatched before EndOfDxe @@ -767,11 +762,6 @@ PlatformBootManagerAfterConsole ( // HandleCapsules (); - // - // Enumerate all possible boot options. - // - EfiBootManagerRefreshAllBootOption (); - // // Register UEFI Shell // -- 2.17.1