From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.8897.1590660319609301983 for ; Thu, 28 May 2020 03:05:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=IadIvCsp; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id u13so2502138wml.1 for ; Thu, 28 May 2020 03:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ebnS6j3V2zP3U+WfH7ZjLl/Uo7lWko3Fd1yABKj+8io=; b=IadIvCspd/NkXi2hrGJISLPifAIFTHQZsGp6n13JMpqLJi0kvehPG0IItVWAwNDEOe 69LurNLlTSxaa3r4Rk2smljQSLSuVxxqVM2PS9pOEHbByyNdE9YvuyFT0kgN3WXriVoi Chyhx9i0xi0kP0X1RelLvlpshc+Cvz/A9ns34Bt8c441zvAeNpJ+n7pHpFCIDc5U9xmo 96DWp1uD74FrK+o8u16ZbrcY3ngEFvMzUCBiJwWgI2/9LEAjAWyLhaSo7ByfoNQDjBxN KxbQ9hB8ApZBiDgdDJrHuXINCUvcuEPbV9cKx1xjLzilRPB2e+23r7Bu6YAVYGQCwIXo Uvug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ebnS6j3V2zP3U+WfH7ZjLl/Uo7lWko3Fd1yABKj+8io=; b=LPLlEMwYcEv48EpMiSGJwCM8FFnu7OSa6ji27zECF2dJIDuwfAfeUCsqzGKk/uIk6a eD4aSPIv3k/fCZqPfULlvQPP7IGRh8k19v90E+IIxxaR9U3Ze2cwcSZ7ZW/VrJSlvWhz y9ApbzimZvGKfvAIdgl4dV/FAA6PTiXcTjnXbs691pcwwgaFnz728K2nM44rpJS6TLId 7B9/e9hiu7tjkBoiw58cCSmBRJ3C+D3+sA4yzbQJuWVupFT2k3K8n9NesRJqrAWCU20M 51RaKYio8nc8NWpf74puj6QSRF+g21EnaLI6bf/C1f/4pVtO/VSgcHqeoOmWDq4qaFXI KPOg== X-Gm-Message-State: AOAM532scSqZpuH10hbdsgkMrVHTyoHsWTX7VQaOCurO1i+T5OhnnJ3p pJsFk6+TDwqafd8le3OXfPMCdw== X-Google-Smtp-Source: ABdhPJxEJT8n3QXBjn9mcy/Ja2LYaVcqxUeNCTt6OLKd3MVJIecGCO0/tRR37MPJhsiuNgt4ffvyqw== X-Received: by 2002:a1c:2e16:: with SMTP id u22mr2857258wmu.168.1590660318035; Thu, 28 May 2020 03:05:18 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id d15sm5487811wrq.30.2020.05.28.03.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 03:05:17 -0700 (PDT) Date: Thu, 28 May 2020 11:05:15 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: Ard Biesheuvel , devel@edk2.groups.io, liming.gao@intel.com, philmd@redhat.com, mliska@suse.cz Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ Message-ID: <20200528100515.GC1923@vanye> References: <20200522101202.15016-1-ard.biesheuvel@arm.com> <36effdcd-91a7-da00-855d-570e64d650b8@redhat.com> <5587f0f0-9f30-62ce-9d07-5eed4ac6daa7@arm.com> <20200526143725.GM1923@vanye> <0f2f90b9-e2fe-5658-e507-299a387e0ce5@redhat.com> MIME-Version: 1.0 In-Reply-To: <0f2f90b9-e2fe-5658-e507-299a387e0ce5@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2020 at 11:12:23 +0200, Laszlo Ersek wrote: > >>> Oh and I think both this patch and the assembly language implementation > >>> for the atomics should be delayed after the stable tag. gcc-10 is a new > >>> toolchain; so even if we don't introduce a new toolchain tag such as > >>> GCC10 for it, whatever we do in order to make it work, that's feature > >>> enablement in my book. > >> > >> Works for me. By the time the next stable tag comes around, early adopters > >> that are now on GCC 10.1 will likely have moved to 10.2 by that time, and so > >> we may not need the assembly patch at all. > > > > I'm not ecstatic that we'll be releasing the first stable tag known to > > break with current toolchains. > > If this breakage affects "current toolchains", then why was > only reported on > 2020-May-19, four days into the soft feature freeze? I agree the timing is crap. > > This isn't just affecting random crazies pulling latest toolchains > > down, but people using their distro defaults (native or cross). > > ... "people using their distro defaults" to *not* build upstream edk2 > until 2020-May-19, apparently. Or distro defaults changing in between. I mean, we could say "Arch is the same as any other distro's unstable", but I wouldn't want to go down that route - I know people who use it for developing also for qemu and linux. Argh, I also just realised the error report I saw two days after Ard's intrinsics patch hit the list was not a public report. Yes, if this had affected only in-development/unstable distributions, I agree this isn't something we should try to deal with upstream. > > I don't recall if 10.1 ended up being default in F32, but it was > > definitely included. In Arch, it does appear default. > > > > Debian/Ubuntu are unaffected in their stable releases. > > > > I agree it's a transitional issue, but I would really prefer to have > > the intrinsics included in the release. > > OK, let's delay the release then, by a few days. I agree the present > patch may qualify as a bugfix, but the other patch with the assembly > language intrinsics doesn't. If it's really that important to have in > the upcoming stable tag, then it's worth delaying the tag for. I'm fine > delaying the release for it; it wouldn't be without precedent. I would argue it *is* a bugfix, since it only has an effect on builds that would otherwise fail. But I also do think it is important enough to delay the release if we feel that is necessary. / Leif > Also, I think Ard's assembly language patch needs a Tested-by from Gary > at the least (reporter of TianoCore#2723). Please reach out to him in > that thread. > > ... More precisely, please *ping* Gary for a Tested-by in that thread, > because Ard CC'd him from the start, and even credited Gary in the > commit message. > > Thanks, > Laszlo >