From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.44]) by mx.groups.io with SMTP id smtpd.web10.29220.1590731598038827419 for ; Thu, 28 May 2020 22:53:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=A2xn/NVY; spf=pass (domain: oss.nxp.com, ip: 40.107.13.44, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=npnxs/i0gPtawdENolYloMSr7pusEYPdSgNwkXs2mncHJCPOpQEm9PqhoIPZJHSltudosHnU1GSHxKygvqUxETvnEWydJio8JeltTUM+IMzv3GwicyTrvjeV9OteoRw3AVXh8N4DZ/3bUb/RzK9YuXk/czgl1zmwklyz13SbQiFsNlaI9gEh9EC8b9SrkbrnZFXOdtCFOOEzZnzFrELHSiUR0pOT5VLJ9UFRb5XehiotDCZCEy8iElhMdO4NoNI/lfELjsuzHWyOQID80armv5X+KUs/JuF8xYxp6k3oNVxkO+7C5Doq1gGcp4uy4M+znFEXTqDgg9OOyX/vvgJUOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjltZwDuoWAJPsWneq79tgn130GrqHGbYVtjhg/7FB8=; b=hp/sTaQ5m+0qepXV6DfA0+TCwG024rBURaynE5SoMg4FXkza7/ddNcU1bCISkYIdVVdBUq6hBjHJCmPuYmrTEh9tDsOdX0OdyOXskuxq7lk8ywbJvwsTT9pD6C6TG42609nInFfPJK47MtOUP9d4DdpkvYgadj9R/EeplcvQL3z1pfTQaCFaBlwCaX0DwDHQDBvMekmUoqMP+w9aFucZ66psd4qPn0Y7OlWC9WmU8ScH92yH/ACazmUBLavLYcqRb58G9JWg7KYyYIsuoaZ3+edy0yOjj5vzFFTD7pon94fqbq8I8uxQG99vVMuM/H6gyPxBXO3K9HHCubh8JKL77g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjltZwDuoWAJPsWneq79tgn130GrqHGbYVtjhg/7FB8=; b=A2xn/NVYOs/uaJSgQXDO6CB21k5NHZenWxaEEvH5e/I/C/dTRyUAWpGO+J+88LtwQipigdJYqwAFDi/KTPLwk2tKXG7vz7IEJJ6mFV/Fm8Qz3I+GtV5wfaFsH86ZYTcY/gfQ8YhPPbUi86EzMI27MUhuT5YHwaF5AhGrKuGdbvw= Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Fri, 29 May 2020 05:53:15 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.3045.018; Fri, 29 May 2020 05:53:15 +0000 From: "Pankaj Bansal" To: Leif Lindholm , Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: [PATCH edk2-platforms v3 03/10] Silicon/NXP/PciHostBridgeLib: Fix compilation with MDEPKG_NDEBUG flag Date: Fri, 29 May 2020 11:21:42 +0530 Message-ID: <20200529055149.30953-4-pankaj.bansal@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200529055149.30953-1-pankaj.bansal@oss.nxp.com> References: <20200529055149.30953-1-pankaj.bansal@oss.nxp.com> X-ClientProxiedBy: SG2PR01CA0112.apcprd01.prod.exchangelabs.com (2603:1096:4:40::16) To VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) Return-Path: pankaj.bansal@oss.nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.0.69) by SG2PR01CA0112.apcprd01.prod.exchangelabs.com (2603:1096:4:40::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Fri, 29 May 2020 05:53:12 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.0.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2b4430c3-eca6-461e-ac44-08d80394946c X-MS-TrafficTypeDiagnostic: VI1PR04MB5598: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:152; X-Forefront-PRVS: 04180B6720 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BLSSH3iTdbCjY9t9Tlpjs2ehLvgCLGzGLPdJrqtdUPbvDadbdMnw9EJX1fqFiVa/f1WiUoeeuqP/vPPA2nmMHPZSpooMtXkrnLQr2zi2cWjLiUGilMJCFdYyLPOYw+yjkGorP3FCp9GAUnE0+dlMf8V0hpbqUgBKEWNWwr5ZGLczgwldXEazTt+epLnMLgR6xOZDAA7Y633JD9EzJNveQG1uE0ZTEBNGK5PeskcR65Qq9RydPEu802SDNDSp5hVUklMLMvVoNnM+bKlTDwag2waaG8hwjXogSoaAhwJm24F4bKfYtSugBMLSL8CKhTtkjS+bC+sbHFZrJMY1k6DSYA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(136003)(39860400002)(396003)(376002)(346002)(110136005)(316002)(52116002)(66946007)(66476007)(66556008)(2906002)(6666004)(86362001)(1076003)(8936002)(5660300002)(8676002)(956004)(44832011)(2616005)(6486002)(6512007)(6506007)(16526019)(186003)(478600001)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: rJklelh7EoBhfMCn4TMy+7BAC8Wy5slI15C87pjGTijFFy7RRlTlmorECJylyLhuBiBosrXFXWWNGc94I8qt/m0mRvSjw4PAhoWDpKxRqPfCiYOOVgyqIlN4o1rzrnQacbowzcLvf3TGNVSUYFBSp1Jr+Lxj7BsU8fXnaCSaTXy9mpHP0MJACOJFePOcpFqLguyFv7fHlmoj+98EJglS+KOzR7e0AhzlsetLfxTl7GpoZkLcDYe359lLkLTrmDsinNZS2taVR//Vbexc88o6huqW/ZwQQvs93bCWfXNocdP8Tom2bejBkNmRYR3pV7OcRaYbgHKb/VXB3F/hDa7DG0uogHSgn/JPvzlQ7/xiM75Qao/iC1qT/KYzi2TwgTItcyYqGqh/WdDlezAaJKwk0LqSLRuDjUti6qrw7cZwgTWJqfACLDaTOyg0A/tVNMRJahyt2YgW1pWIi2kHZvib+Wxql9g0p+imCkHGL/shAfY= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4430c3-eca6-461e-ac44-08d80394946c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2020 05:53:15.6856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P5SioVCwNy/R/TDbdpYfdPs4oVnwnmS3aiQsfxxIuQDowOCFn5PNLi0hHr0EnpSZ7Qh1boZaiQ/EnbMkR3aiiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Pankaj Bansal when MDEPKG_NDEBUG flag is enabled, RELEASE build fails with this error: error: mPciHostBridgeLibAcpiAddressSpaceTypeStr defined but not used [-Werror=3Dunused-variable] Fix this error by protecting mPciHostBridgeLibAcpiAddressSpaceTypeStr with MDEPKG_NDEBUG macro. Suggested-by: Leif Lindholm Signed-off-by: Pankaj Bansal --- Notes: V3: - New commit Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Sili= con/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c index 549f4fa133fb..e5309a4f4248 100644 --- a/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c +++ b/Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c @@ -167,11 +167,13 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciR= ootBridgeDevicePath[] =3D { } }; =20 +#ifndef MDEPKG_NDEBUG STATIC GLOBAL_REMOVE_IF_UNREFERENCED CHAR16 *mPciHostBridgeLibAcpiAddressSpaceTypeStr[] =3D { L"Mem", L"I/O", L"Bus" }; +#endif =20 #define PCI_ALLOCATION_ATTRIBUTES EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PM= EM | \ EFI_PCI_HOST_BRIDGE_MEM64_DECODE --=20 2.17.1