From: "Leif Lindholm" <leif@nuviainc.com>
To: "Pankaj Bansal (OSS)" <pankaj.bansal@oss.nxp.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Varun Sethi <V.Sethi@nxp.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Jon Nettleton <jon@solid-run.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform
Date: Fri, 29 May 2020 12:49:29 +0100 [thread overview]
Message-ID: <20200529114929.GL1923@vanye> (raw)
In-Reply-To: <VI1PR04MB59336D34CD45D0A56A3110F3F18F0@VI1PR04MB5933.eurprd04.prod.outlook.com>
On Fri, May 29, 2020 at 05:21:24 +0000, Pankaj Bansal (OSS) wrote:
> > > ---
> > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > +++
> > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > @@ -19,9 +19,12 @@
> > > ArmPkg/ArmPkg.dec
> > > ArmPlatformPkg/ArmPlatformPkg.dec
> > > Silicon/NXP/NxpQoriqLs.dec
> > > + Silicon/NXP/Chassis3V2/Chassis3V2.dec
> > > + Silicon/NXP/LX2160A/LX2160A.dec
> >
> > Please insert alphabetically sorted.
>
> I intentionally kept these in this order. because Soc depends on Chassis for any include files
> Chassis depends on NxpQoriqLs.dec for any include files.
OK, I see the logic behind that, but as it has no functional meaning I
don't think it outweighs the benefit of alphabetical sorting.
I *do* tend to say "alphabetically, unless there is a better logical
order", but by that I usually mean grouping related Pcd dependency
declarations.
This is my only remaining niggle with this set - are you OK with me
folding in
--- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
+++ b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
@@ -18,9 +18,9 @@ [Packages]
MdeModulePkg/MdeModulePkg.dec
ArmPkg/ArmPkg.dec
ArmPlatformPkg/ArmPlatformPkg.dec
- Silicon/NXP/NxpQoriqLs.dec
Silicon/NXP/Chassis3V2/Chassis3V2.dec
Silicon/NXP/LX2160A/LX2160A.dec
+ Silicon/NXP/NxpQoriqLs.dec
to v3 9/10 and pushing the set?
/
Leif
> >
> > >
> > > [LibraryClasses]
> > > ArmLib
> > > + SocLib
> > > DebugLib
> >
> > Please insert alphabetically sorted.
>
> This I can take care
>
> >
> > No further comments on this set for v2.
> > For the patches I have not commented on:
> > Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> >
> > /
> > Leif
> >
> > >
next prev parent reply other threads:[~2020-05-29 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:51 [PATCH edk2-platforms v2 0/9] Add LX2160ARDB Platform Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 1/9] Silicon/NXP: Use Metronome implementation from MdeModulePkg Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 2/9] Platform/NXP: Use Monotonic counter " Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 3/9] Silicon/NXP: Use edk2 recommended compilation flags Pankaj Bansal
2020-05-28 14:48 ` Leif Lindholm
2020-05-27 8:51 ` [PATCH edk2-platforms v2 4/9] Platform/NXP/LX2160ARDB: Add ArmPlatformLib Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 5/9] Silicon/NXP: Implement PL011UartClockLib for NXP platforms Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 6/9] Silicon/NXP: Add Chassis3V2 Package Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 7/9] Silicon/NXP: Add LX2160A Soc package Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Pankaj Bansal
2020-05-28 15:00 ` Leif Lindholm
2020-05-29 5:21 ` Pankaj Bansal
2020-05-29 11:49 ` Leif Lindholm [this message]
2020-05-29 12:25 ` Pankaj Bansal
2020-05-29 14:03 ` Leif Lindholm
2020-05-30 12:19 ` Pankaj Bansal
2020-05-27 8:51 ` [PATCH edk2-platforms v2 9/9] Platform/NXP/LX2160aRdbPkg: Add VarStore Pankaj Bansal
2020-05-28 14:58 ` [PATCH edk2-platforms v2 0/9] Add LX2160ARDB Platform Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529114929.GL1923@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox