From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.32912.1590752973454339157 for ; Fri, 29 May 2020 04:49:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=b7C4SR2m; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id r7so3270215wro.1 for ; Fri, 29 May 2020 04:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yunw5WUiOUVeNRRkXUwWfyc44qmK78bCxX04YxUJDDw=; b=b7C4SR2mbe2qzd1JyXmicqOtlJd4BMz74fqOXTrHQ3eLAsFR4QQvCvA5A7wb5Is1SD c3/0tE5Q2bf9gz841v1Yoc3ZctpsmKwkcnHmE01wLq8EjOFr9Ue4OmkJflxJqKgR2MN9 u4OPMhrH0Vq+5IZSH4WERyhggJFIOYF13p75yv6XU5560LVI+CqQpKHpy1Eg7w391T2p mkdjMELX1OZLskM06gw0nsZRwgzCHOh3671fJ3EgQfpNOihSiCc1gpE+rJK04lBTI801 cS7dGl2laDg6d9AIqEAFl7imdFugGSpvnAAmsbYqxuh4RZW1EevRV1Ox0IIbpcDi7k+h HCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yunw5WUiOUVeNRRkXUwWfyc44qmK78bCxX04YxUJDDw=; b=mT4fAihJznJkfLsGr32pygEivQ2g+tZfRT3NVramsIZHmQuSM/xnLE+LXEao73+Jpn svI1HfdGOXmeC2fMVmg2I1Rl3n5KqvJOEF4SzgzVUOvLsQ687BHnI+Q8lJ4QNvgXjYX7 EdnN5DRr2X8G7waUhn6X2VctqUHtj0kPsgIdfICEpbnEjYGGG/g2vHoj3HhOW1lYc+Vs rOJyuQQ1AE5/AoXGkQtwObfiXJrXtwjayxs4O+GFNAhCeMyeEmbKYkh54nxl5ko1+L+S 2OaZbfbs5BUMDWx4bjtd80ALF6KYm/+8W2xLlKBIbv+FjRRENP7eyH7iKVDLENKX+PEF L2Qw== X-Gm-Message-State: AOAM533c52QJIaOTl9h8DnYJEpxRA+L9H9MVKXtCT79dWDtt0MaEj63Y Pn7uWbKSoGmV0T1FP0fTihqRVw== X-Google-Smtp-Source: ABdhPJxXsFk8EfFWvh8ueGmoQNajY++mBO6EhJWudf9nAJbs4Fqf5TBG3i91OsVqKIrnbmrJZ3OlqA== X-Received: by 2002:a5d:4ec3:: with SMTP id s3mr8965031wrv.103.1590752971750; Fri, 29 May 2020 04:49:31 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id b132sm11724411wmh.3.2020.05.29.04.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 04:49:31 -0700 (PDT) Date: Fri, 29 May 2020 12:49:29 +0100 From: "Leif Lindholm" To: "Pankaj Bansal (OSS)" Cc: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Message-ID: <20200529114929.GL1923@vanye> References: <20200527085135.16717-1-pankaj.bansal@oss.nxp.com> <20200527085135.16717-9-pankaj.bansal@oss.nxp.com> <20200528150051.GH1923@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 29, 2020 at 05:21:24 +0000, Pankaj Bansal (OSS) wrote: > > > --- > > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > +++ > > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > @@ -19,9 +19,12 @@ > > > ArmPkg/ArmPkg.dec > > > ArmPlatformPkg/ArmPlatformPkg.dec > > > Silicon/NXP/NxpQoriqLs.dec > > > + Silicon/NXP/Chassis3V2/Chassis3V2.dec > > > + Silicon/NXP/LX2160A/LX2160A.dec > > > > Please insert alphabetically sorted. > > I intentionally kept these in this order. because Soc depends on Chassis for any include files > Chassis depends on NxpQoriqLs.dec for any include files. OK, I see the logic behind that, but as it has no functional meaning I don't think it outweighs the benefit of alphabetical sorting. I *do* tend to say "alphabetically, unless there is a better logical order", but by that I usually mean grouping related Pcd dependency declarations. This is my only remaining niggle with this set - are you OK with me folding in --- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf +++ b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf @@ -18,9 +18,9 @@ [Packages] MdeModulePkg/MdeModulePkg.dec ArmPkg/ArmPkg.dec ArmPlatformPkg/ArmPlatformPkg.dec - Silicon/NXP/NxpQoriqLs.dec Silicon/NXP/Chassis3V2/Chassis3V2.dec Silicon/NXP/LX2160A/LX2160A.dec + Silicon/NXP/NxpQoriqLs.dec to v3 9/10 and pushing the set? / Leif > > > > > > > > [LibraryClasses] > > > ArmLib > > > + SocLib > > > DebugLib > > > > Please insert alphabetically sorted. > > This I can take care > > > > > No further comments on this set for v2. > > For the patches I have not commented on: > > Reviewed-by: Leif Lindholm > > > > / > > Leif > > > > >