From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.35177.1590760994805390014 for ; Fri, 29 May 2020 07:03:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=svTQxFs7; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id f5so3685913wmh.2 for ; Fri, 29 May 2020 07:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hwkkAzUk8U58Ac3yYA+WG+ub4bSOnp1P9cw0wm97yas=; b=svTQxFs7vc6/002ck7ObASx4aWBe4YX4NQ1Eus/viUWvm+WpPKq/U9TByE/ibQf0P0 qVImN9MXlV7xiEcbn+rrf7aiShD15I284Eta3xdC3bqPv98jIG3CvYgkGQrzfECux/KI hleOOYJRyWWCB0ZqNoh101Ur5ijwsoHIzDdeIrru3mvG/qGz8/fTioEaJaNVrMDngx/E GoWn/JW4KEShQJERF6gCdYkY8CTk0rv5zbgj0tcMR72Shteohj0S9wOKmymffpvDlXJ2 arWaqKxGuogdxuTJVNnJurEeTe4aPOCb//BwU7zzcBucofN7eJYf5kwE/NNM/+Uzod9b 0TTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hwkkAzUk8U58Ac3yYA+WG+ub4bSOnp1P9cw0wm97yas=; b=Qz60kyAs8lkWf+W9m6SRKQmxZZTuowqTfSqeDGsrh99Lsg6nTPiVPZbclwpd3Q4S9M vYbh80dqUMJRNovdY9bNRJBs1MgGNhw/oR5wxB0bbckEE56xvGun2g0z67+OX9jGANFK ppCafVuFH3LPsP41FrUxDrwvJvhldDZfVQ9zoszRfRTHGjit9nm8QcfQwo3KhdvZ1ZBO Z5wRbeqdeFXXm1PTJml1pUfppa3Szcl8EnXXU6GrZjKJtat+43WaUV5CWZlmUSm3XXJI Bs0ivFqKf2Z4Gs5dhSZW7Zp2LVQk0WLTkRhhDXXMME10WfyCGMLKRjY+YWyfPeOx0SeR E7ww== X-Gm-Message-State: AOAM530JgFPE9PKlzMofW/cOjXDVxYxAfBLflpBKnxg+X1Yh3qlUzOxH +KIPt0Wv+cMwOv1O/e5KUdnyFw== X-Google-Smtp-Source: ABdhPJzXhGsKcqADia85E77w0HLUKzhzTAmKFOQ5rJmFvgoepgkXmFeJvLct8gq73aqepbUdOh9GlA== X-Received: by 2002:a1c:230a:: with SMTP id j10mr8572358wmj.124.1590760993369; Fri, 29 May 2020 07:03:13 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a124sm12148053wmh.4.2020.05.29.07.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 07:03:12 -0700 (PDT) Date: Fri, 29 May 2020 15:03:10 +0100 From: "Leif Lindholm" To: "Pankaj Bansal (OSS)" Cc: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Message-ID: <20200529140310.GN1923@vanye> References: <20200527085135.16717-1-pankaj.bansal@oss.nxp.com> <20200527085135.16717-9-pankaj.bansal@oss.nxp.com> <20200528150051.GH1923@vanye> <20200529114929.GL1923@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 29, 2020 at 12:25:43 +0000, Pankaj Bansal (OSS) wrote: > > > I intentionally kept these in this order. because Soc depends on Chassis for any > > include files > > > Chassis depends on NxpQoriqLs.dec for any include files. > > > > OK, I see the logic behind that, but as it has no functional meaning I > > don't think it outweighs the benefit of alphabetical sorting. > > > > I referred to the inf specifications for this: > https://edk2-docs.gitbook.io/edk-ii-inf-specification/3_edk_ii_inf_file_format/37_-packages-_sections > > "Packages must be listed in the order that may be required for > specifying include path statements for a compiler. > For example, the MdePkg/MdePkg.dec file must be listed before the > MdeModulePkg/MdeModulePkg.dec file" I see that. (And sigh.) Clearly, that needs to be fixed. I have cc:d you on the patch to do that. I am sure that made sense when that text was originally written, which was presumably the previous millenium. But this is akin to "optimising" the order in which header files is included. > By design the Chassis package files can include generic NXP package > files. not the other way around. > same goes for SOC package files. SOC package files can include > Chassis Package file but not the other way around > and we can extend this further. any platform package files can > include SOC package files > > > I *do* tend to say "alphabetically, unless there is a better logical > > order", but by that I usually mean grouping related Pcd dependency > > declarations. > > as I mentioned above, there *is* a logical order to packages. And as I said "I see the logic behind that". I'm saying readability trumps that logic. > > > > This is my only remaining niggle with this set - are you OK with me > > folding in > > > > --- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > +++ > > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > @@ -18,9 +18,9 @@ [Packages] > > MdeModulePkg/MdeModulePkg.dec > > ArmPkg/ArmPkg.dec > > ArmPlatformPkg/ArmPlatformPkg.dec > > - Silicon/NXP/NxpQoriqLs.dec > > Silicon/NXP/Chassis3V2/Chassis3V2.dec > > Silicon/NXP/LX2160A/LX2160A.dec > > + Silicon/NXP/NxpQoriqLs.dec > > > > to v3 9/10 and pushing the set? > > > > / > > Leif