From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
Gilbert Chen <gilbert.chen@hpe.com>,
Abner Chang <abner.chang@hpe.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH v3 0/3] New RISC-V Patches
Date: Fri, 29 May 2020 19:06:19 +0200 [thread overview]
Message-ID: <20200529170622.32610-1-daniel.schaefer@hpe.com> (raw)
Hi Leif,
here's the new patchset addressing your latest comments.
The only thing that's not included is a deduplication of the SMBIOS code.
I expect that will require quite some thinking - I'm not yet sure how to do it.
I sent an answer to your reviews of the last comments, saying what I changed.
Quick summary here:
- Some changes, like the errors codes were split between two commits. This is
squashed now.
- Add typedefs for sbi structs to conform to EDK2 style
- Change some variables and functions to EDK2 camel case naming
- Change the last remaining `unsigned long` to UINTN
- Turn SbiCall{1,2,3,4,5,6} into vararg function
- Move the SbiCall function to the .c file
- Mark a0 as input/output in ecall inline asm
- Changed function names to readable longer names
The real changes are really only in 3/3 but I included the others as well for completeness.
Have a nice weekend!
- Daniel
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Daniel Schaefer (3):
ProcessorPkg/RiscVOpensbLib: Add opensbi submodule
ProcessorPkg/Library: Add RiscVOpensbiLib
ProcessorPkg/Library: Add RiscVEdk2SbiLib
Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf | 28 +
Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf | 52 ++
Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h | 81 ++
Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVEdk2SbiLib.h | 563 +++++++++++++
Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h | 75 ++
Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.c | 860 ++++++++++++++++++++
.gitmodules | 3 +
Readme.md | 36 +
Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi | 1 +
9 files changed, 1699 insertions(+)
create mode 100644 Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf
create mode 100644 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/IndustryStandard/RiscVOpensbi.h
create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVEdk2SbiLib.h
create mode 100644 Silicon/RISC-V/ProcessorPkg/Include/OpensbiTypes.h
create mode 100644 Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.c
create mode 100644 .gitmodules
create mode 160000 Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
--
2.26.1
next reply other threads:[~2020-05-29 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 17:06 Daniel Schaefer [this message]
2020-05-29 17:06 ` [PATCH v3 1/3] ProcessorPkg/RiscVOpensbLib: Add opensbi submodule Daniel Schaefer
2020-05-29 17:06 ` [PATCH v3 2/3] ProcessorPkg/Library: Add RiscVOpensbiLib Daniel Schaefer
2020-05-29 17:06 ` [PATCH v3 3/3] ProcessorPkg/Library: Add RiscVEdk2SbiLib Daniel Schaefer
2020-06-02 11:46 ` [edk2-devel] " Leif Lindholm
2020-06-02 15:53 ` Daniel Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529170622.32610-1-daniel.schaefer@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox