From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.12688.1590855493176285868 for ; Sat, 30 May 2020 09:18:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=K5qdc1sA; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id u26so8903093wmn.1 for ; Sat, 30 May 2020 09:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lH4OLGD00Qf4l2U/kLwh1HecYJQN2pbpui5sCf015No=; b=K5qdc1sA7pPs27fCrvGOd2JpsK8kehdAuUdeXaPtqI5Yt9/y32jjU6HBnWcVPqcAn6 TFaff3wK3/c0f40J6XYb9x5UIghpT5zZEGXlBMYhE7MzGBnbeFB36TuCGquJ9RSV1MmQ qdFZrn0umJ74WTxvKlnLIpy8WL/4wbuwgWbXlxaGOkdfStPEL43h7tmLgUCRSDbrZQ/9 ntrS+rcswFTACVXSJKA4aJansmtJEBVDVDDHeCmffdDvPWO0D4wNbmhkFUvKZ4Y1SBZc Sz6rADMRJeONXy4+sBpl++xzmnhKrvv0FDq1SYCkXo+SmQpIw02aFJv8dhUszGrtswZt m+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lH4OLGD00Qf4l2U/kLwh1HecYJQN2pbpui5sCf015No=; b=kIP7rTpsE9DPylq1ZQJBB40zDwqqojVC5ToWb5Zd9JqREqzqiPew1roP/Q6UCYPR0y LZkvn1e3tORsRORcnhsqaFK1RKki/vePaGMrxYSvWN+QmnPukHbio88YBcfoVeMFY1Uj d1p5Sm599a8ql951qz6K6n3u0dRarKGsEQtZ+7SEDcMQE+yFzMCIRZAW4qnpKiUwUvT0 aFWw6E0wTNVlrbIizimGj7wA/QCzGcS6/hfgMK4Y7VMBvQThC/uZ4IzYt0Lga+6CnERR uTzdMmsyVoxKALrxjgT1S4vdw+I5A2bKHo/hnOHg/Dc8Sfz2ib9/0hNrx+JPAq2CX9S7 zaTg== X-Gm-Message-State: AOAM5322UHMKchwOB2mp8mE/agfCuuCS7U/w/njyTZl8ghcgnQLPBSnN zYXdUJM4270u0OfuMHa6sW5v3PWG60Xwmaw6H2L234enpbSrYBYARmYqTbenpKyY4dlGEAsHNBX hiwiYbfQQcMZ6i+fQstkcwP5WFKAgWIn+NDjBmR8YMNAD9pMqXvzK+Rb8nKYjQuBQXQ== X-Google-Smtp-Source: ABdhPJw4YZaGcR5uxTNWBCrGwIaTtSLeLyemUybaL45xEobNA2YQzlQmRyhF3AFaiR90vXOv3YwhsA== X-Received: by 2002:a1c:2943:: with SMTP id p64mr13339082wmp.42.1590855491408; Sat, 30 May 2020 09:18:11 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id t129sm4317602wmf.41.2020.05.30.09.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2020 09:18:10 -0700 (PDT) Date: Sat, 30 May 2020 17:18:08 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, liming.gao@intel.com Cc: "ard.biesheuvel@arm.com" , "lersek@redhat.com" , "philmd@redhat.com" , "mliska@suse.cz" , "Kinney, Michael D" , "afish@apple.com" Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ Message-ID: <20200530161808.GB1709@vanye> References: <0f2f90b9-e2fe-5658-e507-299a387e0ce5@redhat.com> <20200528100515.GC1923@vanye> <6d6e3bb8-647c-42c4-5143-f64f5e6ba81b@redhat.com> <51509986-4950-30b9-73af-874bb991e355@arm.com> <20200530152257.GA1709@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Yes please. Best Regards, Leif On Sat, May 30, 2020 at 15:32:16 +0000, Liming Gao wrote: > Leif: > Thanks for your clarification. So, you request only one in ArmPkg to catch this stable tag 202005. > > https://edk2.groups.io/g/devel/message/59961 [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics > > Thanks > Liming > > -----Original Message----- > > From: Leif Lindholm > > Sent: Saturday, May 30, 2020 11:23 PM > > To: Gao, Liming > > Cc: devel@edk2.groups.io; ard.biesheuvel@arm.com; lersek@redhat.com; philmd@redhat.com; mliska@suse.cz; Kinney, Michael D > > ; afish@apple.com > > Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ > > > > Hi Liming, > > > > Apologies if I have caused confusion (since we have been discussing > > the same bug on both patches). This patch is *not* required for the > > stable tag. It will be useful to include *after* the stable tag. > > > > The intrinsics patch on its own resolves the problem (by providing > > resolutions for the generated function calls), whereas *this* patch > > tells GCC 10.2 or later (not yet released) not to generate those calls > > in the first place. > > > > Best Regards, > > > > Leif > > > > On Sat, May 30, 2020 at 15:10:07 +0000, Gao, Liming wrote: > > > Ard: > > > Lefi requests to catch this change into 202005 stable tag. I also > > > highlight this request in hard feature freeze notice mail > > > https://edk2.groups.io/g/devel/message/60421. > > > > > > If no objection before the middle of next week (2020-06-03), this > > > patch can be merged with the updated comments. > > > > > > Thanks > > > Liming > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > > > > Sent: Saturday, May 30, 2020 12:51 AM > > > > To: Gao, Liming ; devel@edk2.groups.io; lersek@redhat.com; Leif Lindholm > > > > Cc: philmd@redhat.com; mliska@suse.cz; Kinney, Michael D ; afish@apple.com > > > > Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ > > > > > > > > On 5/29/20 4:29 PM, Gao, Liming wrote: > > > > > Ard: > > > > > > > > > >> -----Original Message----- > > > > >> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > > > > >> Sent: Friday, May 29, 2020 1:47 PM > > > > >> To: devel@edk2.groups.io; Gao, Liming ; lersek@redhat.com; Leif Lindholm > > > > >> Cc: philmd@redhat.com; mliska@suse.cz > > > > >> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ > > > > >> > > > > >> On 5/29/20 5:18 AM, Liming Gao via groups.io wrote: > > > > >>> Leif: > > > > >>> I get the point that the linux distribution default GCC version may be 10 or above. Without this fix, those developers can’t > > pass > > > > >> build edk2-stable202005. So, you think this is a critical issue to catch stable tag 202005. > > > > >>> > > > > >>> Ard: > > > > >>> For this patch, I have two minor comments. > > > > >>> 1) I suggest to remove Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2723 from comments, because this information > > has > > > > >> been in the commit message. > > > > >> > > > > >> I think it would be helpful to keep it but I won't insist. > > > > >> > > > > > > > > > > I agree this is useful. But, we record it in the commit message. I prefer to remove this link from source code. > > > > > With this change, Reviewed-by: Liming Gao > > > > > > > > > > > > > > > > > Works for me. > > > > > > > > I will send a v2 after the stable tag is released. > > > > > > > > > > > > >>> 2) Can we think __GNUC_MINOR__ is always defined? Do we need to check its value after check whether it is defined or not? > > > > >>> > > > > >> > > > > >> Yes __GNUC_MINOR__ is always defined. > > > > >> > > > > >> > > > > >> > > > > >>> -----Original Message----- > > > > >>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > > > > >>> Sent: 2020年5月29日 4:03 > > > > >>> To: Leif Lindholm > > > > >>> Cc: Ard Biesheuvel ; devel@edk2.groups.io; Gao, Liming ; > > philmd@redhat.com; > > > > >> mliska@suse.cz > > > > >>> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+ > > > > >>> > > > > >>> On 05/28/20 12:05, Leif Lindholm wrote: > > > > >>>> On Wed, May 27, 2020 at 11:12:23 +0200, Laszlo Ersek wrote: > > > > >>>>>>>> Oh and I think both this patch and the assembly language > > > > >>>>>>>> implementation for the atomics should be delayed after the stable > > > > >>>>>>>> tag. gcc-10 is a new toolchain; so even if we don't introduce a > > > > >>>>>>>> new toolchain tag such as > > > > >>>>>>>> GCC10 for it, whatever we do in order to make it work, that's > > > > >>>>>>>> feature enablement in my book. > > > > >>>>>>> > > > > >>>>>>> Works for me. By the time the next stable tag comes around, early > > > > >>>>>>> adopters that are now on GCC 10.1 will likely have moved to 10.2 by > > > > >>>>>>> that time, and so we may not need the assembly patch at all. > > > > >>>>>> > > > > >>>>>> I'm not ecstatic that we'll be releasing the first stable tag known > > > > >>>>>> to break with current toolchains. > > > > >>>>> > > > > >>>>> If this breakage affects "current toolchains", then why was > > > > >>>>> only reported > > > > >>>>> on 2020-May-19, four days into the soft feature freeze? > > > > >>>> > > > > >>>> I agree the timing is crap. > > > > >>>> > > > > >>>>>> This isn't just affecting random crazies pulling latest toolchains > > > > >>>>>> down, but people using their distro defaults (native or cross). > > > > >>>>> > > > > >>>>> ... "people using their distro defaults" to *not* build upstream edk2 > > > > >>>>> until 2020-May-19, apparently. > > > > >>>> > > > > >>>> Or distro defaults changing in between. I mean, we could say "Arch is > > > > >>>> the same as any other distro's unstable", but I wouldn't want to go > > > > >>>> down that route - I know people who use it for developing also for > > > > >>>> qemu and linux. > > > > >>>> > > > > >>>> Argh, I also just realised the error report I saw two days after Ard's > > > > >>>> intrinsics patch hit the list was not a public report. Yes, if this > > > > >>>> had affected only in-development/unstable distributions, I agree this > > > > >>>> isn't something we should try to deal with upstream. > > > > >>>> > > > > >>>>>> I don't recall if 10.1 ended up being default in F32, but it was > > > > >>>>>> definitely included. In Arch, it does appear default. > > > > >>>>>> > > > > >>>>>> Debian/Ubuntu are unaffected in their stable releases. > > > > >>>>>> > > > > >>>>>> I agree it's a transitional issue, but I would really prefer to have > > > > >>>>>> the intrinsics included in the release. > > > > >>>>> > > > > >>>>> OK, let's delay the release then, by a few days. I agree the present > > > > >>>>> patch may qualify as a bugfix, but the other patch with the assembly > > > > >>>>> language intrinsics doesn't. If it's really that important to have in > > > > >>>>> the upcoming stable tag, then it's worth delaying the tag for. I'm > > > > >>>>> fine delaying the release for it; it wouldn't be without precedent. > > > > >>>> > > > > >>>> I would argue it *is* a bugfix, since it only has an effect on builds > > > > >>>> that would otherwise fail. > > > > >>> > > > > >>> OK. That's a good argument. From my POV, feel free to merge (both patches). > > > > >>> > > > > >>> Thanks > > > > >>> Laszlo > > > > >>> > > > > >>>> But I also do think it is important enough to delay the release if we > > > > >>>> feel that is necessary. > > > > >>>> > > > > >>>> / > > > > >>>> Leif > > > > >>>> > > > > >>>>> Also, I think Ard's assembly language patch needs a Tested-by from > > > > >>>>> Gary at the least (reporter of TianoCore#2723). Please reach out to > > > > >>>>> him in that thread. > > > > >>>>> > > > > >>>>> ... More precisely, please *ping* Gary for a Tested-by in that > > > > >>>>> thread, because Ard CC'd him from the start, and even credited Gary > > > > >>>>> in the commit message. > > > > >>>>> > > > > >>>>> Thanks, > > > > >>>>> Laszlo > > > > >>>>> > > > > >>>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >> > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > > > > > >