public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrei Warkentin" <andrey.warkentin@gmail.com>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie,
	philmd@redhat.com
Subject: [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI
Date: Mon,  1 Jun 2020 02:51:26 -0700	[thread overview]
Message-ID: <20200601095126.117998-1-andrey.warkentin@gmail.com> (raw)

EFIAPI should be set on all calls that can be called via pointer,
and it was missing for RpiFirmwareSetLed.

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
---
 Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
index 8cd8db7b..5302ccd8 100644
--- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
+++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
@@ -1101,7 +1101,6 @@ typedef struct {
 
 STATIC
 EFI_STATUS
-EFIAPI
 RpiFirmwareGetClockRate (
   IN  UINT32 ClockId,
   IN  UINT32 ClockKind,
@@ -1193,6 +1192,7 @@ typedef struct {
 
 STATIC
 VOID
+EFIAPI
 RpiFirmwareSetLed (
   IN  BOOLEAN On
   )
-- 
2.17.1


             reply	other threads:[~2020-06-01  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  9:51 Andrei Warkentin [this message]
2020-06-01 10:05 ` [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200601095126.117998-1-andrey.warkentin@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox