From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by mx.groups.io with SMTP id smtpd.web10.33640.1591005095166721712 for ; Mon, 01 Jun 2020 02:51:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kyoiuBy7; spf=pass (domain: gmail.com, ip: 209.85.166.195, mailfrom: andrey.warkentin@gmail.com) Received: by mail-il1-f195.google.com with SMTP id r2so8778617ila.4 for ; Mon, 01 Jun 2020 02:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=znRTybvbXIH7GGcaVS/hILVFLO4ZcTW++8b+8mMJSLw=; b=kyoiuBy7Mnst3jC1dTIfKdogXjXAYhCKa8Pt6bj3eKlTuUXpsa1U3KVfsr4a+Ruzpv IUTubM3rdXH7EAdQ0pJebbvZCHoDbTyNyLa+HQmvuKMafppzQ+bLBMQYTfF9A7BRygx0 y0fYjvRXY/IYsYEJXG9j5dwdFDsJhZrU0lwUQ+U+5GLdVyruLiccEzT2n2OCsAjaX+/f MEL12mDBZN7lKuFnHdfGYYc6WokFoasUy8RbBf66flE2oIQSAMqldcnNHtfyoNhi/yky w9i4IUadhgQzFf5YxkzwoNpV5WpSFPzi0Tq2GbnkW4lnITAeZZF7nZ90XoPR2dtWjJOs L9cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=znRTybvbXIH7GGcaVS/hILVFLO4ZcTW++8b+8mMJSLw=; b=YeVPJnrsC9XmX1BFqfG/t23bT+4DEZ/Ji1JJorUFfUdpo3p9m2OVdoEsveO6jLX5Zv utnHZxeIJzDfdy+OaNFU2BJbG0d0cnGU8/n/nezCgLYYve6BtoU2kIfaq+R3iaGd6QgD JhPCoYK7Qh2s9FFHfr4+YVja6ojqOPtSmAxzdk7b4i7bv8jyEysPKjSFLf2hx7vViATB anOrts8/VxqguZ/OMg3JtPIxusD+X1sH/7LXRPYG31xypnRI1o18pAPYi7b+goB1Z1jQ qYq1YGX7uf2hpKvnUbVEqt+S+bKV0EWc/Y/DLKXVhI5rsE+zi/SDzHR9BOuDJIF+2KT7 Yj+Q== X-Gm-Message-State: AOAM5307em/gpaFLtIu6yOxaoH9xRoO7C0CRMpzcA/gFJNLNuEOgGtoW T3oWbZ19SoCAt+spQjoSBBby5Cdm X-Google-Smtp-Source: ABdhPJw/GRVvl4ySzOL6ygRQJiBmivlIkhLQnI+2oGmPEKpx3fNnYXJNm0VuANVH45kkeMbvg0JOfg== X-Received: by 2002:a92:190:: with SMTP id 138mr13144990ilb.5.1591005094421; Mon, 01 Jun 2020 02:51:34 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-98-214-99-181.hsd1.il.comcast.net. [98.214.99.181]) by smtp.gmail.com with ESMTPSA id r17sm9624869ilc.33.2020.06.01.02.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 02:51:34 -0700 (PDT) From: "Andrei Warkentin" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, philmd@redhat.com Subject: [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI Date: Mon, 1 Jun 2020 02:51:26 -0700 Message-Id: <20200601095126.117998-1-andrey.warkentin@gmail.com> X-Mailer: git-send-email 2.17.1 EFIAPI should be set on all calls that can be called via pointer, and it was missing for RpiFirmwareSetLed. Signed-off-by: Andrei Warkentin --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c index 8cd8db7b..5302ccd8 100644 --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c @@ -1101,7 +1101,6 @@ typedef struct { STATIC EFI_STATUS -EFIAPI RpiFirmwareGetClockRate ( IN UINT32 ClockId, IN UINT32 ClockKind, @@ -1193,6 +1192,7 @@ typedef struct { STATIC VOID +EFIAPI RpiFirmwareSetLed ( IN BOOLEAN On ) -- 2.17.1