From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.35063.1591012511749982340 for ; Mon, 01 Jun 2020 04:55:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=MglQ8/Gv; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id y17so11164816wrn.11 for ; Mon, 01 Jun 2020 04:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gRcWxI+VTyYBIXAVB7p9/CsurHb+hfOIf9U8klsL744=; b=MglQ8/Gvgi567Ru6DtmrqhoP+J+J3FJElmGbh4fOD1XeihW5slndqz6Gn5MEHxJwYj Dx/RgQVipJaQuG8kVhJpMCRQox/yfzhRSiLK7a8kM9Ek0ZyZz0h4GzENl2WCqJFBgsuJ dlCeTpvF4eNbrZMQs4k6Kkd1O8nhoF0iaSx3NB9+rzw2eGbOEW8+wAeqNl0p66jSkaue wNt//xu5St4f7Wt5bXkO1+WTbJUu3RFmjOU6tQ/mFcyKLFJGxn95LUwVDAsXjeOrgZRE ohyXtKo+5WOoSZdYbOANUZ/FHi8wFPY2KkdFfzPNeYdkuUO1mYw8mAVpbjZ1wSkw/Na6 ABhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gRcWxI+VTyYBIXAVB7p9/CsurHb+hfOIf9U8klsL744=; b=S7e5vBUA4f8J6+EKIo/bmVnpZs1hbb6xtLnykesU6NZAlnWdM74CXKNO3EYA0G2z8J NT24sVZEaaP4B2IHGZXb4OugKULMqWuNZIPQhbUdxkO+ZlJ66J4g007IRWpeX3IBKycF GDy61f/xQreLPZ7bIGd9tTcKk5KMkJH/N4aTvcCsELltOwQGvuroYvo0oVf6GtVg2/T3 yCAOHfzlv2/UNSq5ndWxhPNMfIdEyKO/4BdJzdFOrn8aLY6JjGdGeW+hgPyM3xxGbySt d97xSHG97XrE0jDUySH7rL5OD/dNjkqV8JBo80jh0CiV7ybd2pJY7Gd8HVa66eob+Vkz Sukg== X-Gm-Message-State: AOAM531ZlUYdBehgA83IsTL2uWii47uBs28sCEGKKYXbi5JRedcr6o9C 7Ctypf6gJZGzPEWNanMpYboy0w== X-Google-Smtp-Source: ABdhPJyMac1mjqLJnYDYotfg7pEMOEoHCR/rdn/fKcrREIDBWNAvCCQmOKi2ecfcDyVrEAu+X3Ccfw== X-Received: by 2002:a5d:4385:: with SMTP id i5mr21095522wrq.420.1591012510331; Mon, 01 Jun 2020 04:55:10 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id u23sm13750844wmu.20.2020.06.01.04.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 04:55:09 -0700 (PDT) Date: Mon, 1 Jun 2020 12:55:07 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao Subject: Re: [PATCH v2 2/5] ArmPkg/PlatformBootManagerLib: fall back to the UiApp on boot failure Message-ID: <20200601115507.GB28566@vanye> References: <20200528091741.14610-1-ard.biesheuvel@arm.com> <20200528091741.14610-3-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200528091741.14610-3-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 28, 2020 at 11:17:38 +0200, Ard Biesheuvel wrote: > As a last resort, drop into the UiApp application when no active boot > options could be started. Doing so will connect all devices, and so > it will allow the user to enter the Boot Manager submenu and pick a > network or removable disk option. > > Note that this only occurs if even the default removable filepath > could not be booted (e.g., \EFI\BOOT\BOOTAA64.EFI on AArch64) > > Signed-off-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm In fact, feel free to merge this one independently if set still being discussed after stable tag is made. > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 23c925bbdb9c..85cb32f6d7cd 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -830,5 +830,15 @@ PlatformBootManagerUnableToBoot ( > VOID > ) > { > - return; > + EFI_STATUS Status; > + EFI_BOOT_MANAGER_LOAD_OPTION BootManagerMenu; > + > + Status = EfiBootManagerGetBootManagerMenu (&BootManagerMenu); > + if (EFI_ERROR (Status)) { > + return; > + } > + > + for (;;) { > + EfiBootManagerBoot (&BootManagerMenu); > + } > } > -- > 2.17.1 >