Re: [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, May 28, 2020 at 11:17:40 +0200, Ard Biesheuvel wrote:
> Without ConnectAll() being called on the boot path, the UEFI shell will
> be entered with no block devices or anything else connected, and so for
> the novice user, this is not a very accommodating environment. Now that
> we have made the UiApp the last resort on boot failure, and made the
> UEFI Shell accessible directly via the 's' hotkey if you really need
> it, let's hide it as an ordinary boot option.

Am I being confused here, or is the word "hide" a bit unfortunate in
the above sentence? (It'll still be visible in the UiApp menu, right?)

/
    Leif

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index 85cb32f6d7cd..1e9b736993d0 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -777,9 +777,7 @@ PlatformBootManagerAfterConsole (
>    //
>    Key.ScanCode     = SCAN_NULL;
>    Key.UnicodeChar  = L's';
> -  PlatformRegisterFvBootOption (
> -    &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key
> -    );
> +  PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", 0, &Key);
>  }
>  
>  /**
> -- 
> 2.17.1
>