From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.35424.1591012918268249877 for ; Mon, 01 Jun 2020 05:01:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=toVNMgTy; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id j10so11201080wrw.8 for ; Mon, 01 Jun 2020 05:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IlH8gPdMIeW7Q0OvcZSxKVN53zB3HL3rW1jHu63emaE=; b=toVNMgTyuQ+ID/WlujN0r/6ncfBKnI172lTR0eEnUt9APKrbsw3KoLpZeox3CLEFq8 /j0zVPX/Q+cqUzzORJdaBB81ww1bBkv1AZZAaXSNccLSCumfQivfNvPwAx9wZsN24/Yx kpn+1aBeiVO4IPiaJ63bpr543X7y5hlK3KS6IIwB5DS5C0x7m0b0L+9WTaKY6WOgqg7O rbp1MRUHDhFeLCKCXdNo13HqkHikOSuoJQn6ERfpoJeOF+GiiM1rGpIsF5Ym0BJ7Uvps CL9q2bRwWtB+kqQx+HpqOVPJoAPU04e0Qa4wFSzAO6o9bbeF5C1YgolP5vbZ6m8zIrji lnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IlH8gPdMIeW7Q0OvcZSxKVN53zB3HL3rW1jHu63emaE=; b=qOACF4gArzDXMALxFpcf6Fg6xla/5YnfLbk5Jm0TgYDpXCgJpfP4J1wg2HmVmc/701 ov7b7wVfVcy1sA2AwL3ZoMq/EeiVzVg5gYnhETOMdJd7cRy9jHF/9Ab3vW2B+Fytuh9x JhFhIJ0QC3vz7WXMWtWuILYIMNB6SRAC/r0WA5yRNVNeK1SoJ4byRygQvB0JBWOPOOP/ bvcQLu18s0IDs/Ws2EEd0U2T2dvTkYERiM9g9kiy+WizjT60NKfV63kOKlninCjJnQtZ 7gg+DWrrC172zJ/mlmzQ5mC5oMXBjA4ETiDFBsU6I8715f9f1uO2cDwUxQ4WvUbJrY2e wzKQ== X-Gm-Message-State: AOAM531g7pdAB1VCHWyrmwuXVC29+X01B1+xdHcZAP6wDv3d2p9mT7iZ sjB4XsFP5kAA+LtGnNusWN1EEQ== X-Google-Smtp-Source: ABdhPJyr+fBD5AiE95MaCZL2Kjdl9DqhiXRWPlnQUJOY0zcEh8sPK5kCuTbVHQ/kGo5hlQOMGymMww== X-Received: by 2002:a5d:500c:: with SMTP id e12mr21798721wrt.359.1591012916807; Mon, 01 Jun 2020 05:01:56 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id u7sm20807464wrm.23.2020.06.01.05.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 05:01:56 -0700 (PDT) Date: Mon, 1 Jun 2020 13:01:54 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao Subject: Re: [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option Message-ID: <20200601120154.GD28566@vanye> References: <20200528091741.14610-1-ard.biesheuvel@arm.com> <20200528091741.14610-5-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200528091741.14610-5-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 28, 2020 at 11:17:40 +0200, Ard Biesheuvel wrote: > Without ConnectAll() being called on the boot path, the UEFI shell will > be entered with no block devices or anything else connected, and so for > the novice user, this is not a very accommodating environment. Now that > we have made the UiApp the last resort on boot failure, and made the > UEFI Shell accessible directly via the 's' hotkey if you really need > it, let's hide it as an ordinary boot option. Am I being confused here, or is the word "hide" a bit unfortunate in the above sentence? (It'll still be visible in the UiApp menu, right?) / Leif > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 85cb32f6d7cd..1e9b736993d0 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -777,9 +777,7 @@ PlatformBootManagerAfterConsole ( > // > Key.ScanCode = SCAN_NULL; > Key.UnicodeChar = L's'; > - PlatformRegisterFvBootOption ( > - &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key > - ); > + PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", 0, &Key); > } > > /** > -- > 2.17.1 >